From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 738FBC3DA61 for ; Wed, 24 Jul 2024 17:05:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 143666B0096; Wed, 24 Jul 2024 13:05:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CCAE6B0098; Wed, 24 Jul 2024 13:05:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAFCC6B0099; Wed, 24 Jul 2024 13:05:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C1A3C6B0096 for ; Wed, 24 Jul 2024 13:05:09 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 615CBA0911 for ; Wed, 24 Jul 2024 17:05:09 +0000 (UTC) X-FDA: 82375271538.11.0BF320C Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf12.hostedemail.com (Postfix) with ESMTP id 2D89E40017 for ; Wed, 24 Jul 2024 17:05:06 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=PgmzEeOk; spf=pass (imf12.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.41 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721840683; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MtL8RkoaQ1vk5r9hq79DrEjgulqqHqTEQUIMT0i31RU=; b=PYPqZCaKajFG5HCGaPh59mohXEkYTlf2GpYO05jdeckps+Vvjxdr84xUmbk7VBALQeCQ/x 1zBCUXJ5WKgO9vxhWf4hObdzzBgopK3SzE1QAki12IrdkQqF+w4YoD2vrnjXw212dap6rX 80faBXHKx4aCaZRVoV60D9Kc6O/x6Ww= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=PgmzEeOk; spf=pass (imf12.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.41 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721840683; a=rsa-sha256; cv=none; b=rht3xmt9Xm0TaBqDUUq4pCPq6puFhhm1zLa5Or9m0/JW/kKJ6x0rOvpYerA/Gv5KeIDisk f/LWP2wjFkZ2lNnWnv7LjOAvn220BGVwdTExyrUojCSLOEWQ5RXSodL4qV31FZ69GBKPrD KozyKGZqbC6+DLcQdB6lfD3tM+EWVnk= Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a7a94478a4eso209174766b.1 for ; Wed, 24 Jul 2024 10:05:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1721840705; x=1722445505; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=MtL8RkoaQ1vk5r9hq79DrEjgulqqHqTEQUIMT0i31RU=; b=PgmzEeOkNEp0c478sUsz3oSrF401o0qoNg6oxBWVYGqhK5eQYIf/THvI6mI+G2HYVx DJbrkGi9BpVaY9AN4WPlyMyUFHzMXUpuCP3xjfPlYzPEJKXluz1GPCitAfp6zEiSg/Wn ILkR05YcePaT+NbKbOMTGlbYhl0DXfAsc/ud0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721840705; x=1722445505; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MtL8RkoaQ1vk5r9hq79DrEjgulqqHqTEQUIMT0i31RU=; b=CQ3JuQbilENSXHqHu3+EmU5e8/N1J7TBAIJm4gvJWM3HHbYVBCPQ/H0C+WX+7YGxy6 Q/jmw9d6TzDzAGkRFZrB3qj/yg8458KuzwgvW/zcW9YRnYr9Kdean55Hx4APNQcHXuqH fTg9oCqgtY2S5sjehLhaPN+Ajm3xnzu1Pg8sORdbcrOJLmWCNo++g9ldZrzMJPXQjXRe Si7me3ArUaY8amcFtHnw+brlatwNs7UqGspbaMcMF0+eP3DEZ5ZoWpGHTZQQgAUXJlFa X2up6xEhSd2p9AQZEZgqX6lH9bK3vaIl23IGsZ8sWb0Z2s/bi0iLaVXf50AiS8NG4MKi ViZA== X-Forwarded-Encrypted: i=1; AJvYcCXorY4ntALTZYCCIlCUvzJcWUq36Padp/yMf8CEdpEU2545F0rGaLHbypYmASkOJE6arLq9UMnAEh9EDztUkeArIK8= X-Gm-Message-State: AOJu0Yw/ZRptGp6MsiRc9DqII44iv9vjkBUFJaysprfUI6nDX36uNXAk y2tDdKXlE/ArJlMNwW821HLk2Xx9GclvrQOmTGuw/OPXn23ERzGAi/L0cZwln3HsIRtB9mRv7/A YZmx7SA== X-Google-Smtp-Source: AGHT+IFvfixpCCd+FsJ2uJuyjW0yOn9TARVEVIbA/xa3NdtaqjpAR+aw9V2jhqm4hn96ahZfmp6VMA== X-Received: by 2002:a17:907:9444:b0:a7a:130e:fb6e with SMTP id a640c23a62f3a-a7ab2cfe034mr279158466b.15.1721840705247; Wed, 24 Jul 2024 10:05:05 -0700 (PDT) Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com. [209.85.208.50]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7a3c8be831sm661170766b.98.2024.07.24.10.05.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jul 2024 10:05:04 -0700 (PDT) Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5a2ffc34722so164938a12.0 for ; Wed, 24 Jul 2024 10:05:04 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWzrhTGV6XT5TAfkfxxlM/vqqx60y7mQIOuveioSwGBJDGEr+DOFSpsSjvGKEJyTaowpnX/ocJK2dBAX02+fN66uEI= X-Received: by 2002:a05:6402:3511:b0:58c:36e:51bf with SMTP id 4fb4d7f45d1cf-5ac123a7ac3mr287347a12.3.1721840704253; Wed, 24 Jul 2024 10:05:04 -0700 (PDT) MIME-Version: 1.0 References: <20240724010550.1755992-1-willy@infradead.org> In-Reply-To: <20240724010550.1755992-1-willy@infradead.org> From: Linus Torvalds Date: Wed, 24 Jul 2024 10:04:46 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/2] Remove PG_error To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 2D89E40017 X-Stat-Signature: 1ud34qudcgfo55nis7fd3zsr7o7f38od X-HE-Tag: 1721840706-800179 X-HE-Meta: U2FsdGVkX1+ykGb0Jf9hOtTTO1PUwqPNGv6DZ02CDeI1EZeb4dBFAxKreSV0RKRKYrAzRl9LYQoO27dfUbOsgJKmQYs7paL6iQyN+p1bVsKY4XX4juA7WMd6hLVM8uIpGBdI4KczeRyfQRB5qtgnfwyXmOZg+Ocmw08V+68RN1HEJVpZga+Ll1SQ3HWeVsU2THFgQaspqiqLgK+FugmaWjMnzE6hWu4Yf2G+OJLbhEFMy2YUAvsxB8Jj4In35Lo4MOMF5+uA7/GCQjKj5qqUrt5ReD3AqlMtZYtnbkvFrtcQ/N7vOhjmKyLI6KTt70ZueVpT/juiJniCnvnjrc/dsrWvaMpwpqdcEB5v2AgLmLMlcj1TRt9iATYTPDpMmVMwZp6zSvklPWq0PbJbFihi9SNFncgNpzcxuRuTJtRkFeVNxyaan9en6G+QQ5H5r1EGKhevKsQY0R1b0uEOm3s9z6sv2EJLvOhPXvkboqhPdqvWKK0vZ+/dm7VqOQxmrUKvb3XQNCbb9yuNM0NWEUrqSOOfMIYzuAt/SVcZWwjd3BHl0tcfrQPXxhP/k4bZ35V/CPuDFweJgqUFOMZjrQy6LWWTlGY2uOoe5nvYuq+vmD/m7g6tGWwOJLEnf0C+GJrkEbkdvEm8wzcSnSeU0Nj816Szlniv+Carl0ufr3LIyMLSdo2E4QYHhVPkvRH01EZxmkpbm/L+vvpWFqWhNdiPNcrYeXbRAyIgpROmT0Uh2vAXKba3ig1PrrT1qClMd98uAwjBhmQrZJfp950JvYq3j+sF4HnzWveqBUgYzMaZXqZs7AEc6JpGP2SfqPAjDQ9jTiOwLKqYUnq0TFSJUICzYMN8KfJcudzKEM9PqzwjhsiHvygDXyb18wdDyC8GXISAzc3RmQS909qdxj8CS40vjNKFbc9CWDYESfiZUt6kLDybj6MbZ+R/OOFOZmAVRvo3KgR4h+8nA8ZnhmqM9Zz 9A57J3Yi RnT9BsucMUslQbzgH112EpMCF4AXcsXdIn/njAUH68Ju7WnGUSbB3JdCrW41XlHClQvaOFomTC2muli8qAHqnQe7zhVnbAEVTCEpcTWZybLDXyyIp91uNpL2kyDDF+kHFv8W/ZUkGoq1aStcYxWPU2VCxIqoU0Th7LmFWkLCk5vF0V7xuRgUtlwOWk6aGPfNt78a5xx6N4bVWrOwicThzG166fpL7aRenUJCEsPKwmy9gPZ1AzqfF36PhPPQ/16q1dtrKGrpmo2TONKTYtFX1wFRbq/LXft9wNbjmZAGlwK9KhN+PaG+z7akX4GCQcuOhpVuOz3g+f1MbLqDcz7tkNxYCL1A/SlcoCNvR7qxYX6IFQckxOZHqXs5fymVRa3QEZJ/CBHck9Klo6oc7joY+XUfZ+o7Lgkt3xGIB3k7ONUEfUhyTQBhrQ6CeA++R83aBQX9w4f+mjMXFIX1Lt3P4rzGvcOhlelyrh894whFoda/WkroSTUdeIKPcibKndqXSf1lbahTRnCP75Pu8BpI5OPckuhdDRnCDyaiGHeLc61MDiIYV7UEiZyks0uguWx/47sYhgeoAJJ4iEGOL61Y5pmzIHA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 23 Jul 2024 at 18:05, Matthew Wilcox (Oracle) wrote: > > There were four pulls I had to wait for before I could send this to you, > but PG_error is now unused and can be reclaimed. It could wait until > next merge window, but I don't see the point. Well, I was initially inclined to agree with that, but then I did a test-compile, and that immediately notices that you never tested this at all and that it's completely broken. There's still uses of PG_error in fs/proc/page.c, and in include/trace/events/mmflags.h, and neither of those two cases are new. One is unchanged from 2009, and the other one has gone through a few code movements and re-orgs but also goes back over a decade ago. So clearly this needs to be in linux-next, and as such this very much is "next merge window". Linus