From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BD27C433E0 for ; Wed, 15 Jul 2020 23:05:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3E3282065D for ; Wed, 15 Jul 2020 23:05:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="VfbflGy/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E3282065D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CDE956B0008; Wed, 15 Jul 2020 19:05:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C8F706B000A; Wed, 15 Jul 2020 19:05:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA4E06B000C; Wed, 15 Jul 2020 19:05:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0205.hostedemail.com [216.40.44.205]) by kanga.kvack.org (Postfix) with ESMTP id A175E6B0008 for ; Wed, 15 Jul 2020 19:05:10 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 13A152DFA for ; Wed, 15 Jul 2020 23:05:10 +0000 (UTC) X-FDA: 77041842780.02.wood53_290f31426efd Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id DC71730002427270 for ; Wed, 15 Jul 2020 23:05:09 +0000 (UTC) X-HE-Tag: wood53_290f31426efd X-Filterd-Recvd-Size: 5868 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Jul 2020 23:05:09 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id e8so4757073ljb.0 for ; Wed, 15 Jul 2020 16:05:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=b7b58/h5ygcF8kKv7hgx0H1e7z/j3xwcZDk14pT0DbM=; b=VfbflGy/HM2cZzGH0dNGp5YQ7VcJfDItB1n+tAqhFQc6mj3d7qLNTmWwWTJdwZ9MSa +75uVzkhz7POD0P5pLG4XiPzOv+Iqp4wbAloW9OKLMJk4B2QaI9cbBqJkPNl5tTef6DK 4x+iZ9WNsUegvLM+Y8yj19d7Z/iz8UalyR9TM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b7b58/h5ygcF8kKv7hgx0H1e7z/j3xwcZDk14pT0DbM=; b=MVwUtR+jl1n1luPbLsXYjbdcrABHiLACkaT7VAODFnni6nonGefBjTpGtQCwOJa1M5 pCgQEI2CB5859cWnj7C+YINtR5NR6oqraD6iZvcIZDiB6QZ+EMd+r85A6U2qORn8XMlz TeQ8pv5hepanQF4t5j5EaK383becd5XZKspf4SAhy3WuXRxpIS6BFfECZ74dlkUsP3Us SPuGym6E9UknbB26WvM5RKZWG2fru4m/Nih87dM9fQlj2eSIZLp2Op2o5tzDHH1i/vHf CRI7DNJ/lqIACC3p2aroCCd5F3BWSvB25vmqUmv5FqWsEiDmJbeXuybE4NzPdhMIMAS6 Gqeg== X-Gm-Message-State: AOAM532Ci9eLLGMRVizGapQFxJbV/n6nRuL6ZVh81g+2RKUTOirjy/dc jACoEfTNNWE4nZxDnZJFpccfvB4rt6M= X-Google-Smtp-Source: ABdhPJy62yCYrgvjt8uz5QHlEiW+X3RVeGhH4vbpy/ftoQliKOTVo3xu+Gk3X+pcmnUr9WFVT+/+Zw== X-Received: by 2002:a2e:b019:: with SMTP id y25mr625335ljk.47.1594854305512; Wed, 15 Jul 2020 16:05:05 -0700 (PDT) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com. [209.85.167.42]) by smtp.gmail.com with ESMTPSA id u8sm769087lff.7.2020.07.15.16.05.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jul 2020 16:05:04 -0700 (PDT) Received: by mail-lf1-f42.google.com with SMTP id y13so2078292lfe.9 for ; Wed, 15 Jul 2020 16:05:04 -0700 (PDT) X-Received: by 2002:a19:8a07:: with SMTP id m7mr619665lfd.31.1594854303661; Wed, 15 Jul 2020 16:05:03 -0700 (PDT) MIME-Version: 1.0 References: <20200715135011.42743-1-kirill.shutemov@linux.intel.com> <20200715205428.GA201569@google.com> <20200715222228.jf2pv5u2wyhtc5o5@box> In-Reply-To: From: Linus Torvalds Date: Wed, 15 Jul 2020 16:04:47 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCHv2] mm: Fix warning in move_normal_pmd() To: "Kirill A. Shutemov" Cc: Joel Fernandes , "Kirill A. Shutemov" , Andrew Morton , Linux-MM , Linux Kernel Mailing List , Naresh Kamboju , William Kucharski Content-Type: multipart/mixed; boundary="0000000000003d291905aa82f406" X-Rspamd-Queue-Id: DC71730002427270 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --0000000000003d291905aa82f406 Content-Type: text/plain; charset="UTF-8" On Wed, Jul 15, 2020 at 3:57 PM Linus Torvalds wrote: > > But now I've screwed it up twice, and have a splitting headache, so > rather than stare at this cross-eyed, I'll take a break and hope that > somebody more competent than me looks at the code. I lied. I had a couple of pending pulls, so I couldn't go lie down anyway, so I tried to take another look. It *might* be as simple as this incremetal thing on top, but then I think that code will no longer trigger on the stack movement case at all, since there we don't work with the whole vma. So if we want that to work, we'd have to fix that up too. And this might be broken anyway. My track record isn't looking so hot right now. Linus --0000000000003d291905aa82f406 Content-Type: application/octet-stream; name="patch.incremental" Content-Disposition: attachment; filename="patch.incremental" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kcnz23n30 ZGlmZiAtLWdpdCBhL21tL21yZW1hcC5jIGIvbW0vbXJlbWFwLmMKaW5kZXggNjE0YjRmZmZlZDFk Li42YzNkZjAyMmZmNjQgMTAwNjQ0Ci0tLSBhL21tL21yZW1hcC5jCisrKyBiL21tL21yZW1hcC5j CkBAIC0yNDMsNiArMjQzLDkgQEAgc3RhdGljIGlubGluZSB2b2lkIHRyeV90b19hbGlnbl9zdGFy dCh1bnNpZ25lZCBsb25nICpsZW4sCiAJc3RydWN0IHZtX2FyZWFfc3RydWN0ICpvbGQsIHVuc2ln bmVkIGxvbmcgKm9sZF9hZGRyLAogCXN0cnVjdCB2bV9hcmVhX3N0cnVjdCAqbmV3LCB1bnNpZ25l ZCBsb25nICpuZXdfYWRkcikKIHsKKwlpZiAoKm9sZF9hZGRyID4gb2xkLT52bV9zdGFydCkKKwkJ cmV0dXJuOworCiAJaWYgKEFERFJfQkVGT1JFX1BSRVYoKm9sZF9hZGRyICYgUE1EX01BU0ssIG9s ZCkpCiAJCXJldHVybjsKIApAQCAtMjcwLDYgKzI3Myw5IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCB0 cnlfdG9fYWxpZ25fZW5kKHVuc2lnbmVkIGxvbmcgKmxlbiwKIAlzdHJ1Y3Qgdm1fYXJlYV9zdHJ1 Y3QgKm9sZCwgdW5zaWduZWQgbG9uZyAqb2xkX2FkZHIsCiAJc3RydWN0IHZtX2FyZWFfc3RydWN0 ICpuZXcsIHVuc2lnbmVkIGxvbmcgKm5ld19hZGRyKQogeworCWlmICgqb2xkX2FkZHIgPCBvbGQt PnZtX2VuZCkKKwkJcmV0dXJuOworCiAJaWYgKEFERFJfQUZURVJfTkVYVCgqb2xkX2FkZHIgKyAq bGVuLCBvbGQpKQogCQlyZXR1cm47CiAK --0000000000003d291905aa82f406--