From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73AFCC433F5 for ; Wed, 12 Jan 2022 20:44:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC1B16B024A; Wed, 12 Jan 2022 15:44:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A6F6D6B024B; Wed, 12 Jan 2022 15:44:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 937076B024C; Wed, 12 Jan 2022 15:44:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0001.hostedemail.com [216.40.44.1]) by kanga.kvack.org (Postfix) with ESMTP id 7FC466B024A for ; Wed, 12 Jan 2022 15:44:21 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3F78F180AB9EC for ; Wed, 12 Jan 2022 20:44:21 +0000 (UTC) X-FDA: 79022812722.09.B5F84BB Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf30.hostedemail.com (Postfix) with ESMTP id 7956A80007 for ; Wed, 12 Jan 2022 20:44:20 +0000 (UTC) Received: by mail-ed1-f50.google.com with SMTP id w16so14730612edc.11 for ; Wed, 12 Jan 2022 12:44:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=j8SeuaAUoRvkQG6RL0Ukp8ol0ZJU1LNjuSi9Kp+pFIM=; b=DgBy6+WOEAEg/H3eLNbDatNQLaSQLyRz0Z3CCJaiNWjyVS49XxRUVqVeWbuoWerGsX doRMnfGUdk9hKjX1wxBfz5bCjfwsOBQzwRtLryNrPq5NYJF29c7lI6DEises+owfi3Dq tU3MOELUIh56aQJfSegT7aYNadkG0Ni2koCv4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=j8SeuaAUoRvkQG6RL0Ukp8ol0ZJU1LNjuSi9Kp+pFIM=; b=ar0QvAorq3MEB42joCGmlti3SN2hlffg2I7xHV7mOPzpAPobm15pfzO2vEJ9d+Y4XZ cEj4BP2MHU6P9KhDmA/YALkLwlSMVw5wPaJvK7uO+ZUsn1C56lpj12hSWGtXy1U/VgzD GHZ29sud/Prxb4xFdRs5d5lydAf3d/HJXArlg/tjv7bJQFvR77n0/5ADACmy2BO/6nv8 gESYsm2SvlB5lU9zYYmlPBr37QQFJ0DXruwhNUp/kROgdfKzuXZh/5zlplWLfjuFbvow 7Rknd7dJzmP/vyIxe0JSIJDKTNvbmOAYjtOENws7gwPjaCT1I2jLR7NQJeDCFfP4m/TE Ijkw== X-Gm-Message-State: AOAM533/OORshbdSeCH58sH9pSypkNsKzCKm2vmjQr7VJPWUCntSSCrD M2AWkvUe2XEszDzdTmUMCOLlhEOLbP+lgwvD X-Google-Smtp-Source: ABdhPJxT5EDSUbbXiivrdoFkScY3dy1KQe2V23WR07jsErJxsLAA940c1CarUaVgBW8rfTsxnX4sYg== X-Received: by 2002:a17:907:a412:: with SMTP id sg18mr1149003ejc.2.1642020258850; Wed, 12 Jan 2022 12:44:18 -0800 (PST) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com. [209.85.221.48]) by smtp.gmail.com with ESMTPSA id lm24sm242724ejb.2.2022.01.12.12.44.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jan 2022 12:44:17 -0800 (PST) Received: by mail-wr1-f48.google.com with SMTP id s1so6401917wra.6 for ; Wed, 12 Jan 2022 12:44:17 -0800 (PST) X-Received: by 2002:a05:6000:1846:: with SMTP id c6mr1202991wri.193.1642020257445; Wed, 12 Jan 2022 12:44:17 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Wed, 12 Jan 2022 12:44:01 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] Page cache for 5.17 To: Matthew Wilcox Cc: Linux-MM , Andrew Morton Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 7956A80007 X-Stat-Signature: rdfw9aqg5dkg1jjd7a1q6y9nex7a68sn Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=DgBy6+WO; dmarc=none; spf=pass (imf30.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.50 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-HE-Tag: 1642020260-598506 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 10, 2022 at 2:10 PM Matthew Wilcox wrote: > > Convert much of the page cache to use folios So I note that you tend to still sometimes use 'page' in the commit messages and leave them in the comments. For example: > filemap: Drop the refcount while waiting for page lock or the comment (and function name) in next_uptodate_page(): /* Has the page moved or been split? */ and obviously also function names for first_map_page()/next_map_page(). I don't mind, but it's an odd kind of inconsistency, where the code all uses 'folio', but then the function name and comment wasn't updated. Sometimes you _do_ update the function name, sometimes you don't. Maybe there's a pattern I'm not seeing. Anyway, regardless of that small nit - pulled. Linus