From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFE66C433EF for ; Mon, 20 Sep 2021 23:30:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4E16860F56 for ; Mon, 20 Sep 2021 23:30:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4E16860F56 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id DF044940009; Mon, 20 Sep 2021 19:30:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA08D6B007E; Mon, 20 Sep 2021 19:30:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C40CE940009; Mon, 20 Sep 2021 19:30:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0158.hostedemail.com [216.40.44.158]) by kanga.kvack.org (Postfix) with ESMTP id B5F336B007D for ; Mon, 20 Sep 2021 19:30:13 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 644872BA64 for ; Mon, 20 Sep 2021 23:30:13 +0000 (UTC) X-FDA: 78609547506.28.F898C94 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf26.hostedemail.com (Postfix) with ESMTP id 2401C20019C9 for ; Mon, 20 Sep 2021 23:30:13 +0000 (UTC) Received: by mail-lf1-f46.google.com with SMTP id e15so35326019lfr.10 for ; Mon, 20 Sep 2021 16:30:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F04phcRQSPUfY7ZkC6X/DRscrySixKvQV8Zj2GiRtvM=; b=C7gc4AzPAKAay4aiwe2Peik4mHpQuwTIEtFvC3AJfU1kJWQtPOpHiQH+hcsqMYD9ZG uT+bzPh9384fxb4Ov2BYgcC3she9ny1rmd4su0zK64zXI4AqFwRbCUnnAkuDr6nq+GAq vC78VMXmBENpN4acXFfAgaGfSlTDblODT0de8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F04phcRQSPUfY7ZkC6X/DRscrySixKvQV8Zj2GiRtvM=; b=FhprrYDlUzAdvrPc5avNNDnWBldRtAEqmDZIru8SU6xacwCbEFXrZPZOj45hYlBABN i50gbdyaPYiVcRL66pBv2DgnlssWxcU4xiWYXCqDSdSEMt+HYczjxE20nZXvLsh3/4oy BmZmJOryoJ+Id7v7ozqpNtMDux4PPiCzm7Sxaeq7CdSM4gA0Dz6IpSn1Oy6Wh7n2exPk Po+cy9Mmdlk6Yyv1+oNLzID/RhK2oWsGbId7knFmZs2GOSmu/j37loD+1ZJ+5iNCLd5o hszZ7S+GsCdkDyuKfdwo2X6s/iquGA+sFrGpvPhcuIvJ7rVJZ9hdVPle9erE67ywcdXp iEwg== X-Gm-Message-State: AOAM532iVaurP10qmJJYKa9NsaJC+P62eeDdNwgBt7n8GVsAV7vbL8rE fIRzbU+DUXKu8hX1VESYp5tJ5abOG/QmX70frtA= X-Google-Smtp-Source: ABdhPJzFtpKA8J8kCAVt5b5mw0+6lL0cEcVUwQGVMLKs4i3///17JXnHrn2IdOb7yK8gE42MEYNoxg== X-Received: by 2002:a05:651c:243:: with SMTP id x3mr14710436ljn.12.1632180610024; Mon, 20 Sep 2021 16:30:10 -0700 (PDT) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com. [209.85.167.48]) by smtp.gmail.com with ESMTPSA id h5sm508866lfm.230.2021.09.20.16.30.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 16:30:09 -0700 (PDT) Received: by mail-lf1-f48.google.com with SMTP id y28so72544690lfb.0 for ; Mon, 20 Sep 2021 16:30:08 -0700 (PDT) X-Received: by 2002:a19:ae15:: with SMTP id f21mr20462696lfc.402.1632180608608; Mon, 20 Sep 2021 16:30:08 -0700 (PDT) MIME-Version: 1.0 References: <20210907212347.1977686-1-minchan@kernel.org> In-Reply-To: <20210907212347.1977686-1-minchan@kernel.org> From: Linus Torvalds Date: Mon, 20 Sep 2021 16:29:52 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] mm: fs: invalidate bh_lrus for only cold path To: Minchan Kim Cc: Andrew Morton , Laura Abbott , Oliver Sang , David Hildenbrand , John Dias , Matthew Wilcox , Michal Hocko , Suren Baghdasaryan , Vlastimil Babka , LKML , linux-mm , lkp@lists.01.org, kernel test robot , "Huang, Ying" , Feng Tang , zhengjun.xing@intel.com, Chris Goldsworthy Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=C7gc4AzP; spf=pass (imf26.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.46 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Stat-Signature: 84d7osx7yz9dcqcybm9eh5yfqqfp1wob X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2401C20019C9 X-HE-Tag: 1632180613-645622 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 7, 2021 at 2:24 PM Minchan Kim wrote: > > kernel test robot reported the regression of fio.write_iops[1] > with [2]. > > Since lru_add_drain is called frequently, invalidate bh_lrus > there could increase bh_lrus cache miss ratio, which needs > more IO in the end. > > This patch moves the bh_lrus invalidation from the hot path( > e.g., zap_page_range, pagevec_release) to cold path(i.e., > lru_add_drain_all, lru_cache_disable). Was this confirmed to fix the regression? I only see the "tested with 5.14" that the regression was still there https://lore.kernel.org/lkml/034fc860-d0d0-0c61-09d2-3c41c4f020c6@intel.com/ I don't see a confirmation that this patch fixed it. It looks likely, but if you have the confirmation somewhere, it would help to link that too. Or did I miss it? Linus