From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73FA9C2BA12 for ; Sat, 16 Sep 2023 19:32:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8EDED6B043D; Sat, 16 Sep 2023 15:32:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 89E516B043E; Sat, 16 Sep 2023 15:32:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 766876B043F; Sat, 16 Sep 2023 15:32:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 67CEF6B043D for ; Sat, 16 Sep 2023 15:32:05 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 700151CA018 for ; Sat, 16 Sep 2023 19:32:04 +0000 (UTC) X-FDA: 81243456168.13.BCA3454 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf20.hostedemail.com (Postfix) with ESMTP id 72C5F1C0022 for ; Sat, 16 Sep 2023 19:32:02 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=KjbZjFIB; spf=pass (imf20.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.46 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694892722; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4tSANpdPZtQ5moNLopTdGJ5bxa+NmMhHjATNkQUyBj8=; b=zgDtfDCN/erRixJDIA+fGYry49sV1T4Hqkc86gPLtVMGRYq1pOjlkSQ+HoQ0Ux9rpg4yYM Z2mjf2cmIzz9DE3+JqCWu2lrk7ngkvkuPkHiM6HfclPirsM2bkqbEGEQS6FKrbLvC7T9nC gYttNTXvCqWLz/T+izKNm7kCN3OeFiI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694892722; a=rsa-sha256; cv=none; b=HCU+1TYArutJfwKQnlPAvDFBjjZKWhdEpzYPEp+Ke6UEws9TQaKix7a3hf9JKd3PWZgIu+ Du0nqMdz7saObZSXL0qx4mRzDtoClm2o99XWvsbuMp1bUwbxIwkK4NNl68kt1j0lnwn89H GeRz42AFqFZTXnId1e//OH7rhDqgqiw= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=KjbZjFIB; spf=pass (imf20.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.46 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-99de884ad25so423672166b.3 for ; Sat, 16 Sep 2023 12:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1694892720; x=1695497520; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4tSANpdPZtQ5moNLopTdGJ5bxa+NmMhHjATNkQUyBj8=; b=KjbZjFIBk/EW+i+LQerUMHulQoXvamC5fjbT+JxM5DaC5QH9WyePGQkMs0qBjwhKJw IBHwzAU5GQ+6BWyknW1hElf1pw0OeXlMaSHhEXdXXBD+dlbNXOs0b6mAkymPcH+bg5MQ 2KjtnCexXuz1q1YdZlvrIehecnlBiPMulplOA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694892720; x=1695497520; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4tSANpdPZtQ5moNLopTdGJ5bxa+NmMhHjATNkQUyBj8=; b=dh2ZgnZFW+lY7Z4KFBN80dluLhQZvI4cbSVLRzlsDs53o6iieidfcERvNWXC4KT/YV +QThDFsJF2zQ6tYFihd1+5YMV1jc5W5KunMSOrPfaKk1a5t2C0DiknvVAZCFLdLj82lj BKb6g70ZyfuqHxilVrLmUmAyq9hVOQYgpURtuhiDYIy2KbmEnKYW13FEA3Z5HhxwoiZF cmJtnsq+s3c07J+DjSDz7/+VcfSnFJzHZ4rker7L4sVzJXzkm7RFYl3nzI3AW9F38hcS Qhb6mUiZw+t0gWzopci6E2z5a1NK+ba7CeiTJEd6XLqPyvwArqw1DLIwy3DeknjMlpZK INrA== X-Gm-Message-State: AOJu0YxOHGQjCHzq+yMtz91CudvrjTj+orgTVuJPEP+RUlZxIFQBb3Oa 7adGoFrmktjJv9JYnTKflTQK5U35lUY9YhGDJu5nKG0W X-Google-Smtp-Source: AGHT+IEJLOqjqi2SnPkLl321UL6MfGNNxmdyu7zpTQrakwDDEoke2oxpnsIB2ruU8osbnbsZfE4fBg== X-Received: by 2002:a17:906:cc0d:b0:9a2:eb6e:2cf3 with SMTP id ml13-20020a170906cc0d00b009a2eb6e2cf3mr4491997ejb.0.1694892720609; Sat, 16 Sep 2023 12:32:00 -0700 (PDT) Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com. [209.85.208.48]) by smtp.gmail.com with ESMTPSA id oz13-20020a170906cd0d00b0098963eb0c3dsm4041350ejb.26.2023.09.16.12.31.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 Sep 2023 12:31:59 -0700 (PDT) Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-530c9980556so695365a12.2 for ; Sat, 16 Sep 2023 12:31:59 -0700 (PDT) X-Received: by 2002:a05:6402:229a:b0:530:a19b:175 with SMTP id cw26-20020a056402229a00b00530a19b0175mr3639630edb.2.1694892719344; Sat, 16 Sep 2023 12:31:59 -0700 (PDT) MIME-Version: 1.0 References: <1694366957@msgid.manchmal.in-ulm.de> In-Reply-To: From: Linus Torvalds Date: Sat, 16 Sep 2023 12:31:42 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Possible 6.5 regression: Huge values for "commited memory" To: Bagas Sanjaya , Michael Labiuk , Christoph Biedl Cc: Linux PARISC , Linux Memory Management List , Linux Kernel Mailing List , Linux Regressions , Andrew Morton , "Liam R. Howlett" , "Matthew Wilcox (Oracle)" Content-Type: multipart/mixed; boundary="000000000000783fdf06057ef6ee" X-Rspamd-Queue-Id: 72C5F1C0022 X-Rspam-User: X-Stat-Signature: c1tdpgfkpt4ydhtqq6i7bfrn1mx4irfe X-Rspamd-Server: rspam03 X-HE-Tag: 1694892722-67995 X-HE-Meta: U2FsdGVkX18Ebn88FAi/zjxRmoWSwK/kcPAv1XHP3ndstghNM6oypEVFMChDNC6eJnKk74ZbvmXJmNDL5EohGCai+mxhf7t1Raq+ScywGaB3V/0+Pm398uJG195mUcfwD2VfxsTuKS+UkVEN8i1JkBPBIbnGYK+/0DzKkBpfvbhRMktwBoojlreA4dllQ4rtxvDmcuAKEIMafajPi51C89S4gKH0o0q1Sgi3/kA6twQl0ND/NH0zD5nfLjpBwq4lMT0NJVDQd7qjxSawjIm5+9IY4faKqwY+A0bR1SgTer/1kv8XyfbaPuXaup+Qivb76SbhGinY1u5KfUXgwzG2Oj1L6fiEF3xdrBLFlCMN0koI3BgGUwsyhY6R3jLTjwk0VngwdYuA1I43K6ok1FmWUrPcqAcvZrZaIbhTL4U76F6Bemp59KcMgdtPrcEBA8e+/5TVXooCYQORTQdg6bsDrvCvTwyfYTmTeHeLDGVioBqtbjI9uJ+M9q0ceTxcB1CcIKV9Wy8EWSIrXCksAfmCoSUQ/aSuLpnFlUzpNs2ZQMbH4X0hLtL3xOAXcMc9hk1MjfQlbztf1U4HYDLuPY/KXXhwZBvp/6GX65mZq25rz+P3pnrQyzhnCVmmrwgz9/uYwGZeYujbK95JAL9AxWaGV8C+HRDUZ4x7oCEvHBDpJw/DA1Lrf5hd/mnrxQX7HA1Q4HPRlNj6zAOYyw4WhP8lpjJaL31DRvt18kdBpoq3QEZPpVlhfNLwN5DYWuXVQ9zMzNRQpx4ufkCokyHjYe8HcWxHKNnE9JyChxosLpBw3p7EsnLe7CaPJmTmEcbPxLc5bwiZssRFq39Ojzl79QWYqrJo+Vz5PrYSd7yybcJ2+ykgu2lsjMprsuGxyAn5evYh/kKAPeorNWfsNO1sAVz6gG71tAJaZM8E/WfW9jCQHBAhiW3+pNjEx/VVOvYom0ePUEPZ3fukmDAp4caS74U 8wp3deOz nRDU5zPEcQZueD1p3tiCm6vxbrO+VGgl5giFXiAByNBEiGdyN/doO95Bh41nFvm6km59v+1Ci9VLaC05oQMxKTrFRCW5XyCYrCVPC1RR12RQ+0jczWS1f08xghwRM2JOLZ7FBBcEx1K9e2O/FaofGyTPOSYvJzWJkDlfCETtTN3e2gwm6imr2Jvf4URqt9iZeSNKfNQ3k3R4lvIhzyyIzGnbNr7s1M4ccwimrRKzNSVqgdpiDJb4rlo7Ff2X5m+Fshv/IUu+nHYii+nxf3RmBYhzSY6er1D8xY2nK+xf/MsBBrYSbMpi3rcA+NI6kjClUnUTFD6RHv7uG0cCL0AeuOhjSRdNqvkIIi26T3gqx71YurvFO9QC0zzUzsynvcdmkGq6DDHtfh1uuvX19xiGD8KeVtMFmDPTSpD+r0PW6zxl3fB+qizLKm8NBrHmgPGxPEnbW0gGPbf1OalJqLX8+69M9ljyA5qnuNWiFsSMIFdVBsoIziKwLi2/yO/6JdcMKceOesqxqHpXTH3YPZW15acW4INEjYW/lMhD3vSfm24uLdHySB3Xab52VEP3pxLEhR61O8X2CQn0M3MnoQMtyJwMil49gPeLZfvkDpF2EcX9d6q0hOTpxRUC8YYmIwAqNRB3lKagfP+IMLkIPuFvTufLWUt99T6Px+PgZAe68+hInP3n9RPeq3rbRXa41LG14jUb7gc/6TBd2cPp918wXfelCdNwZLj0yDwhYAjuhMqmbwkUH5H57ZitMEUA3xXoH875w+htU0o2btCuKx5Nt8Z3eHAW0M7aa9RlrnVSBeOVUHquoveyntZBum/7F3Tl+EoBRetYsTIwMvCJInjpB6fyAa6smi7KB3jkBmUumZafJ8Z74eSSDKbcwT+CtHYkCEFDhPtPaiTAGPFE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --000000000000783fdf06057ef6ee Content-Type: text/plain; charset="UTF-8" On Sat, 16 Sept 2023 at 04:43, Bagas Sanjaya wrote: > > Thanks for the regression report. Michael had already bisected it [1], so > telling regzbot: > > #regzbot ^introduced: 408579cd627a15 > #regzbot title: huge committed memory due to returning 0 on do_vmi_align_mmunmap() success > > [1]: https://lore.kernel.org/linux-parisc/30f16b4f-a2fa-fc42-fe6e-abad01c3f794@virtuozzo.com/ Funky. That commit isn't actually supposed to change anything, and the only locking change was because it incorrectly ended up doing the unlock a bit too early (before it did a validate_mm() - fixed in commit b5641a5d8b8b ("mm: don't do validate_mm() unnecessarily and without mmap locking"). HOWEVER. Now that I look at it again, I note this change in move_vma(). - if (do_vmi_munmap(&vmi, mm, old_addr, old_len, uf_unmap, false) < 0) { + if (!do_vmi_munmap(&vmi, mm, old_addr, old_len, uf_unmap, false)) { and I think that is wrong. The return value that changed was the old "return 1 if successful _and_ lock downgraded". Now it does "lock is always released on success if requested". So the special "1" return went away, but the failure case didn't change. So that change to "move_vma()" seems to be bogus. It used to do "if failed". Now it does "if success". Does the attached patch fix the problem? Liam - or am I just crazy? That return value check change really looks bogus to me, but it looks *so* bogus that it makes me think I'm missing something. Linus --000000000000783fdf06057ef6ee Content-Type: text/x-patch; charset="US-ASCII"; name="patch.diff" Content-Disposition: attachment; filename="patch.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lmmf85c00 IG1tL21yZW1hcC5jIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRl bGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbW0vbXJlbWFwLmMgYi9tbS9tcmVtYXAuYwppbmRleCAw NTY0NzhjMTA2ZWUuLjM4MmU4MWMzM2ZjNCAxMDA2NDQKLS0tIGEvbW0vbXJlbWFwLmMKKysrIGIv bW0vbXJlbWFwLmMKQEAgLTcxNSw3ICs3MTUsNyBAQCBzdGF0aWMgdW5zaWduZWQgbG9uZyBtb3Zl X3ZtYShzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSwKIAl9CiAKIAl2bWFfaXRlcl9pbml0KCZ2 bWksIG1tLCBvbGRfYWRkcik7Ci0JaWYgKCFkb192bWlfbXVubWFwKCZ2bWksIG1tLCBvbGRfYWRk ciwgb2xkX2xlbiwgdWZfdW5tYXAsIGZhbHNlKSkgeworCWlmIChkb192bWlfbXVubWFwKCZ2bWks IG1tLCBvbGRfYWRkciwgb2xkX2xlbiwgdWZfdW5tYXAsIGZhbHNlKSA8IDApIHsKIAkJLyogT09N OiB1bmFibGUgdG8gc3BsaXQgdm1hLCBqdXN0IGdldCBhY2NvdW50cyByaWdodCAqLwogCQlpZiAo dm1fZmxhZ3MgJiBWTV9BQ0NPVU5UICYmICEoZmxhZ3MgJiBNUkVNQVBfRE9OVFVOTUFQKSkKIAkJ CXZtX2FjY3RfbWVtb3J5KG9sZF9sZW4gPj4gUEFHRV9TSElGVCk7Cg== --000000000000783fdf06057ef6ee--