From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9726BCF9C72 for ; Mon, 23 Sep 2024 16:14:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D9236B007B; Mon, 23 Sep 2024 12:14:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 288006B0088; Mon, 23 Sep 2024 12:14:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 129186B0089; Mon, 23 Sep 2024 12:14:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E56FD6B007B for ; Mon, 23 Sep 2024 12:14:06 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 82DDA141467 for ; Mon, 23 Sep 2024 16:14:06 +0000 (UTC) X-FDA: 82596499692.23.09BF8E2 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf17.hostedemail.com (Postfix) with ESMTP id 3C3884000D for ; Mon, 23 Sep 2024 16:14:03 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=BGzDD9HK; spf=pass (imf17.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.41 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727107984; a=rsa-sha256; cv=none; b=6UmivmR1AAm84Od339XFb184cHBtqkLfFL6XWPi5op8qK4Wp3uJfSEz7UyTzIGSitrz2h3 tjGkImpg5bIV8oYIMTGjDtEgPxldBnRv2EKeBmCaLyBnGitQqOEiOghxrIB6AMd5c5tDqr FlWbNVt/gZwKEWzKRoGTcPBOt9uHz8g= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=BGzDD9HK; spf=pass (imf17.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.41 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727107984; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KhxyB4gnJFPivYVDIfICHwK2k4/8oKwPbaN8LTyNmkY=; b=wslFryykRzZ9Ilr0HOYwyi/+BRujpPnIcuXoyRS5ijjgD3uoEqGouqaTTvqjt4ee80zp7s ntMNv2uZBPHzycR+901ASIBlyybUvgSPj3XzzqU6Q3I8bDCU6n9ht+PIyJLFIp6+6frdxG 0IdiyXZ/CInLN1hG6iha0p76tkkqp5Y= Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a8d24f98215so613624266b.1 for ; Mon, 23 Sep 2024 09:14:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1727108042; x=1727712842; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KhxyB4gnJFPivYVDIfICHwK2k4/8oKwPbaN8LTyNmkY=; b=BGzDD9HKM3D2ZHxqGtUFwhUJWZi+t5Mgzf1vG75r6UU9vvMzh2Ji2Z0dfu+tr3H0VD REz82gyyfwtlW3lNJkEZjyudDlUfO9ww2EWRTohVNyWXSHhy2iEcrRiys+A05qPfKVd9 aDnkLASshfR2uj2u+0YbLAnBKtfzFgl4uHLak= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727108042; x=1727712842; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KhxyB4gnJFPivYVDIfICHwK2k4/8oKwPbaN8LTyNmkY=; b=iVFu3nmnOeOtFb6rw197K0wdE42D795b8wTsj73+a9sEuVQK12IcZbcOfrBGvEgIRK KwshFrabvp+Ju2bqSDddlT5hRBbjPFxcNtSeKPKLmym4PKDA1BvVlf+0DBW7NaYCe1xF nUJiTBwUDXtw7NgZJ15gEN4HZVt/mIduJlOZcBPg6sVb6/mtRdEsjgXX07rn5wZVpNuI QOwi5E95+/rLU3Y5EQ/nDB5EpbZVZcjEgApSKK/37oQOFC6RlH8M80dKtu4ZhlUr8NWH xJSd/eGTXetUks6Od5pqPeH9VMlpLOdY7sk9oHUoG/glDjM7FEWcVywXeWkL9BOzuO8A 2XSw== X-Forwarded-Encrypted: i=1; AJvYcCVF81Re6erKEuWBzPfB0uHhxPMcbLsE2rmx2hAN1zbZJnlHwghIV/8IRDmRSx7c/i4EM0ty8wJz9A==@kvack.org X-Gm-Message-State: AOJu0Yyd33o7Y2IkKnWTWuweiyZJNb8ip2nQuk3WqsQfGUGcwlHqex6A 5W4yyXtr9/2Lv42KbneVCGowv4IJo4KzHjGVWIBa7YQG7hBjcBnsGupGHAYQcJX8CEveosT5dCS IT9U= X-Google-Smtp-Source: AGHT+IGbJki17Ck89F15PPShB+5SNjmQUqWI7ASRxdGw8z40cy8/q2BjBQamddc5ITSK+VnDkxwd8g== X-Received: by 2002:a17:907:3e03:b0:a90:df6f:f08a with SMTP id a640c23a62f3a-a90df6ff32dmr1340814466b.6.1727108042421; Mon, 23 Sep 2024 09:14:02 -0700 (PDT) Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com. [209.85.218.43]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9061331bc8sm1242194966b.221.2024.09.23.09.14.01 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Sep 2024 09:14:01 -0700 (PDT) Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a8d43657255so726951366b.0 for ; Mon, 23 Sep 2024 09:14:01 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWzRrVFOTf2VAaR1CLbj6AD/fKYKmr/c6mWtnMunpwlZ3V5kjr5Ip6+zy6MqVXoffaNOuIfglrmAA==@kvack.org X-Received: by 2002:a17:907:36c8:b0:a8a:91f4:fd30 with SMTP id a640c23a62f3a-a90d51098dcmr1410438466b.56.1727108040711; Mon, 23 Sep 2024 09:14:00 -0700 (PDT) MIME-Version: 1.0 References: <20240920023317.f20c9ecbb2a2f4bf382d831c@linux-foundation.org> In-Reply-To: From: Linus Torvalds Date: Mon, 23 Sep 2024 09:13:44 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] MM updates for 6.12-rc1 To: Geert Uytterhoeven Cc: Andrew Morton , linux-mm@kvack.org, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org, Huang Ying , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: foicybcu545jsoon67ayuxcx16fz18n5 X-Rspamd-Queue-Id: 3C3884000D X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1727108043-735455 X-HE-Meta: U2FsdGVkX1/gEegDB0zEQFSRYt5pp5zDlxKXIyT2ljgoI21Ud6hgLVdqE2g47KvQmYAHYzpwib12OCfEgdYvwH9yaocLXSK8Gt2M4xAHNNH1/3Jb9x66RVD8RmIsjidB1Bwh+phKD34fVg/U9sAZZAFC3iav4eGUaaPLMbCiHTE8wamyRV1IiCcr75JX6r37RaeuboLMS+cLI43eAfdLUVuIJAkD2nNORFVYdQxzsZH1vDdZLFz7NII/1M/TOFFj6dMUg0xF+4OKaKsGDVCitalLaCf8TbRCSXRA1Cm735QLbmIh3zwNCNTSHvt0NNnyXiNhTN1msBe73kzKFw/WOGU0uBEM6Rp/L64lLTXp+8g3TQJkzgHiVwQgts9aH5M4YiNVpTtLIV9mSlimrvND0e8/b9eR6tjWCHCy6mpg/3ZPrrjCU+ziCctD8D/uR6K4NonbE7a/3HQrPuDBf5XekhWV3m+jg69VkiN4Zfxle1IVv1cyaP2nU8zLEV4Kzb2xS424h6BbYFaTIRzxt3/xX6WVCpMZxr/QSiONP2o0K/Q/69K3G06ow5urdWVMkj2PVqx2EWZZyqVa+xu4zUuWP5ci8JdMUOl1AW/iTtNX56l47tTktwvEuylRSfjnBg+vwxF4RrZkdc6F2MOACS1tywl13i4P7gOTHr9eKiDkAcOLPYScU0MbhEJU2z8DQnbZTq2s/6jEBn0dyEMUWA7nsgl6m1NFWVeRI6fPeB7AhABnsFxb6/BnyELvt0exqL4++CWqVfch3c2NSFP+NfBsMctLv6P4gcFUCFp+UIhMa9u3kkOWCkyVeGTVG8LTGwCMMQ9gZdKfR2WGPJd/dgzKfHdoiaApesnjEr25N5WQlboRHozI6HiQxsTMjesktWPaLwGhCrmco9guSZSs7Piois1TEW0ICDoSe9sIWEZOxMT8ov9c1/qDCjYwaWVePRZL/j93r3yE71qBsyyYcXR 4MH0OoRG xLgc+SawCVXPpLcubPOYWj6veKwcDWDaETVb0BjhRSemrtu4EIluxLw4VRjHnR6cycxYO6uT9qdJoJ/cAfxzx9pns7vnB0jzd7hhvmQyKJthCkraLaRuh3DhlPPT0zKdK53KjCD2DZbbe/O1v+PSRcit3iiahjE8q+Ij3X0X4MxIz8Ky3/a6+O7a1iYNZM2ogBfs118HMb8arLcEheaKIDxUW6bENLSnwEABoxuu0bEK7bP/FwOvG4v39tKbGq1EL5LTthWWu13VS60NBFAbzqqoQKnFZXRntHoq+CPCd1o/gfR+9JJju+yl/aPEeVyXs8dU29n9fATvdYX31XmsZbh1XLU5JFun8DvcLJAxxde+XWsXCjfHC/4f3I1YRisU6BxorGFDxdf3PbYqNFypSgQh8b52cfdV0+3+Eduw5eA/aTWtUAewB9ISwzKElxQFTbzck4LV7xx5B/WX8ZhG+3oVC/mxnXeYPlG2uRDYGRgGuZPhw2UXF/sXj76o4JIXgKCRTZQajgYV7IOrdI4ZZ40MyOjQaevkalNKbfw1uCVX7Q6mnV+e0z8IVsf0QHyEns3GA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 23 Sept 2024 at 01:09, Geert Uytterhoeven wrote: > > BTW2, the following may not work with the default PHYSMEM_END due > to integer overflow, on both 32-bit and 64-bit: > > mm/sparse.c: unsigned long max_sparsemem_pfn = (PHYSMEM_END + 1) >> > PAGE_SHIFT; Good point. I've committed a truly disgusting hack, which makes the default PHYSMEM_END in the absence of a MAX_PHYSMEM_BITS value be (a) always a 64-bit type (ie unsigned long long) (b) be the maximum value to fit in 'phys_addr_t' (c) _but_ with the high bit always clear in 64 bits so it's basically either 0xffff_ffff or 0x7fff_ffff_ffff_ffff. The disgusting macro I came up for this for this is # define PHYSMEM_END (((phys_addr_t)-1)&~(1ULL<<63)) and no, I'm not proud of it. This is all horrendous. We need to fix it properly, with the proper fix probably being to always have a valid value for MAX_PHYSMEM_BITS (and no, 64 is not a valid value due to the overflow issue) but the quick hack hopefully gets the build going. Of course, I don't have the m68k cross-environment set up, thus the "hopefully". Let's see if this works. Linus