From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2D90C3DA4A for ; Sat, 27 Jul 2024 19:30:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E80E6B007B; Sat, 27 Jul 2024 15:30:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 298416B0082; Sat, 27 Jul 2024 15:30:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 161426B0085; Sat, 27 Jul 2024 15:30:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EB0476B007B for ; Sat, 27 Jul 2024 15:30:10 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5F86F1601C7 for ; Sat, 27 Jul 2024 19:30:10 +0000 (UTC) X-FDA: 82386523380.23.BE2296E Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf06.hostedemail.com (Postfix) with ESMTP id 038F418000F for ; Sat, 27 Jul 2024 19:30:07 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=QY28VxWE; spf=pass (imf06.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.44 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722108582; a=rsa-sha256; cv=none; b=3VsUQiffDil20iFxMlHydI8VrZFMLXOzOpZI6l4ewAZn9Qa0K6w5kRk3HImjFjd0PqXKk4 2qFQNos5brEQ+hL4h+q5ALc1nT53PbPN6Uj/NnMbE1PoeMtJduxUqET5MD6XlXGULN3F3n PRND4Hke76x9eQO3tiHONRfWSGHv7oE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=QY28VxWE; spf=pass (imf06.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.44 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722108582; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/KGqVB/57I9KELw43F3w/OzLTiYGnfik0UvJkjuipds=; b=fDkk16ExsO+vuEotkd8uAFYotpgFu6Q3xJe376kXPBHqWWwtQwWRIvS208H93EfU8Y66Gx Ucn6LWKN+rdzll8tUy3Hi+B7G0/G9lOEF0LF+K1tJjg4758g1lc4sWgrDLRRsdz483HwoD pJN9NeXuI98wule0qFlgE7o+a7qn2eI= Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a7a83a968ddso350950466b.0 for ; Sat, 27 Jul 2024 12:30:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1722108606; x=1722713406; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/KGqVB/57I9KELw43F3w/OzLTiYGnfik0UvJkjuipds=; b=QY28VxWE5e0tfMlsnmpiaF1TJbiW1koIK5HiprAZFhWNvjqK9AKZpLXInM/QeBPztu sIO3XRw05p3unnC7Kua2YcXNP1v7MoLD0RWG+jT0kvE8jEcNtcIEoi8lhNJV2cV+u+iv d7M9Gjo8s+YRPFeVQuugRVyHTAG96QWFCK+14= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722108606; x=1722713406; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/KGqVB/57I9KELw43F3w/OzLTiYGnfik0UvJkjuipds=; b=ciuikXAMGwLpMIcT9P9V5DCa/Rq4YLXijoKsUinjCrwX85uJI31yvH63WUfHMrdMOR 5jh+axn4AGmxR4mxVDrNyQH2rqQ74I3Orczkl9Mm14ACELWf52TmzqP4pS1rR1J4dgQE qts54fIMUtOuE4w/u3tV2zwuOqTh8dBIY6hD3qXcr9KPcaPdwGMzRsoF5iCxsEuY7ZTP FKn02cG9WrULWy2ivZJtpnWEIm8Suz4zZtAIIu2aP6GJitZ+YUNy8qHLaygAYIGeKS2o keiwTpfmDy6/Lnyo9Tm3zO6fn40OfjY3liY0ntnplDbEF0UEnB+RZkCMJsRbTQj2WZH9 CPuw== X-Forwarded-Encrypted: i=1; AJvYcCUnKSLz1B+Ry/Cy8PprWaFelYfWaV5EeOjQ/oIcOaAiLaypY3l0wesv3Dl/hJlQIIFKzhoafp76Yp7kay59w2SE9ZI= X-Gm-Message-State: AOJu0YxnDpHCZSaVuXaJk9bNqh7528ONyzTbDACrX97YrNkqm54r2HWP h2gGQDoCCZuFEkDOScj5VPhf5GzvFLAY7+zC6mO1AjbhJieaZVz14h5ggLUyEGTA4OunrUuNYlT TDgthfw== X-Google-Smtp-Source: AGHT+IHASqb/T0SC1wx3/wf0r1fjWMYrepQJrd0+HH1ePA3YZJdVUWPu1VaT20eGsIbgHuxlQyZ5lg== X-Received: by 2002:a17:906:d260:b0:a7a:aa35:408c with SMTP id a640c23a62f3a-a7d3ff55b80mr240529966b.8.1722108606010; Sat, 27 Jul 2024 12:30:06 -0700 (PDT) Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com. [209.85.218.41]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7acab4de22sm308552366b.49.2024.07.27.12.30.05 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 27 Jul 2024 12:30:05 -0700 (PDT) Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a7a83a968ddso350949166b.0 for ; Sat, 27 Jul 2024 12:30:05 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVgDPmBbEXcS1+NEfe3G/cwOtTjyuxG4jTPJ8bG6juQztOdMjrbfKiYgKzTDRBhaXpeNI5MApPSHIBikfZfZ2qOOxU= X-Received: by 2002:a05:6402:2546:b0:5a7:464a:abd with SMTP id 4fb4d7f45d1cf-5b021d2243bmr1942089a12.30.1722108132482; Sat, 27 Jul 2024 12:22:12 -0700 (PDT) MIME-Version: 1.0 References: <23bdb6fc8d884ceebeb6e8b8653b8cfe@AcuMS.aculab.com> <902a9bf3-9404-44e8-9063-03da3168146a@lucifer.local> <137646a7-7017-490d-be78-5bd5627609c3@lucifer.local> <36aa2cad-1db1-4abf-8dd2-fb20484aabc3@lucifer.local> <40369e153bd447e5b597c31e7bc9a2b1@AcuMS.aculab.com> In-Reply-To: From: Linus Torvalds Date: Sat, 27 Jul 2024 12:21:55 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/7] minmax: reduce compilation time To: Lorenzo Stoakes Cc: David Laight , Jens Axboe , "linux-kernel@vger.kernel.org" , "Matthew Wilcox (Oracle)" , Christoph Hellwig , Andrew Morton , Andy Shevchenko , Dan Carpenter , Arnd Bergmann , "Jason@zx2c4.com" , "pedro.falcato@gmail.com" , Mateusz Guzik , "linux-mm@kvack.org" Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: c6qn38ehaqdzxu63fr7ykdtry5f7s3ma X-Rspamd-Queue-Id: 038F418000F X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1722108607-295963 X-HE-Meta: U2FsdGVkX18PN9uOX18DO/lWWztVT/HXo8FPy/sLJVC4jCwlx24pEUqMXjhixBICKsDeMa18lTttyge7R6e24MV07y3xDvL5Qp/rp/gfPovHtm2zQ+ImqtRvUtT/xoqgnHX4Q5/Cv0wDu3YLb08Xtv010oz79zP7Nz3r+vLN/b0O6KBXLgQIPoykU40h+9RhJ/OHj8DjCCiFWi1djmMfWxfBNewQmIURkpCd5ZGoMu+8ljDnR4KaxzO0z1asbm2ysXajDGl/xPXyAD3E0OurQhU0OjD7cEvUC523bfnRde+gn/CAyZRAw9przN4scip8Ww4ilg/KmeUgJWXbxrcIQFS1W5us2HfJKWLoSmv6kNBmGlY1rdhZU/NjqTVB4b6422MsJnj+h+aR+Nxk3cpF52YrNTgZCWxuNtxMxCSFqmXxGTU2dUR2ZIbNVPdFoMmhgppUQEWpIfi2MrQzURPd29X2rOmviPCyKgpXYsxu8oh6SIdfHfAxFPs4cb27Medvq4OEKzUgd8c06pXEpEkHWwoTaIWBwp/EFUHjyBQYjDIUsXPxzqLX9DhAfdHHiAkSSC/a5XHUnpujNgB+U+wOWb0wP4/AG6RDmIe32SJDbptJ4nzQbCQIyjqCDHR/q9oSYQX9Ty2a8dWQWqt1FCRQeR96BtuEkYKfs4gNAXPtmNQ0mFwqziD6GCQrKUBEMbH1cT1DMajgLXvF9lZcjQikNIDwNjrFOgmTXax5R89pZkKbOAum/jNGreEDqv/qfeYvfSRebuyig84KwXOxaGCC1gD8uGJfpYExWC7y48An9lnwHKhGc3tIrGpVKcCFlPcAGMKi/xChZkjNSJ9n3mcbzT7D/JlEbmxLMxr3i1J4xQ13Yswc5YcM5AoVGvcIcuiGRXGgBLe1cZeI5G/Ii3KwP10mT00w9cQQp2atROWJHQOOy/dMNWPDfcYrDpyrdVVGa6VgS37eTqsDGxIeHDv mfFErgz5 zYwbqKmwrrgaiwq+PskuKe29HswLo4SAyX5jt0zcUIWwegEqjC0woiaf1RnYvGC4faMqtf7JKJUb+drVIAXPwty9il35uNlGOOrBvWMIf6uAPLiDH90xKfxVE6kDPTkeWzWvuva8/wnx5T9MhT07ebQvCWzOUm8wvVWxlgpM6f3ZnO4WrXURugKDovpvXTBMIlqp4cP7YRqrHFQ9CJ8rqter7EXuEMicXbHrspTnzaxXuS+P6DGvrCFE5W16Znv7Rt9Ye3glF75XbPuoEzwOo5sAptIv1zNGdidnPLFJUY/EpeQgWolYumTWmZs+Fi+/G4bUxizW27X6uMv2bSn/fNm781N3LoUTPob5R6E3o911+VVs0zPHkVm3ujiJGkkWylrPTftJIBbwewI+VATpnsEu4i9Olq6aOwH9YMpUZhN0YEw94Pda/PX2r3xzE+HHzKPBU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 27 Jul 2024 at 12:01, Lorenzo Stoakes wrote: > > > > -#define MVPP2_SKB_HEADROOM min(max(XDP_PACKET_HEADROOM, NET_SKB_PAD), 224) > > > +#define MVPP2_SKB_HEADROOM > > > MIN_T(int,MAX_T(int,XDP_PACKET_HEADROOM, NET_SKB_PAD), 224) > > Yeah sorry just saw you had already addresed this Linus... I just went with a > clamp()_t in my patch. I think your patch is better. I threw away my disgusting MIN_T() thing here. It made more sense in pageblock-flags.h where it replaced "min_t()". Linus