From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A3FDC6FD1F for ; Tue, 14 Mar 2023 19:08:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF7908E0003; Tue, 14 Mar 2023 15:08:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA5EC8E0001; Tue, 14 Mar 2023 15:08:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6CB38E0003; Tue, 14 Mar 2023 15:08:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B5F068E0001 for ; Tue, 14 Mar 2023 15:08:00 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7869D1A0D78 for ; Tue, 14 Mar 2023 19:08:00 +0000 (UTC) X-FDA: 80568438720.21.897E751 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf20.hostedemail.com (Postfix) with ESMTP id 6E81E1C0018 for ; Tue, 14 Mar 2023 19:07:57 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=a6WyRdFf; dmarc=none; spf=pass (imf20.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.53 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678820877; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5XXQN4LaizH2j4eXVSdO1xOJU1STk3wgvGGHOknlOD8=; b=KEKC5YwdvCxSHQ2O9Pn/cyRQ7GiZ2JzTEuAQR+kDkaT6sNMVojcNb3wHMog0KiEeR7OePX RBzisnri7sV56a2155Rx38uqYGYC7luPrd1HKpvZwm+4QvOAv/J0UFzgLTzQsyF+wvPau+ HeN/TlcMYuKO14mKiOp+btoD/L8knhw= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=a6WyRdFf; dmarc=none; spf=pass (imf20.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.53 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678820877; a=rsa-sha256; cv=none; b=KY9SoGhEQjUY2ZWnkWTcDmB2QNxMz1rr6tHXx5dnlSnttwolovEpdaQZrpoXX6wQdptSL6 Cj8/CpFCDPsvMoUeUEsaKw4Q+GHkDeoOtckvDliiBSHJHpHOYT0VQtslX7UndgHr758AAH bZftjzstLsvytIY7D/KVhR3ddt1m2Ao= Received: by mail-ed1-f53.google.com with SMTP id cy23so66120227edb.12 for ; Tue, 14 Mar 2023 12:07:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1678820875; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5XXQN4LaizH2j4eXVSdO1xOJU1STk3wgvGGHOknlOD8=; b=a6WyRdFfi0DT7KYrcVh8KTBoERDVjfv/XJ6l0uILwYMBAPnA/UBOlqSBYK5E8mAA5E gyMsC6wKiXOOl13zzf6+ip5YEB6dQ1oXi+QLJ8Z5sLuxArOr0GPojIVKAlN0eNCjCQTJ oTKawdKO94eDLMqkex9c7ds01Gql5IOB48HKs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678820875; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5XXQN4LaizH2j4eXVSdO1xOJU1STk3wgvGGHOknlOD8=; b=NpEZLtlMk5v3lf+/RLCrouKxNiJOCOCEe0RJDFLJaWhsRV18FnCpn/oNHLOkPP13/T kzquYu/JGjG/SwYp+WWTBRdLTWD8yDfrzT9JL8YpnCBxa3KI4ZOaOdLU1ls07i9FVsoy kPUQHwq4TcSISpQP8DAdYbjZO8291lQey5uH/XYYom/5NuCXExVp/U1wz2GBkKaeIij9 Vwzk+EnEPiOhfrg/6bz02iOBh1P/RULU4yFAoZW1QdzKciiv6XAuw/FyxaDQRIv+BIup fx9Vw0p4VE3HxVC2eZFAuydJoD1vQXj7Z2q65Ux9JgxOXK/Fgpx3+5V27avT6zyhtb9N NN1A== X-Gm-Message-State: AO0yUKWdIH+jm0PNkkw2Cv65/IwLTluGrEf2vQHzVe7xm1b5YSzQmZwT Bqq9LA/biS0tYn7HP7UD4uep6VcdXsyHWHc6f0ZYkQ== X-Google-Smtp-Source: AK7set/deT9RTwdQ0fqMyVJj6EYrnu0pok7yDRrOUapi6BdTI5My4tGaXYIVvgFMDBWdxQtOU/pfGw== X-Received: by 2002:a05:6402:b15:b0:4fc:eb46:6b69 with SMTP id bm21-20020a0564020b1500b004fceb466b69mr155374edb.23.1678820875168; Tue, 14 Mar 2023 12:07:55 -0700 (PDT) Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com. [209.85.208.44]) by smtp.gmail.com with ESMTPSA id n10-20020a50c20a000000b004fb542dd8cdsm1454279edf.29.2023.03.14.12.07.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Mar 2023 12:07:54 -0700 (PDT) Received: by mail-ed1-f44.google.com with SMTP id y4so36790614edo.2 for ; Tue, 14 Mar 2023 12:07:54 -0700 (PDT) X-Received: by 2002:a50:d506:0:b0:4fb:482b:f93d with SMTP id u6-20020a50d506000000b004fb482bf93dmr106272edi.2.1678820874229; Tue, 14 Mar 2023 12:07:54 -0700 (PDT) MIME-Version: 1.0 References: <20230308165251.2078898-1-dhowells@redhat.com> <20230308165251.2078898-4-dhowells@redhat.com> <3761465.1678818404@warthog.procyon.org.uk> In-Reply-To: <3761465.1678818404@warthog.procyon.org.uk> From: Linus Torvalds Date: Tue, 14 Mar 2023 12:07:36 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v17 03/14] shmem: Implement splice-read To: David Howells Cc: Matthew Wilcox , Jens Axboe , Al Viro , Christoph Hellwig , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Daniel Golle , Guenter Roeck , Christoph Hellwig , John Hubbard , Hugh Dickins Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 6E81E1C0018 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: ruqymbfqdrm6trocbdoxeuqotcj96c77 X-HE-Tag: 1678820877-453493 X-HE-Meta: U2FsdGVkX19kt1fLtQxEJFszsrBIjOPjQpf07XO2X1MKv5iyYI0TD/mKVdBDCgx+oy1osCRwZpNOh0HOthH0XMFWd4+3EzRG2j/ezIZxOF6tjnx1ZFhnbml1juHu8vaz3LnxCr3qtV62/qFljtaqES6nhw5to/94g+idwjL5uyoYehZ6CRCslXhCNC8YOvSHGE/hR9VpSEOLQprGJGyFiK5fv6HPkVdeUe5vO7kzl5nCbEPJFYEPDFdFnM01KuQvbxcZFT++jilisqDLlbPkHYreR4a4CLAs2NTEf+kmEoann132rvhHKlG0Hf23FRim4RBnlGkHsJynEOuDlQcHPLPeUEjV0BtgaevYVVPr4kmtE8QpQxQkp8b2jG3OXzSBOC9Gj3ZWvKF3wGgXXqa3mR6UO59qngpmYHFDm7CLioLv1zkIEo39E28CUyPe14D3F9XQF/kjDzH0TnB1gKk1USQO8oqQHqGOmQM3DZWryNIkJxWxL+Zik1lby5Bw9sLA9/lS+7bLQa73LDZjIXJq1JjqohKqe9VpaXcaTuk5Zbl89wHjKBicz4R/HMoasUerHVLNHtb1+UsM41WzphMTaM3Eo9bf5IfkMdGvs9Lln5pwvbSTKIJi7Q7QruWHa1+agSTqqWOzscIPMM70/lnQA1BCqvo3acJjwdhz1M4YMcy03qEU7HMp0qpZwmqlVFbDnAHcFrOUp3T10JW91mmlS7DLIIy9fWLPtuc4KLraMpmIudXFtid8Psh8jHGf8f5wEtnzBz5G4wqbbd2UjsDDkGdfRF+OvsGtBLKYJozdkJT+fnIxfkkGk0o5O7F9nPzw1RteopZ5W62JWOJQEEQBGp55MMPcuLMGEM9yfG2E+Pu5jMKdVnHcoVGnMiq35Pac4l3UFEKxBWlZkpMebi7l0TxEJpxpGqFPZ7/a5G/Jq446CjTJrtRW2tBKIM61nLSfjzp2kTZhhc3L+0h9Z7D h9i8fExs u06/G/Bv+tsz6sjtrkbRabGprBpKDFmHthcyi9HBYFj0u0LSUUtHBgMzpFmI7ORSDaDRJZO0r6u3aQ8gL4k4lksHaMHSAT3GCKVwCKWGs3DW9byy1ckwV5G+4lhqGL1JwNL5F8BSY9lTobY9etB3QSouxAO7bQKRXDm7ewYVyahdt4kreCf0lJ8Ke562qm2CV0qFrN9z703u85lDB7MK9aLYQ7FeunIhePD3pN8aSkpOh59zhb8L1QeBrz7iMA3BHnGNqw6VyM1ZXri9Nn5dIJcmq0T8K8qgFQ1+D/Cc1Qtm5bZaWclSwYqEaOrID/+vdySM3B1NeayHUjQ5dWrUrUk9DDgK1kocRfr+NQIsI/zB//cCp785/bEcoRPvszGfg8Uz30Y2kdtahxeFHE1Z8RtLpAfyquzVbsohoXavFgvp4go94Gh52HGTm368z+kbzVUP0AAg3T2A1yYxuz1/B5/JMB8qDkQzOac7r0lDDxXAKmIVxDau1vXr0CkYabKoDAwbiy59drFfcZ0re60xdp8otNoFwZFpPItAc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 14, 2023 at 11:26=E2=80=AFAM David Howells wrote: > > Are you okay if we go with my current patch for the moment? I guess. But please at least stop doing the get_page(buf->page); on the zero-page (which includes using no-op .get and .put functions in zero_pipe_buf_ops(). Maybe we can do /dev/null some day and actually have a common case for thos= e. Linus