From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7CEBC433FE for ; Sat, 15 Oct 2022 23:47:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9EF5B6B0072; Sat, 15 Oct 2022 19:47:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 99F386B0075; Sat, 15 Oct 2022 19:47:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 866FC6B0078; Sat, 15 Oct 2022 19:47:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 71E2C6B0072 for ; Sat, 15 Oct 2022 19:47:39 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3240DAAD5E for ; Sat, 15 Oct 2022 23:47:39 +0000 (UTC) X-FDA: 80024823438.16.66B13F0 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) by imf09.hostedemail.com (Postfix) with ESMTP id D667A14002B for ; Sat, 15 Oct 2022 23:47:38 +0000 (UTC) Received: by mail-oi1-f172.google.com with SMTP id w196so8691905oiw.8 for ; Sat, 15 Oct 2022 16:47:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=pW51aWKkKbcguul/KxxqOrX6YivwtnSy1U9SGxAFCa0=; b=GSrHz4Hbb5fYa/LvXohm4RndjnGkosrdyknxUH8A+XaqbvP1umB/QDbJakEJhqMyo3 MdUO+sPGpAvBUcxDu0An0kBVvURdxiOsb2GYt8a6bWd1va1WIS1q1hsycNSSlsU3UBHi 5oHwyQhFn+B/uvzOyqaDGIuY5fVXTrjSJDTWM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pW51aWKkKbcguul/KxxqOrX6YivwtnSy1U9SGxAFCa0=; b=7VfPlBaOBd78K7JoPShRjYCXYUmYbHhjqDsDmnOIDg45YoKShOFhaOwjwPCHZTy4RN 6ra9W+HohcXxPYqXb+LBYWr00AXAAlnss9BF2pVtbDuzS2rfBlJHlH99hf4qNVmB6jOy 2GsAjJipdKA8BxXZ62nNoCD3C0kYlSGB844o0S7lAG277AFKyTPwqosah6h8rtFXVaHp gmHyn+TUVcxyFUK8iosp5llQ29HlIFTTtvW2zklOVzBPibrKp08XseSrXLMMV0D/MbUl JOjmSA0+/dN1mP3iIofV6Tvix3Y+lpTGvStu+rzsJ9H3/kgGEUMPpQh3AU9EcizWUawE EGmw== X-Gm-Message-State: ACrzQf1Np6FuuJuGP6UjVLsGcnufBRwO7mcfwYBUbkqPMMXAJUneA5wI 54XZHV6DxrgAnrOv68YZmB/FyXIQ00WcYQ== X-Google-Smtp-Source: AMsMyM7pSLlAkcqqim4beSCRK96Z0wM3fO/dc9eMS/McXhQFuJOwuN2/53KpKb9eVdf2xSbjjtZIEw== X-Received: by 2002:a05:6808:140a:b0:355:230f:b7f1 with SMTP id w10-20020a056808140a00b00355230fb7f1mr3523045oiv.8.1665877657086; Sat, 15 Oct 2022 16:47:37 -0700 (PDT) Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com. [209.85.167.181]) by smtp.gmail.com with ESMTPSA id s23-20020a056870631700b00132f141ef2dsm3170067oao.56.2022.10.15.16.47.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 Oct 2022 16:47:33 -0700 (PDT) Received: by mail-oi1-f181.google.com with SMTP id l5so8696428oif.7 for ; Sat, 15 Oct 2022 16:47:33 -0700 (PDT) X-Received: by 2002:a05:6808:23c3:b0:351:4ecf:477d with SMTP id bq3-20020a05680823c300b003514ecf477dmr2077092oib.126.1665877652709; Sat, 15 Oct 2022 16:47:32 -0700 (PDT) MIME-Version: 1.0 References: <0484E294-D6D6-45CE-87F7-5AFDA5309BA1@gmail.com> In-Reply-To: <0484E294-D6D6-45CE-87F7-5AFDA5309BA1@gmail.com> From: Linus Torvalds Date: Sat, 15 Oct 2022 16:47:16 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [BUG?] X86 arch_tlbbatch_flush() seems to be lacking mm_tlb_flush_nested() integration To: Nadav Amit Cc: Jann Horn , Andy Lutomirski , Linux-MM , Mel Gorman , Rik van Riel , kernel list , Kees Cook , Ingo Molnar , Sasha Levin , Andrew Morton , Will Deacon , Peter Zijlstra Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665877658; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pW51aWKkKbcguul/KxxqOrX6YivwtnSy1U9SGxAFCa0=; b=fdYPqpiuMQK9lTcIr10uHD0klEWCDx8fVJ7Lb4CegE+r16Yehg4a5UWZ8RKvTmaMxU6g2h QJX6kYPNgW1nyrhMLYCBHghX/Cs+iey9z7N4rgzQKL+IbRq8eUaj7+BQt7TsQvIrm9C2WE qI82ZNw6AJ4Dsow5ru/aHWKg512esfk= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=GSrHz4Hb; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf09.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.172 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665877658; a=rsa-sha256; cv=none; b=069rxKQ9PBp/Oap3dPpi/dTraBxUXcF9EzSk/Thf2I36CN4eVrAsbr1dQ0ioV0oTE2MGgy PiEcdg+/deLRFVvfewEEPpngSe6qfe/EFy2Zs4bjv3HdGuvnDKk9gk0sDJvTG2dGDHoTA+ 1TsQmUumjqgUkKyjKPIgjWpimRv1570= Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=GSrHz4Hb; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf09.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.172 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D667A14002B X-Rspam-User: X-Stat-Signature: 4kd8xp5xuc3j79r5n79eoeo3s9rqsewc X-HE-Tag: 1665877658-790115 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 14, 2022 at 8:51 PM Nadav Amit wrote: > > Unless I am missing something, flush_tlb_batched_pending() is would be > called and do the flushing at this point, no? Ahh, yes. That seems to be doing the right thing, although looking a bit more at it, I think it might be improved. At least in the zap_pte_range() case, instead of doing a synchronous TLB flush if there are pending batched flushes, it migth be better if flush_tlb_batched_pending() would set the "need_flush_all" bit in the mmu_gather structure. That would possibly avoid that extra TLB flush entirely - since *normally* fzap_page_range() will cause a TLB flush anyway. Maybe it doesn't matter. Linus