From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B85FCC433EF for ; Thu, 24 Feb 2022 17:30:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 226728D0002; Thu, 24 Feb 2022 12:30:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D56E8D0001; Thu, 24 Feb 2022 12:30:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C5558D0002; Thu, 24 Feb 2022 12:30:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0099.hostedemail.com [216.40.44.99]) by kanga.kvack.org (Postfix) with ESMTP id F24F88D0001 for ; Thu, 24 Feb 2022 12:30:26 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B19519A271 for ; Thu, 24 Feb 2022 17:30:26 +0000 (UTC) X-FDA: 79178362452.29.93A3CFE Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by imf27.hostedemail.com (Postfix) with ESMTP id 2E41440009 for ; Thu, 24 Feb 2022 17:30:25 +0000 (UTC) Received: by mail-lj1-f176.google.com with SMTP id e8so3944297ljj.2 for ; Thu, 24 Feb 2022 09:30:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m4hVCpcCFZnM0DwuIUgvXeClSraq3VQwNahMuo1dtAw=; b=Vn4q9ExhzF6/aa6K4IV4Mv5h4cOBN4xQtQ1HVo+M+a1YLNz0Fy3+7AlJmErH2l9UvD bQDBtN2Mro37hCGnk7PhBCU4Jma9IUyUSRwJU+NVM5AmChdlBYsTwV0mjijoYB1/oBtt jkt3S8nOpa4Y4x0srqodxMrYyLsUiUlPr6CSs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m4hVCpcCFZnM0DwuIUgvXeClSraq3VQwNahMuo1dtAw=; b=MJ9NjnO4YzLOQpkyvc++bwXxp365B3Cksc10hWUhvfyXWCLU0FfpzaEq98oUpC/i7m EXFfmelehY0hGxg87KGo0dKc0UhSrufJGI/v5TAXPEHVTazgRfT+TppJ5RZgxYgKhO7k uOuHB/HOIn+n5k29PJn01k5qH/BC1bkDEdHcAHgb4VXg1quZwAszlqvYxqAexoEHPLsz Z6h36hqTWyHSPwUtjsjBlHtlXi4Ia/tKBSRAmj+VDzxcZ/il/hHPqGpQGZlWTGzaUlld kz8Z1TUbw2uEr2vWVX30kKaVNOMMfpsFhXXSGOdOTtbc+61YDagJLlgI3IHkovmUH/4x MPfg== X-Gm-Message-State: AOAM533uOX+fMyElBlUgcsRB7FvASK7/kqxTC2F2tnosGQW8Nuinq0Pd tGT7Yh/k9iOXpyJriA+hU7LlPfREmd2RgHFRO2U= X-Google-Smtp-Source: ABdhPJwCe8ykBHMbb2Q9HnL3DbCPja2qUrm+o5uoMHteJUR+yhuyZ3Jlct05IBxzeYKcuc1yXLYFtg== X-Received: by 2002:a05:651c:994:b0:246:170b:3619 with SMTP id b20-20020a05651c099400b00246170b3619mr2606543ljq.103.1645723824050; Thu, 24 Feb 2022 09:30:24 -0800 (PST) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com. [209.85.167.54]) by smtp.gmail.com with ESMTPSA id q13-20020a2e968d000000b00246215e0fbesm25317lji.11.2022.02.24.09.30.23 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Feb 2022 09:30:23 -0800 (PST) Received: by mail-lf1-f54.google.com with SMTP id y24so5154384lfg.1 for ; Thu, 24 Feb 2022 09:30:23 -0800 (PST) X-Received: by 2002:ac2:4d91:0:b0:443:127b:558a with SMTP id g17-20020ac24d91000000b00443127b558amr2528931lfe.542.1645723813162; Thu, 24 Feb 2022 09:30:13 -0800 (PST) MIME-Version: 1.0 References: <20220224122614.94921-1-david@redhat.com> <20220224122614.94921-6-david@redhat.com> In-Reply-To: <20220224122614.94921-6-david@redhat.com> From: Linus Torvalds Date: Thu, 24 Feb 2022 09:29:56 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH RFC 05/13] mm/rmap: remove do_page_add_anon_rmap() To: David Hildenbrand Cc: Linux Kernel Mailing List , Andrew Morton , Hugh Dickins , David Rientjes , Shakeel Butt , John Hubbard , Jason Gunthorpe , Mike Kravetz , Mike Rapoport , Yang Shi , "Kirill A . Shutemov" , Matthew Wilcox , Vlastimil Babka , Jann Horn , Michal Hocko , Nadav Amit , Rik van Riel , Roman Gushchin , Andrea Arcangeli , Peter Xu , Donald Dutile , Christoph Hellwig , Oleg Nesterov , Jan Kara , Liang Zhang , Pedro Gomes , Oded Gabbay , Linux-MM Content-Type: text/plain; charset="UTF-8" X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=Vn4q9Exh; spf=pass (imf27.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.176 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 2E41440009 X-Stat-Signature: 8yd83ooy3oj7i5xqgffm4dbmkrf8c931 X-HE-Tag: 1645723825-957451 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 24, 2022 at 4:29 AM David Hildenbrand wrote: > > ... and instead convert page_add_anon_rmap() to accept flags. Can you fix the comment above the RMAP_xyz definitions? That one still says /* bitflags for do_page_add_anon_rmap() */ that tnow no longer exists. Also, while this kind of code isn't unusual, I think it's still confusing: > + page_add_anon_rmap(page, vma, addr, 0); because when reading that, at least I go "what does 0 mean? Is it a page offset, or what?" It might be a good idea to simply add a #define RMAP_PAGE 0x00 or something like that, just to have the callers all make it obvious that we're talking about that RMAP_xyz bits - even if some of them may be default. (Then using an enum of a special type is something we do if we want to add extra clarity or sparse testing, I don't think there are enough users for that to make sense) Linus