From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA626C433E0 for ; Thu, 7 Jan 2021 19:47:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7391823433 for ; Thu, 7 Jan 2021 19:47:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7391823433 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A7C336B02FD; Thu, 7 Jan 2021 14:47:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A07666B02FE; Thu, 7 Jan 2021 14:47:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CD636B02FF; Thu, 7 Jan 2021 14:47:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0047.hostedemail.com [216.40.44.47]) by kanga.kvack.org (Postfix) with ESMTP id 73D836B02FD for ; Thu, 7 Jan 2021 14:47:22 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3C9A3364A for ; Thu, 7 Jan 2021 19:47:22 +0000 (UTC) X-FDA: 77680013124.03.wound69_0603ff0274ec Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 1BBFD28A4E8 for ; Thu, 7 Jan 2021 19:47:22 +0000 (UTC) X-HE-Tag: wound69_0603ff0274ec X-Filterd-Recvd-Size: 5243 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Thu, 7 Jan 2021 19:47:21 +0000 (UTC) Received: by mail-lf1-f41.google.com with SMTP id o17so17421562lfg.4 for ; Thu, 07 Jan 2021 11:47:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8ruY7+Hc6DwjfUtsIGmEMt3x9fL7QwNpww7Qmh8m5ao=; b=FqnqVnVRhdZ06qPkVepbc2d6YqyFCx6doQkSftj/eLt2k4QnSPYtgEpD3IcxBsg6Sc 58CHR7Y5cSwWtGBBFbBHUOAu+DGUplKWy0JWSPQvWkeuwNRpNRO/Tp6sndPafmhBl9Wq iOWAlxJfkbmFP6NX+zwC7HF8T1R8D9wozuP5Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8ruY7+Hc6DwjfUtsIGmEMt3x9fL7QwNpww7Qmh8m5ao=; b=O8YLIRWncvnKnCnaQCwaScIk1Df3PyOp0QCUrdNo+ZtwFfD7S4Blw/vxpHnUkE/uwx HDxDwxZP6Hph6Rt/CtP0HdlkDCB/TWwkhrjTJOcgVoZLXKwdl30roNOQ5Jshb4Kfc99U 3/tUQOxefdvZjp44Shyf2BOnPuZEVGagU2cRst1XvyyNupNaVxIX3P9036ZId8mp58uV g8gmEwVPsAvykr15jVNMtFMzbGONpCXarIvzQH6eW7WwQQuA54NfKS7gXltR/kTeFi+p 6TTTWPd2zFpcm7YYn1GFAt4OFz8fEDFbjJKT0eu2xynpqQVwQqv8lEY4CqFngQc30Lgs b88Q== X-Gm-Message-State: AOAM5302qC73ENtjiZvs2QlSJhgwI0sJ1cQF3vxQXMFB6ydAR/GZbabV ZlqKmZP5Ql4CuNZK2Sk8OK6ZwLGX/kD5RA== X-Google-Smtp-Source: ABdhPJy7BW9PScBVkA7FIhFO0pE6eQA1s9FMWLXg8rhZYrW1aZANRzovI3kdphLlx/XOZudNg6vUwQ== X-Received: by 2002:a19:f203:: with SMTP id q3mr150487lfh.166.1610048839894; Thu, 07 Jan 2021 11:47:19 -0800 (PST) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com. [209.85.167.54]) by smtp.gmail.com with ESMTPSA id a15sm1360585lfr.68.2021.01.07.11.47.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Jan 2021 11:47:19 -0800 (PST) Received: by mail-lf1-f54.google.com with SMTP id x20so17303575lfe.12 for ; Thu, 07 Jan 2021 11:47:19 -0800 (PST) X-Received: by 2002:a2e:3211:: with SMTP id y17mr27794ljy.61.1610048838877; Thu, 07 Jan 2021 11:47:18 -0800 (PST) MIME-Version: 1.0 References: <20201118194838.753436396@linutronix.de> <20201118204007.169209557@linutronix.de> <20210106180132.41dc249d@gandalf.local.home> <20210106174917.3f8ad0d8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: From: Linus Torvalds Date: Thu, 7 Jan 2021 11:47:02 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [BUG] from x86: Support kmap_local() forced debugging To: Willem de Bruijn Cc: Jakub Kicinski , Steven Rostedt , David Miller , Jonathan Lemon , Thomas Gleixner , LKML , "the arch/x86 maintainers" , Christoph Hellwig , Matthew Wilcox , Daniel Vetter , Andrew Morton , Linux-MM , Peter Zijlstra , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Netdev Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 6, 2021 at 8:45 PM Willem de Bruijn wrote: > > But there are three other kmap_atomic callers under net/ that do not > loop at all, so assume non-compound pages. In esp_output_head, > esp6_output_head and skb_seq_read. The first two directly use > skb_page_frag_refill, which can allocate compound (but not > __GFP_HIGHMEM) pages, and the third can be inserted with > netfilter xt_string in the path of tcp transmit skbs, which can also > have compound pages. I think that these could similarly access > data beyond the end of the kmap_atomic mapped page. I'll take > a closer look. Thanks. Note that I have flushed my random one-liner patch from my system, and expect to get a proper fix through the normal networking pulls. And _if_ the networking people feel that my one-liner was the proper fix, you can use it and add my sign-off if you want to, but it really was more of a "this is the quick ugly fix for testing" rather than anything else. Linus