From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14C09CA0EF2 for ; Tue, 12 Sep 2023 16:20:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E2216B0123; Tue, 12 Sep 2023 12:20:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 590906B0124; Tue, 12 Sep 2023 12:20:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 430E56B0125; Tue, 12 Sep 2023 12:20:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2EECD6B0123 for ; Tue, 12 Sep 2023 12:20:24 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 00F89B3E72 for ; Tue, 12 Sep 2023 16:20:23 +0000 (UTC) X-FDA: 81228457968.27.9B33890 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by imf09.hostedemail.com (Postfix) with ESMTP id DCFD514000C for ; Tue, 12 Sep 2023 16:20:21 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=aha+4X4e; dmarc=none; spf=pass (imf09.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.171 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694535622; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=smeLEFbah2HoW6uf8iZFGOeEFVNCc9b6q/n/ZC4m50w=; b=TjHoyPRXLT6ItyPHe61PUvbbq7iyebh+fe73sEmzeyKV4nYY14ah5sikhlSdbtxTTAcl1H Kc4BCpKTXNa2Ctj/VkSKcgiNu6y5zb9lHQuT5Vm56RMgn6vwM+xaJkzjbG5n4uXQBAN1HY YWohFqJhc+iHm500eywxpTn6FEwtirY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=aha+4X4e; dmarc=none; spf=pass (imf09.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.171 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694535622; a=rsa-sha256; cv=none; b=VIMZ12MQihscX+G2lsSzYOVI5nKc7fr9SKOCFEXNJgR5eKddOcGLMmiYZX2PuPAsVocOSw a6+ukYORSO+BMFWFmGnM9YPaYiQYyCiQ4KP/HzAQTCVSp2RLM9KDga7eO6jlVBEWGEhegd kLe5oKcDlo38pPHja2LOnqAIN5wT518= Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2b974031aeaso100361851fa.0 for ; Tue, 12 Sep 2023 09:20:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1694535620; x=1695140420; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=smeLEFbah2HoW6uf8iZFGOeEFVNCc9b6q/n/ZC4m50w=; b=aha+4X4egC5RDAQLH5dTHuycEd28IrQVhvZT4uSxfJCXq/9/g4OOT8g+F72ioK0+3i ITAJgpFCjAvsv5AgIPc7TgV18nijmnKhj/60M7Sk4f5gWHB40bQZ5MU1rkZsM+a8JL5v e1MXr7z1uWqipPOiTaNOCihweRZEBEV48jvWg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694535620; x=1695140420; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=smeLEFbah2HoW6uf8iZFGOeEFVNCc9b6q/n/ZC4m50w=; b=Hz165aC1/surMZdG+Go1Riti5RZqU1C7H8xl2xCHWNxv4o1bpoNSAlomnA9LZpZKM8 9Rba89YSMiNFcxf4iiSi4EnnI7LTWwdhnSXFDeDq0bjrw4uE6Osh6eS6tqRFF/k/MNuY 8v9Kt68P982kxobLgx+VaZS1iKCwilAjN0skkp1Q2WUk9QcecPA90joi0C302RnS1vMQ IjBOLZkbNIVKLNMcGMS37FbTT8aIOxPcdf8E8D2NyxXhZ/V2dy+Rq6dDWams2+5ZZvvj 2KINNYSml/BclbohrarM/qmkZGh0IJqqlsWXoB6LpJ2Y1GJsN9Jmc08XQvv3D4iisavB rM6Q== X-Gm-Message-State: AOJu0YzE9EZuF/2LjEQbDWCcA2QeiMuvBpbydKGOwpy69SyjsGSfgjDx gSDjYbtaSchmFmJ4fjXGfWMErBtzpObSmN+sPRV1zfSE X-Google-Smtp-Source: AGHT+IGAfBHmBgqP+izR/fuOGbUgpG8d7cSSUbYMQ3Xdar7qruREJs+wm6gNFSItScnXEIwyvuSk+Q== X-Received: by 2002:a05:651c:10cc:b0:2bc:e827:a4ff with SMTP id l12-20020a05651c10cc00b002bce827a4ffmr258806ljn.9.1694535619834; Tue, 12 Sep 2023 09:20:19 -0700 (PDT) Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com. [209.85.208.177]) by smtp.gmail.com with ESMTPSA id t12-20020a2e9d0c000000b002bce87faca9sm2023106lji.57.2023.09.12.09.20.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Sep 2023 09:20:18 -0700 (PDT) Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2bfb1167277so3465271fa.2 for ; Tue, 12 Sep 2023 09:20:17 -0700 (PDT) X-Received: by 2002:a2e:6e0b:0:b0:2b6:d6e1:a191 with SMTP id j11-20020a2e6e0b000000b002b6d6e1a191mr204380ljc.23.1694535617572; Tue, 12 Sep 2023 09:20:17 -0700 (PDT) MIME-Version: 1.0 References: <20230830184958.2333078-1-ankur.a.arora@oracle.com> <20230830184958.2333078-8-ankur.a.arora@oracle.com> <20230908070258.GA19320@noisy.programming.kicks-ass.net> <87zg1v3xxh.fsf@oracle.com> <87edj64rj1.fsf@oracle.com> <20230911124856.453fba22@gandalf.local.home> In-Reply-To: From: Linus Torvalds Date: Tue, 12 Sep 2023 09:20:00 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 7/9] sched: define TIF_ALLOW_RESCHED To: Matthew Wilcox Cc: Steven Rostedt , Ankur Arora , Peter Zijlstra , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, mgorman@suse.de, tglx@linutronix.de, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: DCFD514000C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: mgdirrf46y3amiccpmruw1yygg8u6oc4 X-HE-Tag: 1694535621-769285 X-HE-Meta: U2FsdGVkX1/9rYOU+2GiHdBAsXHS+CGoeoDd21xc5VFfjkSsx3CScGU47RL0sVfLTDYQOa5FV3g9AXYB2kOjyGFJLjOgQlq2E6D0TGHNduTrw9nKYpyVAXxO4QAC1Pk0GGgSBz2R9QtMpwHFwSWGdUIMv0O+pUz8VovSdXbvHpAnAVERkOahrTSZuqhMuG3qfQ98O1OG68WFL6Zrp0u7Xt+EgI1FonzAg3Oso6Pn9zYzrfXDWETuRnMbak8ZuhPWDsDweIMzN2qKqrVi0Jb02KblNTv+ZF00WaIWtCIC39x9aGfWIDogRbFu7vthZG2C7k6rQ6fk4peQgu1JfJ/ZmU1fnmM4/LGY52c3F9J3UprBacIx1cDhK9K9br5HJk3OcLP8o4vB7CBIN4oiZiYg/I+BJeX3mcWCg5EzFP1JQcCUdGAYpu/iXkh8ahOakusxGrgcobMmlhviEa7fC0crlt7FO+ejVTySX3f9XN810TNnpm0bhgyA3xUVPwqgPGzf4eXrEkgYTbBE8RxFu3K1sd3lyQl2HcxDr39koAkkNdwokOwZQW+zpPkV9yV3xXhg6jmoCIvrtnZp6mZWJbZ/oCt65qhS4WVsikOsuzilVHSFbKCxgo1jjtsmfD/wUuxL3sZJjJqXqL8SJDf/4fh/zJQwuRlLtmDnzq7YSV9BUmaSYpYIr2aTnnLkpkC8xYQ7ksyL2cvWw+RJqPrx9BXTXKBbxR7t53E97fk62onZcXGx4G49Tx/mgqRwz3iUKg4MbqTFRwJipthslK/liUnT++LwTi00L6h4QmDG3Rs025HV1xoVDFrutzKrpNUObSwLUHiQ/MZZNN2YJ51OQ0ggPl5VTOCcPX9RkCm47m+E9YfSF+aymgNMqDX2G20vnSSHk5IGBvhqONpIeb1Qy08FQT5w6l0cBhYlMk0B93/6rDMnCb5rTuBVuqVdyGT97ttfCZ1xoZfD11GOw1aAehI al+yKI6F vuCAG0KMA3RT4KFADEgunChJLud/fXtsgwK9+Y89aOhGlAzl6NrYP5m/7UPplOiakOBMBpHUp/iavE5S4+E7syZ3wDBn2UogXYpmmfeIub+1hsfoyIa1cC0fGCEXTMGzAs2oMqe3Vo3af5EfAIRk4zAYX7Ss4CsqhXRMBGIo4CHmY29Ra2F8QgAwLKFqSBKj9UCnwwMGSwvTCetikfBXgV3mvYj+cv3Y3NCOCJU4Ob/eVhHM9zsNoRaJv5TQQ1weUut4Vu3/8ghSusMhCvN5zdJewDlszy3EwD0Zj32yGJQABW/4nIypC2y2QyCKI5KfOsPqLnicbADqSrP27l10hyUIUAyf7u6BjtjCd6kRmEJqpFLvwga9vnYrzOHvGMk2LhOBsGmEx4oSlWZ+j+vusrJeVGPBeTZJovqOtP0LfgVkiqazaG+yQrtLw3bfBeubOXt4Os/Ox4unFQAKBrpHm1tE5wKusuAIcoPOLoqSG+9QZgOchZX6M3y3fslSICQnLM0D9RQVKpYxT+y+hk3d/rHEFgbYemPnBERDVV5bjex6sJejoVY80Y+PPA6i4WQxRe4ruTmjOudn7qkWQN6IARu3/BuhNNtONSxCpwI1mAogcDxQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 11 Sept 2023 at 20:27, Matthew Wilcox wrote: > > So we do still cond_resched(), but we might go up to PMD_SIZE > between calls. This is new code in 6.6 so it hasn't seen use by too > many users yet, but it's certainly bigger than the 16 pages used by > copy_chunked_from_user(). I honestly hadn't thought about preemption > latency. The thing about cond_resched() is that you literally won't get anybody who complains until the big page case is common enough that it hits special people. This is also a large part of why I dislike cond_resched() a lot. It's not just that it's sprinkled randomly in our code-base, it's that it's *found* and added so randomly. Some developers will look at code and say "this may be a long loop" and add it without any numbers. It's rare, but it happens. And other than that it usually is something like the RT people who have the latency trackers, and one particular load that they use for testing. Oh well. Enough kvetching. I'm not happy about it, but in the end it's a small annoyance, not a big issue. Linus