From: Linus Torvalds <torvalds@linux-foundation.org>
To: Peter Xu <peterx@redhat.com>
Cc: Linux-MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Marty Mcfadden <mcfadden8@llnl.gov>,
Andrea Arcangeli <aarcange@redhat.com>,
Jann Horn <jannh@google.com>, Christoph Hellwig <hch@lst.de>,
Oleg Nesterov <oleg@redhat.com>,
Kirill Shutemov <kirill@shutemov.name>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH v2] mm/gup: Allow real explicit breaking of COW
Date: Mon, 10 Aug 2020 13:59:44 -0700 [thread overview]
Message-ID: <CAHk-=wgyF30ap_tREfey7J9w0MyYDxso1ui-e98U0yYi9pPmhQ@mail.gmail.com> (raw)
In-Reply-To: <CAHk-=whUVHA-=4mwGaUA42teESc2mX1nwZjbbOMQsvPaoYxh3w@mail.gmail.com>
On Mon, Aug 10, 2020 at 1:51 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> See? That's the whole point. It doesn't _matter_ if you're only
> reading the data, without the COW you may be reading the _wrong_ data.
Example safe users:
- if you hold the mmap_sem the whole time, you're fine
- if you only look up the page mapping for some tracing reasons, you're fine
- if you can explain some other reason why you don't care that some
other process might be changing the data from under you, you might be
fine.
But the point is, you need to _explain_ it. Not just say "I don't want COW".
Linus
next prev parent reply other threads:[~2020-08-10 21:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 14:57 Peter Xu
2020-08-10 16:47 ` Linus Torvalds
2020-08-10 19:15 ` Peter Xu
2020-08-10 20:51 ` Linus Torvalds
2020-08-10 20:59 ` Linus Torvalds [this message]
2020-08-10 21:57 ` Peter Xu
2020-08-10 23:19 ` Linus Torvalds
2020-08-10 23:38 ` Jann Horn
2020-08-11 15:05 ` Linus Torvalds
2020-08-11 15:27 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgyF30ap_tREfey7J9w0MyYDxso1ui-e98U0yYi9pPmhQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jannh@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcfadden8@llnl.gov \
--cc=oleg@redhat.com \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox