From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EBA9C4828F for ; Sun, 4 Feb 2024 09:09:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 955286B0072; Sun, 4 Feb 2024 04:09:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 904846B0074; Sun, 4 Feb 2024 04:09:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CC036B0075; Sun, 4 Feb 2024 04:09:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6D21D6B0072 for ; Sun, 4 Feb 2024 04:09:38 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E93BA140355 for ; Sun, 4 Feb 2024 09:09:37 +0000 (UTC) X-FDA: 81753548394.17.F8E664B Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf02.hostedemail.com (Postfix) with ESMTP id 163A88000B for ; Sun, 4 Feb 2024 09:09:35 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=TCZygxmk; spf=pass (imf02.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.49 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707037776; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x+bOGtvhSdoCBkpFP05S+UJkiX09M/YWlTNg9SFndfw=; b=NlOfXZdNX9HTyEq+OAa+rOs7dWbHSf+odtY+bG72tbPgeyC19Av2tLLGVpZzV2WOWec5r2 3H4F/h9A5h9Aw8uHPKw7t+96AAyKfaVXnGfr5EAAYwrUV6/FBHp6fq9dPYDvz2bDEFiipw Qnax111PDD8ddngpnPOQPQReluZBw3U= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=TCZygxmk; spf=pass (imf02.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.49 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707037776; a=rsa-sha256; cv=none; b=zNCIdF2MXxJnL8z1+yqpdLTFCp1UrIlJJMoiQT86TScRHnC/flT7NOYcZocT/DyoB6TDCZ Mek49iJcrBKIXLgMclTSFhdnGX0fTUxwyxfYE32cl16z/K3n7CSxAOXI/LxkQpxXu44xze ZqKw0HAlryzvPPc0/IybqEMEk+SFd4E= Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a2f79e79f0cso471816066b.2 for ; Sun, 04 Feb 2024 01:09:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1707037774; x=1707642574; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=x+bOGtvhSdoCBkpFP05S+UJkiX09M/YWlTNg9SFndfw=; b=TCZygxmkAKRqsNoTqOPgNe6t25kyJU98BEwbgkMio6J2lPhx10x1Dl5IEMUgGUlqdP K3alc6/XTB8tzdcxW0Y+jsl2FSbXuTjon3YmpxqSmOZf6ZKnCnvEVDneHxpuoba3cBt5 NUahzqzrlTht1efrMasNp5yzexasXcVVvl8SI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707037774; x=1707642574; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=x+bOGtvhSdoCBkpFP05S+UJkiX09M/YWlTNg9SFndfw=; b=YqFBN8mBO43hU912m4qa8iQa+KZGzM9l07hGPxnEBdSinTEKgUlRG5jWi046CHmEkl NdeGs7pnAkmQmg2rKk+AybJ4nJUC2az2pV7OnGMFVifBQ/qRuGGUubCpLXihQ6bwd/tZ tGXIOVUQNslLDL2+Em5BVyCeRXtGIr8WsRtGdPXBOzJD5NKedwgbLh/pamwPt1eq9bQe /UjJXWhy3COqb06r3AmU7uFg26MN9WT3WJyssGWFejYQrwyKwMH/s+6XCCj5fOjgw10Z 3EwN29cks9grV98HjBxPxZIaZFItrbZB1bBjOSuQ1idnG1kdqSXqjy/m89fQdbCd95d+ nDdQ== X-Gm-Message-State: AOJu0YzpSP5KXxdbcOEpOXZylBXwFrnXrpkXca6D1b+3iRYXeBWIoXBP 7SAzY8aY8SyUFgZOPMAajRrRZ+3wMOeCkYME/nuwfLY5iD9h4EsxyiJ2CC66f7OH9FAtcv6MR2A 75yY= X-Google-Smtp-Source: AGHT+IEM5UfMzmI2x5HaWlct0MlneKU6UQOIS8Y0GNu3UOzE9K8s2iD4gXExac4gLxkHdaPHrnmB6Q== X-Received: by 2002:a17:906:23e9:b0:a37:27a8:9a66 with SMTP id j9-20020a17090623e900b00a3727a89a66mr3866936ejg.39.1707037773974; Sun, 04 Feb 2024 01:09:33 -0800 (PST) Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com. [209.85.208.52]) by smtp.gmail.com with ESMTPSA id s12-20020a17090699cc00b00a376cfb1717sm1067442ejn.36.2024.02.04.01.09.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Feb 2024 01:09:33 -0800 (PST) Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-55ff5f6a610so2112311a12.3 for ; Sun, 04 Feb 2024 01:09:33 -0800 (PST) X-Received: by 2002:aa7:d4d1:0:b0:55e:eb81:2db0 with SMTP id t17-20020aa7d4d1000000b0055eeb812db0mr2894600edr.38.1707037772839; Sun, 04 Feb 2024 01:09:32 -0800 (PST) MIME-Version: 1.0 References: <20240204085155.6745-1-sanpeqf@gmail.com> In-Reply-To: <20240204085155.6745-1-sanpeqf@gmail.com> From: Linus Torvalds Date: Sun, 4 Feb 2024 09:09:16 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] lib/bch.c: increase bitrev single conversion length To: John Sanpe Cc: linux-mm@kvack.org, akpm@linux-foundation.org, rdunlap@infradead.org, unixbhaskar@gmail.com, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 163A88000B X-Rspam-User: X-Stat-Signature: nesphxzdqiwx6pmt3ta31gmqccypmwdb X-Rspamd-Server: rspam01 X-HE-Tag: 1707037775-797314 X-HE-Meta: U2FsdGVkX1+zss6jJ/ON91LucfH1UMxhe1e/8ylz/NrufcqMVuZ34kquoFv3GL9ZQIlgfUqj4sUDWWa8JpW7st9ktqcwGCCIJ6h0/uBORa5/1T2pxiC3Tdy0SUcD5nvf+VCHH4KZNU5oRdrpKY5E5yLwZeer+sgSi4KJQ/6R7CqZt1mPFEirF5EnA54CnSMpiN3p1Zkt4kvBK9XPgZJdMBIl41ZTdb/5OsemRwUseEhjmB1vgKmqeOdAPHcFT0qi65q4WaST7bkJp+Pcxk37aAf1ahE7+gLwNZsx0Et6rm4ZaWTkrkaME1REpueNKU+vfrbScEH1yZobgG9obEcWCetK3WoS7THACGyhvPmDuNhScStst7BSpO8gtlXO438jA6/rPa7zne9LeQeKJdwCerF5yfTlj/x1PosSVVnJI/94DPQXSjLZmpUumMkcsapN8CGOanDDmQUnHXM3Hm7gInBA470GXM47NXvKEc9uKLSBLOgLttA8EIaBrpW+JEjTMSrnV4gBNFcKb1Y2iZ+6AS2Abu6v+SYxjCS1pOslKbbjwBXdwd5q4eEzLmyjs3QSyFhsqVTiBVhe4QehKlRTSAuXCRcrslNkhZu2/a9ZRQfLlRCf5v/eUYYL58fR/X68KwwNY74FUlGcCFTHBR+96aQvjrWBLv327CWZ6XqPsz8k7xMPUrJ0rPzRHsjKL6WJ+ufZx3WuLYOlkS9Y929tl06IQHZ3WPrBuWAk6NrIGfgROJZhK/0QcmbvZZeaL2Z4jd6Qp7aXen3yU4M8kd2486qBQGz1icZ8sR2yTBeIGZqUr0EQBcCUFXzEFqBbN6b+FUCo65WPEHfvWG9O7gISQgosOyJs1evjQ2M+7M4q+ZC9G4P8U23ydtDjcfPZAVBkZ4/SVLyqGEBTzpKDBuHL1SGnIdAiw/3URiO22JMfxoy4Ap6qn1nRBsWj3LkX+bDejETvxNvq9jR45Hj1TLx 3Vh9L3Wc RQEXF194XOk5jWGseAhC6beRraT+Ido1dG1NFVulegzl8e5JbBcdHua9FDtJkJuxKO1zvgMB9adX4hms6PPTKcBJgd8HsBE7TsAvMJQsspJewS+DtZ2ktgpUlRcdcXPdCiZ+TgpOq2b5BtalHyF8VOl0xTZPaW9sTqJmPHZIgu0OryvGRxspc2h99jXOFZZdHbmWt1xZZVY4pfR6obsVlI5iKa3Q9dDcoRZQIAinjUcDbGi6oVhObAatbSUf9otV9hjElYWo9BFmRoN4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 4 Feb 2024 at 08:52, John Sanpe wrote: > > Optimized the performance of the three functions (load_ecc8 store_ecc8 > and bch_encode) using a larger calculation length. Honestly, with any optimization, you should quote performance numbers. Also, it's questionable how meaningful this is, considering that most architectures dop the bit swap with a byte lookup, and the 32-bit bit swap is just four byte lookups. For all we know, this only makes things worse. Finally, if you actually want to do things in bigger chunks, that ->swap_bits conditional should probably be moved out of the loops, not just have that questionable 8->32 bit expansion. Linus