From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02E32CDB474 for ; Tue, 17 Oct 2023 16:54:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 501D880042; Tue, 17 Oct 2023 12:54:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B0238003F; Tue, 17 Oct 2023 12:54:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 350D980042; Tue, 17 Oct 2023 12:54:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 232B88003F for ; Tue, 17 Oct 2023 12:54:57 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E28791A0DCE for ; Tue, 17 Oct 2023 16:54:56 +0000 (UTC) X-FDA: 81355552992.20.8F904F7 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf02.hostedemail.com (Postfix) with ESMTP id EF44780017 for ; Tue, 17 Oct 2023 16:54:54 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=NOR26GYo; spf=pass (imf02.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.46 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697561695; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K1bTNFT87lr+HVy46GvlRl8WsLt2mWlRGa4YdiUNjuo=; b=mCbZOYmPKwjA776eolPhI1b6LC6wrQFrvHaF2ZY2Tdsm38fEkLZJHvx4SOkrej6HenMeJn WT4PqcUGJtmR1PlkCr54xw033LBbikPnomVZwEtE4sU28jkxfhwIkPmjbD3etjH19oSLnq A3XAnGUr/z8bX1U6UH1UB8Q+PvMFz7g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697561695; a=rsa-sha256; cv=none; b=EqLR0F5a/jEnQh1UotIxTJyGS0XEsGkDSzFShJgfYiiLIlOLktzEEUxUUjD9aBPyiQ/aa/ sLQQjpdDvam0Q86MiBhUp4ZfyV3EaLwTl3IGAsaEBWDR/xc+wf/ICCJz/i4S7DOC33exPC Nr6Xr5dLGg0C9Qus3ntFClLCHU4qqqE= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=NOR26GYo; spf=pass (imf02.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.46 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-533d31a8523so10061665a12.1 for ; Tue, 17 Oct 2023 09:54:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1697561693; x=1698166493; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=K1bTNFT87lr+HVy46GvlRl8WsLt2mWlRGa4YdiUNjuo=; b=NOR26GYoYfWraT9qFQaYqS3X5/LM7UaAEuI+Sc7/IhQgqDqBxs0LWoJT3WjrlYD/qP TNkeKUBCR5nExvBFCRoU69E+vc1IddLaYC6nkBEuLtMZ4kuIg/DQj+tFB+tLe8aaWzSG RNufGIbv3YVFp1aBSkTtz2vvpVp+YK6qT28RY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697561693; x=1698166493; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=K1bTNFT87lr+HVy46GvlRl8WsLt2mWlRGa4YdiUNjuo=; b=Qg61FSIFtNVqOg3/4GrvOlbr2YPlVfteVdqnOcoxN7/bMU70WnsK61+iubwnQuMZYX jXvRpHwrHFPasrMPxTNueL9hKhl5G5cGTW9Qgpvc3+ogaM11qZjLWvLbvzI3bFw0OcE1 MQMxgYUTojFlyDdjiLNSta1LTTapf59V1mSNtO/XSR0FyzOGcmNr1M8ROYVnJNGVub0t iNB7Bql1t5i90a1FV/FOwtkiqVYBlW3IpTpVWUPxn5qRPuocr1xxn1RHc0atRa6HuR5+ 499oeu2Bzwfq2aXN3MsxjkLkmFi8LOZ4PUhzqcpENJ/wEQnpygBEYnANcHN2Zv+VtGKZ TcSg== X-Gm-Message-State: AOJu0YwXspVWqdT1UtXeQP/ZrapdKrVGwQMhzK6r59ZDgdE6Tf2tDaQP kgt7S25z2SKlYJdfWt81RMFQYtFA6mpH+DR2rO6WkMQH X-Google-Smtp-Source: AGHT+IEHxcmqwJSWl7V2L2jKvfaxuSSiPYk0ecSP2aCnZzdEwFym91DwHZJ+/d/nbADps/Px8M/csQ== X-Received: by 2002:a17:907:d8a:b0:9a1:f10d:9746 with SMTP id go10-20020a1709070d8a00b009a1f10d9746mr2203919ejc.20.1697561693157; Tue, 17 Oct 2023 09:54:53 -0700 (PDT) Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com. [209.85.218.46]) by smtp.gmail.com with ESMTPSA id lf10-20020a170907174a00b009b29668fce7sm120478ejc.113.2023.10.17.09.54.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Oct 2023 09:54:52 -0700 (PDT) Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-991c786369cso954854166b.1 for ; Tue, 17 Oct 2023 09:54:52 -0700 (PDT) X-Received: by 2002:a17:907:3cd:b0:9c4:b8c9:1bf2 with SMTP id su13-20020a17090703cd00b009c4b8c91bf2mr1497085ejb.60.1697561692367; Tue, 17 Oct 2023 09:54:52 -0700 (PDT) MIME-Version: 1.0 References: <20231017090815.1067790-1-jeffxu@chromium.org> <20231017090815.1067790-6-jeffxu@chromium.org> In-Reply-To: <20231017090815.1067790-6-jeffxu@chromium.org> From: Linus Torvalds Date: Tue, 17 Oct 2023 09:54:35 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH v2 5/8] mseal: Check seal flag for munmap(2) To: jeffxu@chromium.org Cc: akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, sroettger@google.com, willy@infradead.org, gregkh@linuxfoundation.org, jeffxu@google.com, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, surenb@google.com, alex.sierra@amd.com, apopple@nvidia.com, aneesh.kumar@linux.ibm.com, axelrasmussen@google.com, ben@decadent.org.uk, catalin.marinas@arm.com, david@redhat.com, dwmw@amazon.co.uk, ying.huang@intel.com, hughd@google.com, joey.gouly@arm.com, corbet@lwn.net, wangkefeng.wang@huawei.com, Liam.Howlett@oracle.com, lstoakes@gmail.com, mawupeng1@huawei.com, linmiaohe@huawei.com, namit@vmware.com, peterx@redhat.com, peterz@infradead.org, ryan.roberts@arm.com, shr@devkernel.io, vbabka@suse.cz, xiujianfeng@huawei.com, yu.ma@intel.com, zhangpeng362@huawei.com, dave.hansen@intel.com, luto@kernel.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: EF44780017 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 4egkb34t1giegkewisjakuxketrgq6ez X-HE-Tag: 1697561694-418974 X-HE-Meta: U2FsdGVkX19qogyuM809so2ENiwLVY55PwcUdH0wfEnwh7n4S6fOWXBT8i9BFkLSFYYBmN/3NC1UQH18p7tkZH89zQSSL9TrIIHWT1orBPLzsCue6kO/rTLUg8dfPrRmNYqx2hswkIm3lqJySwEdPzVvtXpGn45i2B5xhZ161zHSiOEvem2XkDgh//HCz3s2Gw00MAHBa/oQqB3AkMSwzmDSIqnifxrWY5hUjUiqZeAu5ighs/eFqFnhtm1B0S8yKgLMuSosIHIoLjtqWcXWi8j05vqtw9xSzqXoVfKm2i6lcFwVvqi6+vkskTxiMQ8D3r6KhT/9vGTUTCZmdZGQ6X+lLMqHsBO7hE2MRPjzq7EF4Uxl7LcZ2gOEihDQPPn/CaWmuz2uS4L9tUNNeiBgHXUULMb0BpoZ3SGMVw9XsfxNg1JchYC7LwItXnbjmWrgqpKn+YIAT/BtjDBhjRK9S+eTMjsoYmP39d40mT7iGBox7lErrxuaUmPsP8fJJLNFSFDmXopy+pp/iX53Qw/tlb1SOoqUTWSXmsRfqPcJOjRpyc63Xr6F+Utn6e06yNava4lyFVgFTqW0G5wSbS0UUXJ3p7WAcXJm3wIlgMI341lRMnv9F36tzihqDXkcX4DV7FwyMM4fVcryEFWUx+bM1IR9GNfg9u+FKgVDHtq9ePWqw4BzCthBXOn2TTPwUo8OEPQDnqd/A6lpxdjA/y2EpTLkdN+ohasj13J+MvlpbZmJnAdd416b+RYenBIBh/Yz/egjVza8YSq7FO9yBqyYcU/nWJQQIZOlKsQ+nB2fMeNHKpWYwMGcHtkXQsGplmdjNR7H3oeuGii/vUpa58jqCXYNrZw0JUCO6oV5H9W+bWmf8sXRpiIj02sRO4h+XVM7XIzBXlUI/133ISCaW7V0rEKnj8zfL6dDxqWg7i4tXZSOQf/rmSLGVZ4jf8cLX0fQOC4pNvHD6lBcp5z/OPu VDknLLFi 1g+XGj/QvCr+oLfFkTwjLKBNAxRTFyDArxEojk+U+NS1VzZVutkPKgzSvAz7TQJkfEPJe69Xqe5GCevk/fVJYLSN8xNz6PUUX/kHKOHmSuPoGCJRq6fWas0dBh24PXg6q8y1fmoAhwe7YM1Dr2miSIA++ttLvwB7ICGvF0fQpLlmqNAup9we60BwNM0TPZxiPOPGO3NnjiIqY+p48XW4lGGrmiitcIb9pgrShCM3/Lv1qs194zUr3jj07+a6sczcTVr2kK1MLHFO783AMKOaBCC6d0cFlBaCyIuio7j2dscHhU2yR+h6TLDiRrRn6ozJ2fGVX9jzkacBOSVxqj7MmCDaMLBXQg6DySpog1Smriv26iWsV2fb6fUxfXXcihhbjAe1KF/GPzuslRJxUCiz+7IVUdZGcr2Ii9eTWTwKw6TjNaixLBnE6qlHbTIIr9JqqtND7+R5DnIxPF37KeYcHGtmOnYxVAK0nTkYUnILulfgxewVgpGRCwyGMdw3rpcaJV6+TnIJek9jY2JwX5tSKK3CSMck7IJ/moQF6eGoYhVWpoqbNEi/GMW8+xQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 17 Oct 2023 at 02:08, wrote: > > Of all the call paths that call into do_vmi_munmap(), > this is the only place where checkSeals = MM_SEAL_MUNMAP. > The rest has checkSeals = 0. Why? None of this makes sense. So you say "we can't munmap in this *one* place, but all others ignore the sealing". Crazy. Linus