From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 443BFCE8D52 for ; Thu, 19 Sep 2024 06:57:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FBEF6B0085; Thu, 19 Sep 2024 02:57:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 984766B0088; Thu, 19 Sep 2024 02:57:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FE7F6B0089; Thu, 19 Sep 2024 02:57:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5F67C6B0085 for ; Thu, 19 Sep 2024 02:57:52 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C6CB8A0AB8 for ; Thu, 19 Sep 2024 06:57:51 +0000 (UTC) X-FDA: 82580582742.11.0EEB2F6 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf17.hostedemail.com (Postfix) with ESMTP id A12B04000C for ; Thu, 19 Sep 2024 06:57:49 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=HLTXUETr; spf=pass (imf17.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.41 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726729037; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5TUPhH68J4aIRtGndcy4NXpmyIlQij++uMUQdRa57QE=; b=354CHXLbM6VRFkLvQfBuOYrmpfT4BZW21KE9EOp1WUe7s1uS1wKvPSkSaNLXuN0aMYEJ12 HY2p1n4KiExEktttBwR01SVDGGsO5TYACSLZRXx0Rg9/sVPXt/sumWfwCPEpo8pSS3N6Y9 XP3s/PZxLVLFgixxEgfrO03Mw6FO+2U= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=HLTXUETr; spf=pass (imf17.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.41 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726729037; a=rsa-sha256; cv=none; b=VaEr6uCrgsxJ7aOmnDbpZyg1k3uHG/Lt8QZBa0G/E/y6Yv17w+pyuLXT1BbjsKGApSwdr1 9JqvoWs0tlMp2QPKTlDFs0Ly8qEVb0Y1sHnu/+AKqjIRu+P/4DO8M19f8u2SG1q2vu1w0T b+kD7hKLxero9uQJ2OhF84MH342xj6g= Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a8d4093722bso66266166b.0 for ; Wed, 18 Sep 2024 23:57:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1726729068; x=1727333868; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5TUPhH68J4aIRtGndcy4NXpmyIlQij++uMUQdRa57QE=; b=HLTXUETryiMVlJHqbqbgcXE6QalisuEvOmR74AtOIHkGrxd9iaTP2goj7TkzXwI8w4 EmisqrrJ2MiN1ShX4eB6T0mPw8TE/P8yEGJf1bnxwaE8YRRLjLGV2keBD7yz0tuCIG6X ul1ejbsItbSz1MSaFXgtxyOTpZddUWXnybJZc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726729068; x=1727333868; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5TUPhH68J4aIRtGndcy4NXpmyIlQij++uMUQdRa57QE=; b=sUW3GfMdTDvygUxWICGQw3xtwN2iGWJAnMTAyl6vEhQApN9rXiKDWodOY6Y4Fl5dRr y57hM9VAr7RoTLL3EPvkYQnbeJ2MCXZQrLZiY8z9rwVjcqmxGj1yII661bwNuDDHL9va gsGZpK8DqAiqKOTswAOV3Zrrx830ECrsBSLhzm+1bGYKGzXP1Pipv/rpIZmDCs144sIN ktMeUe5HRVCffg3cJN8W3JFcvbXXFspKNVaNK/pqTQvhgLPmenVNA0s2uUBvPEuCM23Q 1KDTX5YQkR9NqnNFCTe3ETuq2yBL2ztTel9aLInlz29uvAzfOpmiIFtzGrV4StGXCmIV 7QvA== X-Forwarded-Encrypted: i=1; AJvYcCWjcsncZ4JiuFIdY6OFdsjQCtxIXvnnROTPqWUan6ABRAgFWL5op20Byv6AjLxejPPMRoi+hmMyww==@kvack.org X-Gm-Message-State: AOJu0YwUs5J15Qw9rtluAdNdOge13uvZMO/lGRBaFTzAVIBkkwH3ilE0 P3vRhZ/s2m5gU1PIV2LMfiqVlZOjgkUCsfBumU95FS71GAPs/p9TCl4XF7CiO8/P6cShar/L9+E BxbCc5A== X-Google-Smtp-Source: AGHT+IE37GDxsC1Gol+keUrv70zvwf5JHFE9xq6wt2fr/bP0916Uez9ae5fvrzV9JXSf2VJnR98Dfg== X-Received: by 2002:a17:907:7f92:b0:a8a:6e35:31ef with SMTP id a640c23a62f3a-a902961d872mr2907088366b.49.1726729067858; Wed, 18 Sep 2024 23:57:47 -0700 (PDT) Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com. [209.85.218.54]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a90610f4320sm679946966b.85.2024.09.18.23.57.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Sep 2024 23:57:46 -0700 (PDT) Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a8ce5db8668so68342466b.1 for ; Wed, 18 Sep 2024 23:57:46 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUDzb+pIzqC+TV6Bi97l5k1/Z4zvSVJdne6KuOBaOqZoZX3PzwfdhvSZsww67AfZVVKFlNDWYQBHA==@kvack.org X-Received: by 2002:a17:906:f5a7:b0:a86:a56a:3596 with SMTP id a640c23a62f3a-a9029678cbemr2701906566b.60.1726729065735; Wed, 18 Sep 2024 23:57:45 -0700 (PDT) MIME-Version: 1.0 References: <74cceb67-2e71-455f-a4d4-6c5185ef775b@meta.com> <52d45d22-e108-400e-a63f-f50ef1a0ae1a@meta.com> <5bee194c-9cd3-47e7-919b-9f352441f855@kernel.dk> <459beb1c-defd-4836-952c-589203b7005c@meta.com> In-Reply-To: From: Linus Torvalds Date: Thu, 19 Sep 2024 08:57:29 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Known and unfixed active data loss bug in MM + XFS with large folios since Dec 2021 (any kernel from 6.1 upwards) To: Christian Theune Cc: Dave Chinner , Matthew Wilcox , Chris Mason , Jens Axboe , linux-mm@kvack.org, "linux-xfs@vger.kernel.org" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Dao , regressions@lists.linux.dev, regressions@leemhuis.info Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 74wqioq7g57r9rzb33p6w67xyfdy15wx X-Rspamd-Queue-Id: A12B04000C X-Rspamd-Server: rspam11 X-HE-Tag: 1726729069-201679 X-HE-Meta: U2FsdGVkX19X7NIti1F6hmxTAyBJ/KuDrqhy9dYrqL6xXWZWFjlcuCi3LcEkLjYl1SwVpULtZxX118y7vjBTpQZ0i9NGnrtVDFSkDyKHxf9K4YfZB/RbZ9yYViCGSr1pfNwdtEj/sg6d0krIYL+vS54clwxYEZZZV7hEIr4RJgaqunEJQK9xI7JuUGJ+dAEf7JqRSvIleZ0Pch7u2Vf2Fk/D40DiWz+3LUeH9GXTtUm7p/t1p0tiytIpeH8lMud80ET5i6bq2avrpv+O8THQwJm5n7Ep6dPetuTSyS6ePLrW9nHTrj8N9RCw3CDgjGXpjKyFo9y0g/ynNcegVrZCZ5u5q4cVtUdw4GTnBUaj09QfzKlo27EMiay08dyxVb9raAae0dhXBZwAor3byli5Kqoy5B//B9IS+yvEZNwjiXNNVsuxS2IXgRxNTUJdZVxsN5cp6j2SXXqbGAipRweFeQAyO0VR1ZtgW98nSYONql2R5kDYgHUQl8iL6i3reCh9IAP3PeBuJV6Jv1a0La5ftr5JKxlzGIiTznMHInWra3DiYYpoWdbtAuntXZsF7PaUFwol2/jTKG/vPVqePkpWmFXhMkrXr/Mv6kdGkxn+Tw0tQXPttAJd+pxwDV0xrKfHyJUOS6JIKJ6Fvsf8ixtNcqXVduEsM9obpmQ+Z4B1EUx/9pH9qf5wYgIg6FTMkpLjebZkWZ847PZu+GYpHM4czJMNJczI8OvC75BMZSFYMrZKjukZ+Auyd2OWWDyH2dJW3ZdU6oUA0Hk57diTyHNAenuTaq9zA/TM1TLAE4ztpSZ0lLjAK7ecLu6EhH0zyuvr7tbMedjqZcgdJhBQ6+T276JrVCJGjjLN+J7BWDFfWVket5CoxTvtnNfhQTmlLcinVuSFo4qUdxnQcC75YeyBVXSsiw6d3hk3q+JzBLlu2MrJZVeTJcSOq+L9SxqDISGWeAtb5OOdNYAgm70JOgp CpIvEYWj V3wscWlKnNElLIhGFA5lyajqUAt/uFsqSHCBnMB75Dee0KpxqPszJNWJ5TdjjxW88Vs+27n2/8TSUF6P8m5zmGtfXync+v88XmalnLnd3TmvWKHYZ58OSNBHr7Qal67QqdL9gj2bbAct+Tnul/yoZYYUirDU6RAvHeylDWgcVr2z3ud8GZg8xVRh/WdONA3rJ7gAE9c3oFyn54uyhAlL4zWKv8AqtTOtMwoonc11BAeNAt1H7cQQ3h8TQvMjOAryWJWqpIq5xBKheDIKACPdb3aBuIXYEwaz2E1V/el8DKep47VVyPl93Q/0CueDLJn7m2eRFbv26muecUnrgAaui7inu5nVSlXvpHmnHYDGlCGoooSHZuluKRyeil8AB9t/ruLnDi6Bbsx0xPEyjQe4yKiuc47WFL9cAdCkuOcYNsuYWQqBykYpWMNUQQDDCcAs/XFW1t5nBC340btf4TYp6H15vn4SQDT3+C5yc4/IvIkRi3B5REgTcH4rOtcTanGWawKLheNf8vTFDHfYRZoHI20FBOexQB7sFDh7Zs0u863dpbLA+NWwkFB4nxCQckdnYivWlxwDPamK3qyJQ8LykQtnAVPczaO6DAROMr3Crl6ymeGhmfF0mvHSwBA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000023, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 19 Sept 2024 at 08:35, Christian Theune wrote: > > Happy to! I see there=E2=80=99s still some back and forth on the specific > patches. Let me know which kernel version and which patches I should > start trying out. I=E2=80=99m loosing track while following the discussio= n. Yeah, right now Jens is still going to run some more testing, but I think the plan is to just backport a4864671ca0b ("lib/xarray: introduce a new helper xas_get_order") 6758c1128ceb ("mm/filemap: optimize filemap folio adding") and I think we're at the point where you might as well start testing that if you have the cycles for it. Jens is mostly trying to confirm the root cause, but even without that, I think you running your load with those two changes back-ported is worth it. (Or even just try running it on plain 6.10 or 6.11, both of which already has those commits) > In preparation: I=E2=80=99m wondering whether the known reproducer gives > insight how I might force my load to trigger it more easily? Would > running the reproducer above and combining that with a running > PostgreSQL benchmark make sense? > > Otherwise we=E2=80=99d likely only be getting insight after weeks of not > seeing crashes =E2=80=A6 So considering how well the reproducer works for Jens and Chris, my main worry is whether your load might have some _additional_ issue. Unlikely, but still .. The two commits fix the repproducer, so I think the important thing to make sure is that it really fixes the original issue too. And yeah, I'd be surprised if it doesn't, but at the same time I would _not_ suggest you try to make your load look more like the case we already know gets fixed. So yes, it will be "weeks of not seeing crashes" until we'd be _really_ confident it's all the same thing, but I'd rather still have you test that, than test something else than what caused issues originally, if you see what I mean. Linus