From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D68A2C43331 for ; Sun, 29 Mar 2020 16:46:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 94DE82073E for ; Sun, 29 Mar 2020 16:46:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="g7rnQkhE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94DE82073E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1329D6B0010; Sun, 29 Mar 2020 12:46:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E2C16B0032; Sun, 29 Mar 2020 12:46:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F13096B0036; Sun, 29 Mar 2020 12:46:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0107.hostedemail.com [216.40.44.107]) by kanga.kvack.org (Postfix) with ESMTP id D9F9D6B0010 for ; Sun, 29 Mar 2020 12:46:41 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A1FD6181AD0A3 for ; Sun, 29 Mar 2020 16:46:41 +0000 (UTC) X-FDA: 76648978602.10.face46_3a66399b11711 X-HE-Tag: face46_3a66399b11711 X-Filterd-Recvd-Size: 5229 Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Sun, 29 Mar 2020 16:46:41 +0000 (UTC) Received: by mail-lf1-f68.google.com with SMTP id c5so11997144lfp.5 for ; Sun, 29 Mar 2020 09:46:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EmVYX7es8ikrGBUh2sSl3Td6n0rszMJFDKO3y+3mky8=; b=g7rnQkhER3y3SD2ZzxZ3aRB5SfzXVM+Uw2aQfsZ8/BGY2bNnDCVo8qjREpSxUCZRml eKISJTrOfqSfG7e/4O5EQ/q70AtNCDAxrBN5cGYCcp4NGIjkfhjokSgDvlGctaCRXPYY m+KJtzoAHTSlypi0B5K1xPDAQqJvWdQveJanw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EmVYX7es8ikrGBUh2sSl3Td6n0rszMJFDKO3y+3mky8=; b=KOXhUEEUc5vL35Vw301UU3bkVMJg0xUNy3o6JOFEw4l9PUqi4Wq1Oxm0NNHMHFbYrZ VS9TGsLoK9ZgQMLnYczlY76LoUnyhP/VUPPuM/juqFc0gSo7QbJ/eF9qFkiLf1B3PcRV 28DdeQYDkTyzJmZCUhyEPeCtthYoRzw1b4oRKH0p7pZ6UDiRpRCMCQTAN63WzBC7a/pq qDNetmiTpcn1A4KayjyE0q2nRHYEfc0CXX2go7kJlhiJB6xUopR8Ejax/nApK16+h0sB 1giKFx27TgSH7gxl9uyR4Lc4xPrGoADjP46Rh3GclfL/ETF1Dc87N8N7OcZlnO5jQxM8 Bqtg== X-Gm-Message-State: AGi0PuatIzh9Ts/jgSxNJcW6n5Nofgah96aBolS3Uyfv8PZD1e+HPRQT VGMm6xlGTPj4aC7ecwXJiG8ubok/AN0= X-Google-Smtp-Source: APiQypJVnbQxczxg105XYxrwi4E07HIVllm3ly9CpWUji2OpLOOR9Mmljdi/MCiuPFTqMsJ4ekgiHA== X-Received: by 2002:a05:6512:3195:: with SMTP id i21mr5678413lfe.186.1585500399375; Sun, 29 Mar 2020 09:46:39 -0700 (PDT) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com. [209.85.208.169]) by smtp.gmail.com with ESMTPSA id 28sm6494253lfp.8.2020.03.29.09.46.37 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Mar 2020 09:46:38 -0700 (PDT) Received: by mail-lj1-f169.google.com with SMTP id w1so15341863ljh.5 for ; Sun, 29 Mar 2020 09:46:37 -0700 (PDT) X-Received: by 2002:a2e:a58e:: with SMTP id m14mr4810781ljp.204.1585500397555; Sun, 29 Mar 2020 09:46:37 -0700 (PDT) MIME-Version: 1.0 References: <20200328191456.4fc0b9ca86780f26c122399e@linux-foundation.org> <20200329021719.MBKzW0xSl%akpm@linux-foundation.org> In-Reply-To: <20200329021719.MBKzW0xSl%akpm@linux-foundation.org> From: Linus Torvalds Date: Sun, 29 Mar 2020 09:46:21 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 2/5] drivers/base/memory.c: indicate all memory blocks as removable To: Andrew Morton Cc: Dan Williams , David Hildenbrand , Greg Kroah-Hartman , Heiko Carstens , Karel Zak , Linux-MM , Michal Hocko , Michal Hocko , mm-commits@vger.kernel.org, ndfont@gmail.com, pbadari@us.ibm.com, Rafael Wysocki , rcj@linux.vnet.ibm.com, stable , steve.scargall@intel.com Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Please, David H - whatever you do with email is WRONG. Fix your completely broken email client. Stop doing this. On Sat, Mar 28, 2020 at 7:17 PM Andrew Morton wrote: > > From: David Hildenbrand > [...] > According to Nathan Fontenot, DLPAR on powerpc is nowadays no longer > driven from userspace via the drmgr command (powerpc-utils). Nowadays > it's managed in the kernel - including onlining/offlining of memory > blocks - triggered by drmgr writing to /sys/kernel/dlpar. So the > affected legacy userspace handling is only active on old kernels. Only ve= > ry > old versions of drmgr on a new kernel (unlikely) might execute slower - > totally acceptable. > > With CONFIG_MEMORY_HOTREMOVE, always indicating "removable" should not > break any user space tool. We implement a very bad heuristic now. Withou= > t > CONFIG_MEMORY_HOTREMOVE we cannot offline anything, so report > "not removable" as before. Notice the bogus MIME line continuation left-overs? [...] Only ve= ry and [...] Withou= t is just completely wrong. You either have a completely broken email client that doesn't handle MIME at all - get rid of it - or you're then dealing with raw mbox data in a completely broken manner without handling MIME wrapping. I can't figure out _what_ you're doing wrong, but the pattern is clear by now: it's not Andrew (although Andrew should check explanations better!), since it _only_ happens with patches from David Hildenbrand. Fix your workflow. Because it's broken. Linus