From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42265C4332F for ; Sat, 10 Dec 2022 17:44:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E2128E0003; Sat, 10 Dec 2022 12:44:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 46B0B8E0001; Sat, 10 Dec 2022 12:44:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E52D8E0003; Sat, 10 Dec 2022 12:44:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 161B48E0001 for ; Sat, 10 Dec 2022 12:44:37 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DA3BB8013A for ; Sat, 10 Dec 2022 17:44:36 +0000 (UTC) X-FDA: 80227121352.17.D18DA9E Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf30.hostedemail.com (Postfix) with ESMTP id 257CA80018 for ; Sat, 10 Dec 2022 17:44:34 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=DhDjZoxd; dmarc=none; spf=pass (imf30.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.160.176 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670694275; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yTAoatGwOoXnt0vQAJ8NuajE2zV18J1XkTsw0egALjs=; b=mweFNKCUN9Dla5WiB6FV2oPDiNwiO9VcAt2TEEqQIBLmhJC49nk92010HaPqBl7VIuMBJQ QJCToZjzAQXoeAHrxdH1WeaLhj2C0K3BBvPhj+06h0NMD6/odbjSGJUlVicfTiby5U/z0Z cTCnCd3oOS7o51j8amRsTa9KleMstqU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=DhDjZoxd; dmarc=none; spf=pass (imf30.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.160.176 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670694275; a=rsa-sha256; cv=none; b=NlGE/NJOaGMLFxuCQDzqb7/9jzKRnv6LtpkbDjUUVtEpIZ1m5AvFzWt6UUyxQ4yUFR8TP2 DEpeXLPrwzL88XTkKpS055jy5YB0s7nVz9NJGI0fL5CoaFsjlCsDjaw85dv34Ob1LN3ck8 G23ZwpPStw+J/2MrPFcPaVZxxNClHlE= Received: by mail-qt1-f176.google.com with SMTP id s9so5703632qtx.6 for ; Sat, 10 Dec 2022 09:44:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=yTAoatGwOoXnt0vQAJ8NuajE2zV18J1XkTsw0egALjs=; b=DhDjZoxdz/5wNDtWgkb/FJvzeWi+Ru+CPUwRY4m2jsJbXhQIK+aTEcFAgEBdVrOaCS 2lNvie5rtdm83NkEwCPxyCGZsdtRDuOYr1urmL6qyUI0JMzm4IKdoRz7exVViAA1JFC9 4e+YSaiquqNKG1rgCzEKpDBCjQ/ky2qjAOgF0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yTAoatGwOoXnt0vQAJ8NuajE2zV18J1XkTsw0egALjs=; b=xVffIHCZnIFpXtDXRQWordWT2jSd+6Xu/CB/rH8iJ5OgeJR8TePl/E6ZA8dhpZdmmc 6AifglPCTo11GUIDLBXik1OGMS/3kgIrkpTfJA+Xs/zFMAUWO+7dJ3qGgjfTh+H5q8lS JcILa2EVz0GYcM1c/Lz+swFaUZhnYDD+jHojUTqxOYyhAit52Mff/ebbkvT4B12QYavD OhoOG6ljMPW18M66aj+RJqU/JCygtEJBW6gXODpVYLdbJkC9Uz7Ee/07kqJ0GScL9j7c gkWncAQX4G5nzf7CkLStgNycCDJ6RaChhXRHb4/cRcIWuWLCy0WEHHHE1hB2HV9B98ZW r5mg== X-Gm-Message-State: ANoB5pkCB3JafLXe/w8wt5hEUSDS6sKfNvElZEZM9oArggJSP7HCxpIF 4y1MgvxwRSJscuZbD/exZ5+O3rG8OowdPqgy X-Google-Smtp-Source: AA0mqf7z9SXFQN48tPrDe4sWO5oR55hVkbaPJupgNKcd7Gy5rEXGhik8FLjypTNQ6Iti8lGK+oiDtw== X-Received: by 2002:ac8:7610:0:b0:3a8:3d4:f14c with SMTP id t16-20020ac87610000000b003a803d4f14cmr9656879qtq.5.1670694273877; Sat, 10 Dec 2022 09:44:33 -0800 (PST) Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com. [209.85.219.41]) by smtp.gmail.com with ESMTPSA id y6-20020ac87086000000b0039cb59f00fcsm3053254qto.30.2022.12.10.09.44.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Dec 2022 09:44:32 -0800 (PST) Received: by mail-qv1-f41.google.com with SMTP id mn15so5327397qvb.13 for ; Sat, 10 Dec 2022 09:44:32 -0800 (PST) X-Received: by 2002:ad4:4101:0:b0:4b1:856b:4277 with SMTP id i1-20020ad44101000000b004b1856b4277mr69940715qvp.129.1670694272567; Sat, 10 Dec 2022 09:44:32 -0800 (PST) MIME-Version: 1.0 References: <9f6a8d1a-aa05-626d-6764-99c376722ed7@kernel.dk> In-Reply-To: <9f6a8d1a-aa05-626d-6764-99c376722ed7@kernel.dk> From: Linus Torvalds Date: Sat, 10 Dec 2022 09:44:16 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] Writeback fix To: Jens Axboe , Jan Kara Cc: "linux-fsdevel@vger.kernel.org" , Linux-MM Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 257CA80018 X-Stat-Signature: 5aeyy1ok3pqwtmn6gpnjhz6wdcykqfe3 X-HE-Tag: 1670694274-158446 X-HE-Meta: U2FsdGVkX1/WdkjBp9OdHX7yQZlurazvXYMqPejwUv4ptiqKIK4b0uXKSRs3vZH8XT0aJJ2NWT/mU8YfW5nvMDmXjqLzBcdCnVStFV03GSnE0ZZNcxY4BJxS4pES9ZWpokRchpNtikWQ+nPsbqt/jeUV6Hhk9aNaaCQlnqQAkz+VJoKBWD2Wqj8xLiF8DWn8XCS64zPoNSDHbux+hsx/hKOsiVQKmoVonoisbBVcAhkRpULllHW+2lNZxrN2evzh3ExWZ3A7hj5bMjgXE0QP2z7jNVTAsx9FsQB2lsKXGZa6MhcitAIrLiOLmSPK+m2yeJVOdOLTJYFs26s3SkW69sbaUzXwLnV2W2JGTcwMSI81VxFOi7z+ojSqrA2rPvVUxtRYUcDgX2fHvYJlb6+zYCjqmYBlue8BmyjoJ8ScMtq58jX8JvmSjszjv3roCRhC/ivbhag6Aw6RL4SBSneV2Fw3PkKFBQYZ+0lG2EFlEshm96qjPhswucLObPzbtBgXAlNK0cw0A2J8lBFUOvpRmah1aK0oaE2ifRkZQ/pbrAj7MQbR0DJ+NAWunZLrjjp35vuZPVQU2be5bNeU8Q9p2s96x4Rlt/KpTrleRrfzTJN0j9LTdCyQiwfnoARDvTYg/RudRi9EZH4CPFEdDOn7lGP0rk+jrrvjSgZU1DKw6BC9HuUVAygslt2ABTuZKalWrf5BuKHMFMM6zaNFc+D+r+dm8puKa471uXHnK8WEqUvMXgYSWIKgZ13GUuJyFk2MpBpCKLZavUkK2tltNXFvHqjCbmLdaynOt9WVMj0krCb7zZPmcqMNY5wJIc7gzbjoebMrMHHOjqW/Z9R448aPrA9+WwmuwI6lFhkxJ/Y9+fvvCVArM3wo19glWDAe7/xVhWA7Mn8HNe7IkjbGjoLqf2JFrw7i3STH6wjjV59YQ0h1b0Thvwm/VlU9H6L7ZRLPAJgxXpbVPkuXdHWeXhr RL5b7uaU V6v9hgMbVkMBBUKQh1UVBnpbo33W3DBshlMUwFiIzYmszK7icDgwRvFl+DvPvjB4C1gyC+pZzsQ8ym55Ldn8TSftZriMGa8XHGrMXoc0X7p/aBKAHfD/tRGWD50mccRzYk8qJ2n9k/hKkLPWRRSV0P32mPevyXy1FbvjOrQHu/Wg5hO0HxHRoJzVrk1LtawhaJTrmy9IChhxPUYxb/StoYOQ3JG8leYOBqWyJOF+yubdP56n55IxMrbQR55traKiPKabaRRMUJmMLlvHGU10aUgDJJZ/36X1FK3ZG9h1/SRRhrArR0CEgskz8yCLB9ALik0IkwVEDAFVylHQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Dec 10, 2022 at 7:36 AM Jens Axboe wrote: > > Just a single writeback fix from Jan, for sanity checking adding freed > inodes to lists. That's what the commit message says too, but that's not what the patch actually *does*. It also does that unexplained + if (inode->i_state & I_FREEING) { + list_del_init(&inode->i_io_list); + wb_io_lists_depopulated(wb); + return; + } that is new. And yes, it has a link: in the commit message. And yes, I followed the link in case it had some background. And dammit, it's ANOTHER of those stupid pointless and worthless links that just links to the patch submission, and has NO ADDITIONAL INFORMATION. Those links are actively detrimental. Stop it. I just wasted time hoping that there would be some information about why the patch was sent to me this late in the game. Instead, I just wated time on it. I pulled this and then unpulled it. I'm very very annoyed. This patch has an actively misleading commit message, has no explanation for why it's so critical that it needs to be sent, and has a useless link to garbage. Fix the damn explanation to actually match the change. Fix the damn link to point to something *useful* like the error report or something. And STOP WASTING EVERYBODY'S TIME with these annoying links that I keep hoping would explain something and give useful background to the change and instead just are a source of constant disappointment. Linus