From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 635F6C64ED8 for ; Fri, 24 Feb 2023 20:17:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7BF276B0071; Fri, 24 Feb 2023 15:17:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 76E3F6B0073; Fri, 24 Feb 2023 15:17:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60E5A6B0074; Fri, 24 Feb 2023 15:17:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4C5C66B0071 for ; Fri, 24 Feb 2023 15:17:12 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2280780DCD for ; Fri, 24 Feb 2023 20:17:12 +0000 (UTC) X-FDA: 80503294704.08.B180CD4 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf24.hostedemail.com (Postfix) with ESMTP id 1BA1D18001C for ; Fri, 24 Feb 2023 20:17:09 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=PNmzsJlY; dmarc=none; spf=pass (imf24.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.53 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677269830; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oIjZaVoTVRiYI2EI9MNfmYEqGX+2eYmslPvrV4hb04Y=; b=F1yuGoidIo2HSMhy8XlH6edHoYZpbTCDyOp0oNmBd71jlq4xcX+iOxSNGIpUgWyYPZKyCT 3IW0AuJlWApYj0EvDyx6NWiButU/DsMDbWAsZ7RQn5+38vc90VQvKaiiWhO71CiHABdqau iHCcs5pQZrzL+MVUgfUlFk8KPkjxOAk= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=PNmzsJlY; dmarc=none; spf=pass (imf24.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.53 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677269830; a=rsa-sha256; cv=none; b=TytXrrJGzXV3Id/vu75DaNmyxJcbFQsgdMmxcjzdaX0oX6jkWQOHaHuJ9qTW/vCN1z4OXq mpXTrPZmnpbkaanbTmgi68z02dxH5S2lge0ZavBz5pHY+se+4ebIdNSn2A1UutaAX1/rIz MunECIEWtpGnKZm/6TRMoXrZJsQaEGY= Received: by mail-ed1-f53.google.com with SMTP id x10so1755866edd.13 for ; Fri, 24 Feb 2023 12:17:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=oIjZaVoTVRiYI2EI9MNfmYEqGX+2eYmslPvrV4hb04Y=; b=PNmzsJlYLy+1uKOxvOEqIIXYgWt88eDr+EceyU7mtzyAvlN5COX5huKkWnRJM3He38 SLW8PKiw6XnfBYKZ6DNhjirmDKps4/6eUrx3gFw/GVsGHfzH3B+BLCA2pQ0TWezNZPOv spT1BQ0QU4eREUNc1HOHpnJ4apcNtTyrTrOCo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oIjZaVoTVRiYI2EI9MNfmYEqGX+2eYmslPvrV4hb04Y=; b=gvFyANN6gGC251ICMzoIAqlFb5kAdoHiYh1FRXOn+TUjZUh8gDXGQmI4JVofotIvhT 0dxH8UFQlR5/qGDMjF8PdzGcNN+XnK1Lt5NhJntdlWcCgmjqlV1RJcc5Bbj65OciVz3D 2EPynyal+FiW6FRX8M31Zbs/GCuE32CSHaTWWZ/RBjyd1u18NmsW6bhcRXQam0V1DlaV JSZPRrHTbmzdKiAlgZf0FJTn8sTc3Eb9ziLyGIUOZIo3r6bnWwqLImaPxWl3B2h4qgKi E75Y2idz7Vj+Ch++Uz8snlkzh8u2OAtEzvFTGxUR0aYpFRunWfKAjXWvu6uvU3RIGJwB eZ3A== X-Gm-Message-State: AO0yUKXPcDgymUQvi/gihjb5SYg+H6wgsw13Ytwq9AerKFId/ZzQwoLE y+Y8wx1M6d3zEV0vbe/zfkYVOyOsrnCfgFl2RUc3RQ== X-Google-Smtp-Source: AK7set+Pkg/P802VNvfhWfsKXHvmJTPRUgA7YluHRnklVemYadlY6srrpEN/Oxs3oFjJMbHfMf7BPw== X-Received: by 2002:a17:907:8b89:b0:8b1:7891:19e8 with SMTP id tb9-20020a1709078b8900b008b1789119e8mr29248604ejc.44.1677269828403; Fri, 24 Feb 2023 12:17:08 -0800 (PST) Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com. [209.85.208.50]) by smtp.gmail.com with ESMTPSA id ga22-20020a170906b85600b008e82cb55195sm3352017ejb.203.2023.02.24.12.17.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Feb 2023 12:17:07 -0800 (PST) Received: by mail-ed1-f50.google.com with SMTP id f13so1903062edz.6 for ; Fri, 24 Feb 2023 12:17:06 -0800 (PST) X-Received: by 2002:a17:907:988c:b0:877:747e:f076 with SMTP id ja12-20020a170907988c00b00877747ef076mr11089353ejc.0.1677269826565; Fri, 24 Feb 2023 12:17:06 -0800 (PST) MIME-Version: 1.0 References: <2134430.1677240738@warthog.procyon.org.uk> <2009825.1677229488@warthog.procyon.org.uk> <20230220135225.91b0f28344c01d5306c31230@linux-foundation.org> <2213409.1677249075@warthog.procyon.org.uk> <2385089.1677258941@warthog.procyon.org.uk> <2390711.1677269637@warthog.procyon.org.uk> In-Reply-To: <2390711.1677269637@warthog.procyon.org.uk> From: Linus Torvalds Date: Fri, 24 Feb 2023 12:16:49 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC][PATCH] cifs: Fix cifs_writepages_region() To: David Howells Cc: Matthew Wilcox , Steve French , Vishal Moola , Andrew Morton , Jan Kara , Paulo Alcantara , Huang Ying , Baolin Wang , Xin Hao , linux-mm@kvack.org, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1BA1D18001C X-Stat-Signature: f5z4685idgefpnqncd36fd757kwzrp1i X-HE-Tag: 1677269829-421270 X-HE-Meta: U2FsdGVkX18PdPH1Ub1DSQaf/KJE2iTEYhKFcFYzfobzuw960FD2hYuEVyaHtQ6fhR65j1aNoJXH1L4zyrwpvRqjHhfSq4TeosAIuwoBbsJIoSJufjRjcKgqib6siEXQ0GQMXu5I/H/8RPyeIxpNHJESd9QmLlpncx7P9IJ/t1ePPbk6QiEQMwB+0ZgODzFjLJhO/Mza1gDeczuiz22kcdM+J9aT3AEUIYdMgJqGLTap6N5faJK2RVfLMe22V2MxnBlJEa638S4lO6P5cuHVGH9fF+PuZEVn+VMbrE7JTR391DkS4YJZMRDkcP5LNx8v1Q4TaFIDG09mUGv6gQ2Zu39IHgYLHX6FiQpkkvjvqNxf7kc7GFVEGBuwGzk7myEzDAXdTP4Vuiz+b7DLLoEjRY85A+4KHQ7AE2K1CMPPV5I4eaSkYBk3LZzcrlP2876sK9xMZ81u7TAUtdBs8n+1E3wLE4hodnKBdDkRZ40m/PQLhPWL42r+1TVBmb9WrGocXo2XbKwyqR2rB7WqnBxfZyGC+pf94XFpelHbrrzEpTxrH/sV//RCiyKyqhCpxSG8GyGdzFR/GMUKVMRNvRIUT+s5vAJY1E36H3V7nb9kdEUsLIlFA+vg2Um/NzSjKcV9QOgY3zCBlIPAx3RXhrJ73x7iXW9HAO+p5114FzUwtmZradEDJPbtgrrX6AhmoeVZ6KV0LDoWKFhqTW/mu6eUeBzyCzvfhpRtdOh5P/4jObqPIQ0fky4YtKg9RZMFecMBU7J0cf6ObZcODdwdW9VU4dde5/qW/sNXIFVl7e7f0NTLEV6FrSOFLBHreBvOev6FnMuIJR1FPPU2nfqYeom5GbTRUbDjnH92SLvcuz0ILudaIxMiZmZUPV79RAvNc18hCC0yxGgC6aeqX1gEVR+NPlu87GvGUuMVleBRiRBYrUfpmSQrzG+HqAXqRI4yWPKOePUSo7K4SbQSmAH+iKt jlHR4s3X U4U/SOSuFVXSp1N6xsIeFx+KicP76FCSC1WmF6rVh/rJ9LgzosXhZcJ/n7WgiVzi5ebwitqVN6ZCUf+rX2CK9zpB3z2+SDVaMXQ2XdEXpA8GSatyvFaLDmYKVYgnwD1jCOglEQT5FU/ZFwAjcbrss7zNWcRAaM7OpbvcVtt+hLHsyh0kCgPrKyYYHPDzsIGRVYvse/zeGpWbBRS83SyW4v2ZxFqG9AHZ7a1F9rbgdx1yq0ks9AZOzZEwsoVTfPJndIF/z9NprcCuBjEZ/qKg+l1WIHzlmC23hHBioyCEAU+451oY0fzmWZ2Cychxjh/bgfhF+x/ukVDckzby/uPpwmE8mz3hOEQdFF6vl4HvnsZtb9H4ieqU8BuLDQvrfcrpE7HvcK3YBTgWn4emzK5bw0UAKNrU9nobWIVZVT4gOnObGa+IEDWq4kVUUAT4rTKQhiRm47CHAODU1o6InWpQhOE3XyrrF/C83MB0Wnv4YDkRXl7O5a3Cf5SdabpXBk2Tn60Z/GeDJghehJr2iGZQWjDDR7UGkt4+ftHFNzoZUEiunefKh3Ey6xzrpJRYXfVNjddXJ41Js4ISmE80X5Wu9WjP/enQnF5GLXgu7H8eFL+fkhWmu8s93EYDEBw1X3tikMi5mWOonY0iMROZCOAsVyqU8qg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 24, 2023 at 12:14 PM David Howells wrote: > > Then why do we have to wait for PG_writeback to complete? At least for PG_writeback, it's about "the _previous_ dirty write is still under way, but - since PG_dirty is set again - the page has been dirtied since". So we have to start _another_ writeback, because while the current writeback *might* have written the updated data, that is not at all certain or clear. I'm not sure what the fscache rules are. Linus