From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02D6AC433E2 for ; Wed, 15 Jul 2020 22:58:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 810EF20656 for ; Wed, 15 Jul 2020 22:58:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="MBC5vtMh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 810EF20656 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BF7306B0006; Wed, 15 Jul 2020 18:58:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA84C6B0007; Wed, 15 Jul 2020 18:58:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A95F06B0008; Wed, 15 Jul 2020 18:58:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0153.hostedemail.com [216.40.44.153]) by kanga.kvack.org (Postfix) with ESMTP id 933E36B0006 for ; Wed, 15 Jul 2020 18:58:10 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 170D92DFA for ; Wed, 15 Jul 2020 22:58:10 +0000 (UTC) X-FDA: 77041825140.02.news86_0e0b71c26efd Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 0314620003AA3528 for ; Wed, 15 Jul 2020 22:58:09 +0000 (UTC) X-HE-Tag: news86_0e0b71c26efd X-Filterd-Recvd-Size: 4406 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Jul 2020 22:58:09 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id e4so4694933ljn.4 for ; Wed, 15 Jul 2020 15:58:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4fXMEPU6gAVBWg6IQ+xECv6MLETWbdcbr7WGd26o3dM=; b=MBC5vtMhzWJZZ9GjdJtx8UdDPaGZja6xgYIgmlwDQwU4kEQhcF0AjO17QURILiA/4B tQiejDuF2CcqHQwQcyUdPx4syUjjnCAfwoSBapL59fT69dyD/l2/35n4JLhu67HZ3Ncy hH2PMCUltb52qLOa2NBW/07krGkLSfwM2sCDQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4fXMEPU6gAVBWg6IQ+xECv6MLETWbdcbr7WGd26o3dM=; b=uWWadbVgc4nemDtxSt/581oNxVS3am26JkVe0l6uXOf1MHxP771OxYxkRF1/QMiSV8 qLrh5FZ5LR6c8tJSU9RqAV+hBgZUmkv931aX/hxlH87b6tcI/9vCJ8ZdpxY8C5LF1S4y A5iFYLooLO1SsIPAFXPoUR4wJW7nmJIfHvmOIhnpsMaMthP5/70g21A99rhoKe1bOrSj a2LRolpLdMCh67HUbdK19n+dIN4diEn3scrtBbegRZcZMk1n3wigfZyZnDgZsxmileIh P2PqahaFFmwZuafJfd4dGEaEV8vh8j4Uk28crq6uN/1lekaSPT/GbQgKhuSVLIdFO2p7 Bn7A== X-Gm-Message-State: AOAM530SeocjNwar8fSoE3aAy15U/elx5d+b6G3E0Ls8VTWH55f3p+9G ZoSdJedcOqnsneoS7HfR584O5WjSYFI= X-Google-Smtp-Source: ABdhPJw2rvpnqgM5eDE5qg/2HAllRf13sAubNJkQ3ft/PJ3XE967PMuQQd70UWNQkw3Emap64crJhQ== X-Received: by 2002:a2e:8882:: with SMTP id k2mr570798lji.352.1594853887725; Wed, 15 Jul 2020 15:58:07 -0700 (PDT) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com. [209.85.167.45]) by smtp.gmail.com with ESMTPSA id e24sm671469ljg.18.2020.07.15.15.58.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jul 2020 15:58:06 -0700 (PDT) Received: by mail-lf1-f45.google.com with SMTP id i80so2067426lfi.13 for ; Wed, 15 Jul 2020 15:58:06 -0700 (PDT) X-Received: by 2002:a19:8a07:: with SMTP id m7mr608455lfd.31.1594853886124; Wed, 15 Jul 2020 15:58:06 -0700 (PDT) MIME-Version: 1.0 References: <20200715135011.42743-1-kirill.shutemov@linux.intel.com> <20200715205428.GA201569@google.com> <20200715222228.jf2pv5u2wyhtc5o5@box> In-Reply-To: <20200715222228.jf2pv5u2wyhtc5o5@box> From: Linus Torvalds Date: Wed, 15 Jul 2020 15:57:50 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCHv2] mm: Fix warning in move_normal_pmd() To: "Kirill A. Shutemov" Cc: Joel Fernandes , "Kirill A. Shutemov" , Andrew Morton , Linux-MM , Linux Kernel Mailing List , Naresh Kamboju , William Kucharski Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 0314620003AA3528 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 15, 2020 at 3:22 PM Kirill A. Shutemov wrote: > > Sorry, but the patch is broken. .. instead of taking up knitting - which I'd invariably also screw up - I took a look. Yeah, in addition to checking the vm_prev/vm_next vma's, we need to check the limits of the 'vma' itself. Because we may not be moving the whole vma. So the "extend upwards" can only happen if the end address matches the end address of the current vma (and vice versa for the "extend down" case). Then it would hopefully work. But now I've screwed it up twice, and have a splitting headache, so rather than stare at this cross-eyed, I'll take a break and hope that somebody more competent than me looks at the code. Linus