From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Joel Fernandes <joel@joelfernandes.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux-MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
William Kucharski <william.kucharski@oracle.com>
Subject: Re: [PATCHv2] mm: Fix warning in move_normal_pmd()
Date: Wed, 15 Jul 2020 15:57:50 -0700 [thread overview]
Message-ID: <CAHk-=wgp-ZJ+J250DMaJFBDU2hnhUUqXcUnVnZZ1iFQEK6O-jg@mail.gmail.com> (raw)
In-Reply-To: <20200715222228.jf2pv5u2wyhtc5o5@box>
On Wed, Jul 15, 2020 at 3:22 PM Kirill A. Shutemov <kirill@shutemov.name> wrote:
>
> Sorry, but the patch is broken.
.. instead of taking up knitting - which I'd invariably also screw up
- I took a look.
Yeah, in addition to checking the vm_prev/vm_next vma's, we need to
check the limits of the 'vma' itself. Because we may not be moving the
whole vma.
So the "extend upwards" can only happen if the end address matches the
end address of the current vma (and vice versa for the "extend down"
case).
Then it would hopefully work.
But now I've screwed it up twice, and have a splitting headache, so
rather than stare at this cross-eyed, I'll take a break and hope that
somebody more competent than me looks at the code.
Linus
next prev parent reply other threads:[~2020-07-15 22:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 13:50 Kirill A. Shutemov
2020-07-15 18:36 ` Linus Torvalds
2020-07-15 20:54 ` Joel Fernandes
2020-07-15 21:13 ` Kirill A. Shutemov
2020-07-15 21:31 ` Linus Torvalds
2020-07-15 21:43 ` Linus Torvalds
2020-07-15 22:22 ` Kirill A. Shutemov
2020-07-15 22:36 ` Linus Torvalds
2020-07-15 22:57 ` Linus Torvalds [this message]
2020-07-15 23:04 ` Linus Torvalds
2020-07-15 23:18 ` Linus Torvalds
2020-07-16 6:37 ` Naresh Kamboju
2020-07-16 7:23 ` Naresh Kamboju
2020-07-16 8:46 ` Kirill A. Shutemov
2020-07-16 8:32 ` Naresh Kamboju
2020-07-16 13:16 ` Kirill A. Shutemov
2020-07-16 17:54 ` Linus Torvalds
2020-07-16 18:47 ` Joel Fernandes
2020-07-15 20:55 ` Kirill A. Shutemov
2020-07-15 21:35 ` Linus Torvalds
2020-07-15 21:51 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgp-ZJ+J250DMaJFBDU2hnhUUqXcUnVnZZ1iFQEK6O-jg@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=joel@joelfernandes.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naresh.kamboju@linaro.org \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox