From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 770B8C433EF for ; Sat, 11 Dec 2021 01:08:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A95BD6B0072; Fri, 10 Dec 2021 20:08:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A453B6B0073; Fri, 10 Dec 2021 20:08:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90D466B0074; Fri, 10 Dec 2021 20:08:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay031.a.hostedemail.com [64.99.140.31]) by kanga.kvack.org (Postfix) with ESMTP id 822B16B0072 for ; Fri, 10 Dec 2021 20:08:44 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 38F5721C88 for ; Sat, 11 Dec 2021 01:08:34 +0000 (UTC) X-FDA: 78903728148.01.29595CD Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf28.hostedemail.com (Postfix) with ESMTP id C7BFEC000C for ; Sat, 11 Dec 2021 01:08:33 +0000 (UTC) Received: by mail-ed1-f51.google.com with SMTP id y13so34564695edd.13 for ; Fri, 10 Dec 2021 17:08:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rG/BXP74osfka0lZ+Rh+ws4m8UkSBZoHRs2ELVshZSQ=; b=TlHQgM5ve++ZiBm6gzzs/QT4jG55kPzc8+VO6XXhpb7HzaajN6FSdjHy7iYLTphYMb IOLij3z8ftzgbhicY4qAZYOlZRksS+GUAq894g7FnWm9XMqwAx3QJQOP96yXAdTye7dO JOG7snUMttXkG8IRSPaOOegY11+zJgrr1tsWE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rG/BXP74osfka0lZ+Rh+ws4m8UkSBZoHRs2ELVshZSQ=; b=3030/PpiAIuZgYe30nMNLRypV9C4lQ++DyZNlp/2BEu5F6AmqhA2Ijeqth3dgLGjs3 F4vCdl/va1wRY9M1yHH46Rsog7FstHutXf/XvHLkF0lvQ4D1ASYId2BoXdCcAXIMd1Wq 3AalrgSeAdkPAMKFoyR1lEB+zZqd3vB6hK9oZZHNn2NVEFRg2vF9lBn1TnzcNq70h9pG Wyejia+z7T4lX4lKjgIHZw8IVWBgcKMHm7EyuU5UAo7TSpZ64fEz6ca1NNDqP75bkR+G xajyRnk3Cn7XlMSkV4soCo2fWff6tH9LD5Z3XBgYw+0Qj4tMdi3QNghMgGUqJcXVX9Tk 0wIA== X-Gm-Message-State: AOAM531nf79MqTKSiNB1J6l1PvCFhOqNZ/42D5zRlcv86AmwckwF+akg PXPes6XUSV5c2JF9oYKn09GKtf084GWLxkThIDI= X-Google-Smtp-Source: ABdhPJxN1eIg/8qpBgF9ZuXO9bc8hRN34PV9nGdeSCkkM4W3GYObSUqgC1WyURc5gAaCZbXcZAfiqw== X-Received: by 2002:a17:907:6291:: with SMTP id nd17mr28251585ejc.194.1639184912187; Fri, 10 Dec 2021 17:08:32 -0800 (PST) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com. [209.85.221.41]) by smtp.gmail.com with ESMTPSA id t7sm2305517edi.90.2021.12.10.17.08.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Dec 2021 17:08:31 -0800 (PST) Received: by mail-wr1-f41.google.com with SMTP id t9so17683395wrx.7 for ; Fri, 10 Dec 2021 17:08:31 -0800 (PST) X-Received: by 2002:a5d:4575:: with SMTP id a21mr18460564wrc.193.1639184910712; Fri, 10 Dec 2021 17:08:30 -0800 (PST) MIME-Version: 1.0 References: <20211210144539.663efee2c80d8450e6180230@linux-foundation.org> <20211210224609.9QkKor7T0%akpm@linux-foundation.org> In-Reply-To: <20211210224609.9QkKor7T0%akpm@linux-foundation.org> From: Linus Torvalds Date: Fri, 10 Dec 2021 17:08:14 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 01/21] Increase default MLOCK_LIMIT to 8 MiB To: Andrew Morton Cc: ammarfaizi2@gnuweeb.org, andrew@donacou.ch, Pavel Begunkov , Jens Axboe , Cyril Hrubis , David Hildenbrand , Johannes Weiner , Jason Gunthorpe , Linux-MM , mm-commits@vger.kernel.org, sir@cmpwn.com Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=TlHQgM5v; dmarc=none; spf=pass (imf28.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.51 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: C7BFEC000C X-Stat-Signature: j89kquigs6pa9rmus3ebyjg64xqi1ukd X-HE-Tag: 1639184913-280946 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 10, 2021 at 2:46 PM Andrew Morton wrote: > > -#define MLOCK_LIMIT ((PAGE_SIZE > 64*1024) ? PAGE_SIZE : 64*1024) > +#define MLOCK_LIMIT ((PAGE_SIZE > 8*1024*1024) ? PAGE_SIZE : 8*1024*1024) I think I'll just make this #define MLOCK_LIMIT (8*1024*1024) because at the point where it's that big, there's no point in comparing it against PAGE_SIZE any more. If some config has that big of a page size, all the rest of the kernel infrastructure would basically be screwed. We do a lot of core kernel allocations in one-page chunks.. Linus