From: Linus Torvalds <torvalds@linux-foundation.org>
To: Peter Xu <peterx@redhat.com>, Andrew Lutomirski <luto@kernel.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Josef Bacik <josef@toxicpanda.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
Dan Carpenter <dan.carpenter@linaro.org>,
syzbot+48011b86c8ea329af1b9@syzkaller.appspotmail.com,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] filemap: Handle error return from __filemap_get_folio()
Date: Wed, 10 May 2023 16:44:59 -0500 [thread overview]
Message-ID: <CAHk-=wgnHtP2uNtnFdQ4Ou-TZynipVVU5Jow+Fr8nhRgewkXAA@mail.gmail.com> (raw)
In-Reply-To: <CAHk-=wjKVXt+BAh+Gk+Cs9u8s=XzbQyzHhZSW2bPFMX74gPuRw@mail.gmail.com>
On Wed, May 10, 2023 at 4:33 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> We'd still keep the RETRY bit as a "this did not complete, you need to
> retry", but at least the whole secondary meaning of "oh, and if it
> isn't set, you need to release the lock you took" would go away.
"unless VM_FAULT_COMPLETED is set, in which case everything was fine,
and you shouldn't release the lock because we already released it".
I completely forgot about that wart that came in last year.
I think that if we made handle_mm_fault() always unlock, that thing
would go away entirely, since "0" would now just mean the same thing.
Is there really any case that *wants* to keep the mmap lock held, and
couldn't just always re-take it if it needs to do another page
(possibly retry, but the retry case obviously already has that issue)?
Certainly nothing wants the vma lock, so it's only the "mmap_sem" case
that would be an issue.
Linus
next prev parent reply other threads:[~2023-05-10 21:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-06 16:04 Matthew Wilcox (Oracle)
2023-05-06 16:09 ` Linus Torvalds
2023-05-06 16:35 ` Linus Torvalds
2023-05-06 17:04 ` Linus Torvalds
2023-05-06 17:10 ` Linus Torvalds
2023-05-06 17:34 ` Linus Torvalds
2023-05-06 17:41 ` Andrew Morton
2023-05-08 13:56 ` Dan Carpenter
2023-05-09 7:43 ` Dan Carpenter
2023-05-09 17:37 ` Linus Torvalds
2023-05-09 20:49 ` Christoph Hellwig
2023-05-11 9:44 ` Dan Carpenter
2023-05-09 19:19 ` Johannes Weiner
2023-05-10 20:27 ` Peter Xu
2023-05-10 21:33 ` Linus Torvalds
2023-05-10 21:44 ` Linus Torvalds [this message]
2023-05-11 4:45 ` Peter Xu
2023-05-12 0:14 ` Peter Xu
2023-05-12 3:28 ` [PATCH 1/3] mm: handle_mm_fault_one() kernel test robot
2023-05-12 3:52 ` kernel test robot
2023-05-12 3:52 ` kernel test robot
2023-05-12 4:49 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgnHtP2uNtnFdQ4Ou-TZynipVVU5Jow+Fr8nhRgewkXAA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@linaro.org \
--cc=hannes@cmpxchg.org \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=peterx@redhat.com \
--cc=syzbot+48011b86c8ea329af1b9@syzkaller.appspotmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox