From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B234C433E2 for ; Fri, 4 Sep 2020 18:36:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BD961206A5 for ; Fri, 4 Sep 2020 18:36:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="Ai5VYeCU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD961206A5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D523F6B0002; Fri, 4 Sep 2020 13:12:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D02008E0001; Fri, 4 Sep 2020 13:12:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC9B76B0075; Fri, 4 Sep 2020 13:12:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0026.hostedemail.com [216.40.44.26]) by kanga.kvack.org (Postfix) with ESMTP id A69196B0002 for ; Fri, 4 Sep 2020 13:12:20 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5CC158248068 for ; Fri, 4 Sep 2020 17:12:20 +0000 (UTC) X-FDA: 77226022440.01.hate72_5c000f4270b3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 139371004F928 for ; Fri, 4 Sep 2020 17:11:25 +0000 (UTC) X-HE-Tag: hate72_5c000f4270b3 X-Filterd-Recvd-Size: 4535 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Fri, 4 Sep 2020 17:11:24 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id m5so3337259lfp.7 for ; Fri, 04 Sep 2020 10:11:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LwSOZ3VxHk2DxOprDUCFltuLBh+Nnc13XxZ9vhv/VSM=; b=Ai5VYeCU8N0HEbW+IM5blqtlPgBAdGE7a3XFUEbRHQk5rk29NE1Y6tMiu2T/EMq17a oE42EL494zdqelcOJfkWDvC8gduDspSWRXtrBLodjT6PNtuIMZdw4lEZsKoERdT4+qfQ DzOZXMaeU+RmNmSqU9sHI/NrjQBcHXnvyzI6I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LwSOZ3VxHk2DxOprDUCFltuLBh+Nnc13XxZ9vhv/VSM=; b=T9oXZVe61VI4tlqV3RfTa/xD5UdeLoR/Cjkr/YOIwGK5SkQu2NQ8mIEq9T5NLbbm0M Oc4S/j89z6DieiMzGK1HcHySw6BWMNQQ5HGCw4y++N4fjmcDejkU7fzXtG+vSjcWqN5z 8wXNwEoLDIzSPlvg5VGsgmzGnCbzL4LAYHRwO6GYq4u58ogRRQVdt9CMxVOPdcYYDpDJ d24WHwzAcy0jqDHQVuCb2vmYoPm8yCHdISJvLYfUrAk8gFx2TOXHQjSSTaL8JNlb1BSG gQG/eVdguV/h488pHr3028TYh+j4oVi93XhqJ7h3d4nON6UN157V8Bu0IG8rNhKWf6so LsRA== X-Gm-Message-State: AOAM531Hel868Z5UDEEisIMuJMwtZQsDMlICmvf6ssXKz8phddtNdpTP riLsfJdfjXveAc+TrP5wrhQT4/ytRfSt3w== X-Google-Smtp-Source: ABdhPJw7lfCHkOSnUQGfBqXWauO4UI96JVo1s7MHxoI9TxMYd6bOhAe16o6Ebnw034MYLq2rSYjtMA== X-Received: by 2002:a05:6512:370e:: with SMTP id z14mr4339416lfr.80.1599239482891; Fri, 04 Sep 2020 10:11:22 -0700 (PDT) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com. [209.85.167.41]) by smtp.gmail.com with ESMTPSA id b9sm1323056lfc.8.2020.09.04.10.11.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Sep 2020 10:11:22 -0700 (PDT) Received: by mail-lf1-f41.google.com with SMTP id w11so4253764lfn.2 for ; Fri, 04 Sep 2020 10:11:22 -0700 (PDT) X-Received: by 2002:a05:6512:50c:: with SMTP id o12mr4298936lfb.192.1599239481877; Fri, 04 Sep 2020 10:11:21 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Fri, 4 Sep 2020 10:11:06 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: a crash when running strace from persistent memory To: Mikulas Patocka Cc: Peter Xu , Jann Horn , Christoph Hellwig , Oleg Nesterov , Kirill Shutemov , Jan Kara , Andrea Arcangeli , Matthew Wilcox , Andrew Morton , Dan Williams , Linux-MM , Linux Kernel Mailing List , linux-nvdimm Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 139371004F928 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 4, 2020 at 1:08 AM Mikulas Patocka wrote: > > I applied these four patches and strace works well. There is no longer any > warning or crash. Ok. I obviously approve of that series whole-heartedly, but I still didn't want to apply it this way (and with this kind of "mid-rc" timing). I was hoping to just leave it for the next merge window, but there are now two independent problems that that forced COW patch of mine caused, and a plain revert isn't acceptable either, so I've just applied that series to my tree despite the garbage timing. Maybe I'm just making excuses and rationalizing because I wanted that series anyway, and patches that remove lines in core code make me happy, but I don't see other great alternatives. Linus