From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C41A8C433DF for ; Sun, 18 Oct 2020 19:33:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3638C207DE for ; Sun, 18 Oct 2020 19:33:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="bmJ7Qv3P" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3638C207DE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 666CE6B005D; Sun, 18 Oct 2020 15:33:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 619E46B0062; Sun, 18 Oct 2020 15:33:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52F806B0068; Sun, 18 Oct 2020 15:33:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0104.hostedemail.com [216.40.44.104]) by kanga.kvack.org (Postfix) with ESMTP id 25C906B005D for ; Sun, 18 Oct 2020 15:33:44 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B0C008249980 for ; Sun, 18 Oct 2020 19:33:43 +0000 (UTC) X-FDA: 77386045926.24.jam47_461680927230 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 8D7211A4A0 for ; Sun, 18 Oct 2020 19:33:43 +0000 (UTC) X-HE-Tag: jam47_461680927230 X-Filterd-Recvd-Size: 4513 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Sun, 18 Oct 2020 19:33:43 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id y16so9103284ljk.1 for ; Sun, 18 Oct 2020 12:33:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QR2lTyB4kqjJ0dgLO32gMmBujTe2W265tkQsBiwLm/c=; b=bmJ7Qv3PwFXHarFlDRvJFXK6et3Oipsfk0JR6FiM9B6s6SPxGsg6maFfz3Hs4xyuz/ z8Ss2+9vc3Vha0I+8dcKq359kUYuRh6GWO3Gkp8DbmUE2LwKSXzEF5vPVzkH2Oor8mZE MVW10kpph4X9NMq97rxpPLi7qiCPzZr56C2xI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QR2lTyB4kqjJ0dgLO32gMmBujTe2W265tkQsBiwLm/c=; b=H6EFf2ptF6OgBx3dYW4vUajk5VJPsSFn0VqhPtldNPVhWKpUe9Qx9NqFhb1JWf3plJ SdREIMHT4SWfUJXE5vqLeqiyboGsAp+EtElLQ/tCJlYqM/IzXn5HMctXiZH6b/KD7cXR iwTf8TX2j4q0O3+w7KgjGdhHn8km5n7G0F68bKNo5P5ZhU99PYAuNhWtEpspHZR4j6PD EXnzQwj9UHxBvPa+YtO5B8rkgIIop/gr6z818cxVqFwX7rLrl/FcMpk75UF+NI+x5uVG ox9zbyZVEHRTPUgyEEpThtT4SyzfO5vMZLENalbQaDLYVacyy+1eBgQlkd09knl0UpCJ Ht0A== X-Gm-Message-State: AOAM533n8tLoIzh15W53/ZcVFDDNUbAt7e8cQBZrwio9xAsQEX8W/dZU C4FLnmxxs3WxjE7spu9gGrMPdwZGu0zTfQ== X-Google-Smtp-Source: ABdhPJyVCDt3bdccyCkzaSTxYgZZYDgIWj6OipCpfTQ2Z/YurfybliqQA9Unqjs45zz6S4pnLbQ/aA== X-Received: by 2002:a2e:9a43:: with SMTP id k3mr5697218ljj.69.1603049620960; Sun, 18 Oct 2020 12:33:40 -0700 (PDT) Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com. [209.85.208.178]) by smtp.gmail.com with ESMTPSA id o128sm2918001lfa.110.2020.10.18.12.33.39 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Oct 2020 12:33:39 -0700 (PDT) Received: by mail-lj1-f178.google.com with SMTP id m16so9074088ljo.6 for ; Sun, 18 Oct 2020 12:33:39 -0700 (PDT) X-Received: by 2002:a2e:868b:: with SMTP id l11mr5060044lji.102.1603049618706; Sun, 18 Oct 2020 12:33:38 -0700 (PDT) MIME-Version: 1.0 References: <20201017161314.88890b87fae7446ccc13c902@linux-foundation.org> <20201017231425.0OZYgQdDr%akpm@linux-foundation.org> <20201018190327.GN20115@casper.infradead.org> <9eaf122b-e877-e104-6175-13d48c13ac85@nvidia.com> In-Reply-To: <9eaf122b-e877-e104-6175-13d48c13ac85@nvidia.com> From: Linus Torvalds Date: Sun, 18 Oct 2020 12:33:22 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 16/40] selftests/vm: use a common gup_test.h To: John Hubbard Cc: Matthew Wilcox , Andrew Morton , Jonathan Corbet , Jerome Glisse , Linux-MM , mm-commits@vger.kernel.org, Ralph Campbell , Shuah Khan , Jason Gary Gunthorpe Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Oct 18, 2020 at 12:13 PM John Hubbard wrote: > > > > > Does adding an extra -I../../../../mm to that line not do the trick? > > > > Yes, that works. Here's a differential patch on top of the series to change it > over: Guys, you're looking at the wrong thing. Inside the *tools* subdirectory, that "../../.." thing makes sense. You're in tools/testing/selftests/vm, and those crazy ".." paths are ok. Ugly, but ok. But the thing I objected to wasn't that tools directory ugliness. Let me repeat what I found completely and utterly unacceptable, and what you don't seem to have noticed, and what your patch didn't fix or touch: +++ a/mm/gup_test.c +#include "../../../../mm/gup_test.h" Notice what directory it is in? Notice how "../../.." etc is COMPLETELY UNACCEPTABLE GARBAGE. Linus