From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A771AC433E3 for ; Wed, 26 Aug 2020 17:16:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 684ED22BEA for ; Wed, 26 Aug 2020 17:16:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="JGeqnKz6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 684ED22BEA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C58536B000A; Wed, 26 Aug 2020 13:16:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE2806B000D; Wed, 26 Aug 2020 13:16:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A846C6B000E; Wed, 26 Aug 2020 13:16:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0031.hostedemail.com [216.40.44.31]) by kanga.kvack.org (Postfix) with ESMTP id 8A0656B000A for ; Wed, 26 Aug 2020 13:16:04 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 459BD181AC1F5 for ; Wed, 26 Aug 2020 17:16:04 +0000 (UTC) X-FDA: 77193372648.16.comb21_4914fe027066 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 17614100E6912 for ; Wed, 26 Aug 2020 17:16:03 +0000 (UTC) X-HE-Tag: comb21_4914fe027066 X-Filterd-Recvd-Size: 3919 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Wed, 26 Aug 2020 17:16:02 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id 185so3243961ljj.7 for ; Wed, 26 Aug 2020 10:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OYDNjsWuANyuBcj1SPsmNo6ddbFkMTYQnNwN8I83N48=; b=JGeqnKz66cr/PGvxK95byYWGqp6m3jFBDNw2exQc8Tiv2/3rV7oeitqRF49c0TPmWt PfYOAUYDCFroSYr73H96pWaoUr7kushnS2cp61vwd6oqVPJ6ijM/SJNcl+K99LhgYPeW UrUvVlTKWW3lYTcZZ3AV3q2bwaalwx4rI+U2k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OYDNjsWuANyuBcj1SPsmNo6ddbFkMTYQnNwN8I83N48=; b=Gwhz1Bv2Ic5Wctqu8SOtd8qoyFgTeZu6LkfskvmjZ4Snwj9rp9W/zXj08aIZ1fSeZa dwkU2ddAhv1PDYv/EdVbLuDVtw+MhbLhTMp5LaeOtw4H16M2f27y+lMhzDQsD2QkGucI +2W77dVO1QaH4x4PVvycxvS2NCbWvdvdR45LyfTvT1TCEEfvqgMZL+ndSdhVu84vwiqm 9YZ0kngV2BYLlrAFwlChpUSuubNSty4rD3+bIe2SKvZqxT8TSZIraR+LR1cNU/VaI3by jBFdTx4y0beQeCQJ/ROkjbzMJpao7irGiVs+2f2LJCwT0v33dGZnJY256Yz9K3ZiDQFQ C13g== X-Gm-Message-State: AOAM5332IJVFsElRye2rav73lPDXZws3rvf6oIwbA3Ycfmxv0eKpaVjn Q/NG3NgiFNp/hHNKq+VWbCe8hGm+s0Tptg== X-Google-Smtp-Source: ABdhPJygRoj0SvvAqxB1X9w8Bvv3G2EYHA3g+eXy3a2ABTGuZF1BMQ8+UOeVKScAcLmCiAmEtL/4Qg== X-Received: by 2002:a2e:b008:: with SMTP id y8mr6828161ljk.421.1598462160329; Wed, 26 Aug 2020 10:16:00 -0700 (PDT) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com. [209.85.167.42]) by smtp.gmail.com with ESMTPSA id e21sm697221lfc.97.2020.08.26.10.15.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Aug 2020 10:15:59 -0700 (PDT) Received: by mail-lf1-f42.google.com with SMTP id k10so1405931lfm.5 for ; Wed, 26 Aug 2020 10:15:59 -0700 (PDT) X-Received: by 2002:ac2:522b:: with SMTP id i11mr7933692lfl.30.1598462158792; Wed, 26 Aug 2020 10:15:58 -0700 (PDT) MIME-Version: 1.0 References: <20200826151448.3404695-1-jannh@google.com> In-Reply-To: <20200826151448.3404695-1-jannh@google.com> From: Linus Torvalds Date: Wed, 26 Aug 2020 10:15:42 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 0/5] Fix ELF / FDPIC ELF core dumping, and use mmap_lock properly in there To: Jann Horn Cc: Andrew Morton , Christoph Hellwig , Linux Kernel Mailing List , Linux-MM , linux-fsdevel , Alexander Viro , "Eric W . Biederman" , Oleg Nesterov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 17614100E6912 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 26, 2020 at 8:15 AM Jann Horn wrote: > > After this series has landed, we should be able to rip out > mmget_still_valid(). I think you should just add that to the series, since it's kind of the point of it all. But ack on this, it now looks saner than what we used to have regardless. I do wonder if we should possibly just limit the number of vma's we dump based on core size ulimit too, but that, I think, might be a "further improvement" rather than base cleanup. Linus