From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBDA3C47258 for ; Sat, 20 Jan 2024 16:40:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7AFF26B0071; Sat, 20 Jan 2024 11:40:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7386E6B0074; Sat, 20 Jan 2024 11:40:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B2996B0075; Sat, 20 Jan 2024 11:40:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 455416B0071 for ; Sat, 20 Jan 2024 11:40:32 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id ED16EC085B for ; Sat, 20 Jan 2024 16:40:31 +0000 (UTC) X-FDA: 81700252662.01.2DDF5B5 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by imf04.hostedemail.com (Postfix) with ESMTP id EB3FD40003 for ; Sat, 20 Jan 2024 16:40:29 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=P061d8Yz; dmarc=none; spf=pass (imf04.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.42 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705768830; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lKz6ORL5rgrlrEyJEOMpjmvWzW5nRmmd6FHj6yauGbM=; b=b/un3H0Lq6TlJKbEst0MocPeZd1ZDGgMXVgeQSQdmhSSLC0ZuAruTYLfvkpI9dNkfdv0wb 3NPJ6+U4QFwJRL6WWqbLU2xz0clGIx2ZYKVlPqv8WiStPnviG/oQelTVAUvuwdbHzw6/CD CGYYmknKW4alD6TYz7O9V3NJ2rYktpA= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=P061d8Yz; dmarc=none; spf=pass (imf04.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.42 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705768830; a=rsa-sha256; cv=none; b=2Zlq9Hpdqqz5P8TM73HgEU/4WQBe+YZJZDj/oOp/M6mwwAAWQdlRwq8vlntP4p1rgQZlOu xFHAnR8cHbRs8n+rfgEy+C29FK6fqjteBrz9E7xlMTYd7hQgW936ejW4bY14fSGT2WVdxK QKaJr33aZDVdBubDaxVn80hYAmp4BIY= Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a28b0207c1dso132949166b.3 for ; Sat, 20 Jan 2024 08:40:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1705768828; x=1706373628; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=lKz6ORL5rgrlrEyJEOMpjmvWzW5nRmmd6FHj6yauGbM=; b=P061d8YzrbhXmpUbe+WsJcdVLzj1G5TbcVkB3+Hw/xUcwMiWHBHVWtOynPAJ/auvL/ NxTpt6VYMxFpVH5cieEkxtMGvaNB7T0RhmLYYm5rGH5EA0YvkbMoSGsluQPzIyBnEJLa q5g0V0dw3ptAztCoLrFTh1MNLjJOX75EaYK8g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705768828; x=1706373628; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lKz6ORL5rgrlrEyJEOMpjmvWzW5nRmmd6FHj6yauGbM=; b=LLRNMQpQgR9plGCvUsmwgX/AhNvVwyQ0eq8/e0y+hGnz7Aj0alhPmaJ8X7D8RbdbKJ FgpLJ29FV5H9K2f/FQLKELjYiekvRFRRCS5nHFHLew2mZ4GkcwJPWfASiLP9fjNFlA7f 2RBmRiwQVHbBk7tBrrq8MlLCdmrjFhlk3u3t50k2XAnaQBFctkNCPmB9fROVPzF9fHB8 6I3NEqSccFQknZdX6SyF0FzyrgMfxD7ayfw1P5tJGQQYkYK1oYIfj0Y1jwbQ9XiiRIE3 aOSSidT5Dab8nPFs9XhLJsiypqL53H5aRq+ei1HPHzQTqtsCIK6S9DsGFteIeoV/uZNz 5LAg== X-Gm-Message-State: AOJu0Yz0GOw0l/dwOogQkh5Z2CxrQFO1jAOSTK6R70DZSeGlsItTJsZy u58yU1s18I8J9IfY90fjMu8vnPPDiX/9+I80im/RH8eFSVVTLPwThCGyi8jPyaCoRCZ7gR+IUQr FSSphAA== X-Google-Smtp-Source: AGHT+IETzzSZgotGWJW/PLEhbj/j9cgeUhRoaTpKHEj+vDXdbj1bkO1R5mThtWTIWJTPdxqMcsUi7g== X-Received: by 2002:a17:907:75cb:b0:a2e:556:f114 with SMTP id jl11-20020a17090775cb00b00a2e0556f114mr753061ejc.25.1705768828190; Sat, 20 Jan 2024 08:40:28 -0800 (PST) Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com. [209.85.208.49]) by smtp.gmail.com with ESMTPSA id k3-20020a170906a38300b00a298d735a1bsm11697430ejz.149.2024.01.20.08.40.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Jan 2024 08:40:27 -0800 (PST) Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5578485fc0eso1777365a12.1 for ; Sat, 20 Jan 2024 08:40:27 -0800 (PST) X-Received: by 2002:a50:8d56:0:b0:558:d206:3bba with SMTP id t22-20020a508d56000000b00558d2063bbamr704311edt.20.1705768827089; Sat, 20 Jan 2024 08:40:27 -0800 (PST) MIME-Version: 1.0 References: <20231212231706.2680890-1-jeffxu@chromium.org> <20231212231706.2680890-12-jeffxu@chromium.org> <78111.1705764224@cvs.openbsd.org> In-Reply-To: <78111.1705764224@cvs.openbsd.org> From: Linus Torvalds Date: Sat, 20 Jan 2024 08:40:09 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH v3 11/11] mseal:add documentation To: Theo de Raadt Cc: Jeff Xu , =?UTF-8?Q?Stephen_R=C3=B6ttger?= , Jeff Xu , akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, willy@infradead.org, gregkh@linuxfoundation.org, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, pedro.falcato@gmail.com, dave.hansen@intel.com, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: EB3FD40003 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 8fg8awpdyc7cbfui6u8bwg13swptjh8e X-HE-Tag: 1705768829-611425 X-HE-Meta: U2FsdGVkX18W8q2S4EmvtCknbJnw6tAfpYPY3WQaJelJTXz1WylplPrvrdt0mW+lXrPOquBwpGOsXAS4cf8TeTM8cOFOFDKDO0+Rt5bi27fueEFBZdpFbhIm+4qSqZiebs5ksZZRjan98ImYHXOE9BeMeYKcM5WFeSrJwx318ZJY+M05RvTDY3SosWxOQ5hihsSwntQCTImbIMeA4dskGW0aPbmK46uo4xpxpv319IHj1Jf1oNx6K+kKMwVCoWnnrGBIgLChY0Dd7lZ4AmO6Zxsa8maM20kRygYurCdOr/dfDJnB+P99at0Q7auQ6tcLxEGFFZMFN9ssHuLhH16jlXYTRG/c4/Ho3A2KhLq8Xb7Y2kqSfqEXeoBFFRtgVN9yBps6/oCWvnaGDEWOENCY97gywQ9lx1W2RGAKbvgLlH0JcTfAm2XCLthp8ze2ExJGlelC857EoAAR6zB12SvHa/fA4XqZ1eNmlKda1Ew5496eai+QwEy/3/5/1mZdxoZT4xyiWrJ+eovvIcxs9m1CVTX+QJldp3lDBGbP2cR5S1T1fWSUhBwlt7Jr+W4gjkUD5VQ/EMg26W0terydpTROO7FJeMYBIEtjguk3zPy0VyC4Gu6lp8CQlTaYL0BY9LNiFdLk3t+Rb5crY+BuC0Jyh6Gs/41IouxyxkP81tiqY3GayRpO864IY3J39HhMHpHu5Tpdma5JeWmr8EsTTsFlbjcksrxSO/pymBu+Bk0AICiJ7y9/OvwJ5n5riYvDt3aeYHZpn8CbdwmoEyfhG3zhtwgC+BFT3fMoAXazkHyzhN/e9Q37RQPp8nNZr6A2IsR/G4DzVaV9BcfDw24YQvaKqavM0Z2qm3IrbBI9cDG1O/rsvPYqBta3lXXkjP6hSyxwY2AJcBcGUIey4Fir237h7R1+a0uLWrEwqQZ2W2hFtoAIr+EMg+SCMxDQUUlElm97DtVrof7WaStgOf8W5DH 7+yyYvOF KPpitBHrRXaAh+tN5CQkXbkTX1dYCGUM64nZi+y7I65NIU3bl3TrCr2IegsFa6ncc5wYibKl/av+wL1dCEKuGHARyCc4R0YFSsPrkPMsCjggkF0aN4RktHwefeihYAV1BKarYse6uCpu6rHuvmuCjs0SIfBdHi41nmAUG4/bdX/7QeYzskwg1bc4Ddm17N+FAC6oWJRbzT/6nmQlz+C6ise1Hsek12jYNc7QfUjnlIvovSScnBmW0W/ZVah6qgO8lDxHfQMmqbGi/inTnpCSl++CEsvJnbOB+eMiX7a0XuIVRsOhJBELdIhAzhlMVhk1isUhc9dIhM4qTANI7NPPE87Q8EqjhwngSkCfSwRcgYbjPtF5Xf2L9jtTRJQZajgqb4UJeqgPyzgd1HLo4rCUSG4siryOmTbDS42BXvBLXQV3gp0VrNHgP0IZzV328F2EebBW9mO2thR7eVDX39Bm/FNRfHOMfsVdR+6lTxb9mNMyUrlzB2Y177RgWSBcTrS/PHae7pbf+4dp4S+4T0vIIJEcGwWRUZDe7UyGyWeB39i920QVgn1hByDqpZdOA5Xt1PxF7FMM9YkVvwZe/2oKwY32OVA9AvgkrYcEld58gXgbf3kwprS6IZxH76TZ9XWvI0X55 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 20 Jan 2024 at 07:23, Theo de Raadt wrote: > > There is an one large difference remainig between mimmutable() and mseal(), > which is how other system calls behave. > > We return EPERM for failures in all the system calls that fail upon > immutable memory (since Oct 2022). > > You are returning EACESS. > > Before it is too late, do you want to reconsider that return value, or > do you have a justification for the choice? I don't think there's any real reason for the difference. Jeff - mind changing the EACESS to EPERM, and we'll have something that is more-or-less compatible between Linux and OpenBSD? Linus