From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37ACBC38A2D for ; Fri, 21 Oct 2022 19:40:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86DD38E0002; Fri, 21 Oct 2022 15:40:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81E4B8E0001; Fri, 21 Oct 2022 15:40:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E5D88E0002; Fri, 21 Oct 2022 15:40:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5B4D78E0001 for ; Fri, 21 Oct 2022 15:40:31 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1D31F140417 for ; Fri, 21 Oct 2022 19:40:31 +0000 (UTC) X-FDA: 80045973462.25.9E4B993 Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) by imf30.hostedemail.com (Postfix) with ESMTP id A9A568002C for ; Fri, 21 Oct 2022 19:40:30 +0000 (UTC) Received: by mail-qv1-f43.google.com with SMTP id y10so2506457qvo.11 for ; Fri, 21 Oct 2022 12:40:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8cEcPE5eJxdhlD5IGo/M7P7SxrnCieMphXj8buQz48I=; b=T9l49X7m6bFvcPcqrTkzRupPSD0TaxDVlJn97Z7GBec0F5nMJUH2zckYJQilD6S+4I v3LjPCvtVo603tLjPTPha5JL3M+0gdgQXKkipkYn/djWgwydEi2FEI1B8X1oN02ql5SO 3wYl0+PPOXb8PbGPo/JBnAEn7meQ0mzKUgPFQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8cEcPE5eJxdhlD5IGo/M7P7SxrnCieMphXj8buQz48I=; b=3mGMvHlqvHxUtSpsgIv683njEUXeBq0HHhMVdJX53kC4vwaCqlkUcXQM/NZK/STux6 CJIn9oNAtkJFsaYWZZzxvMRdL9vcO0YbIyfIMcmkAJH1Q6A6uYogm6JFvDCqf+2ZbUwj +nUhNr6bH916pE9+rBG2/ze1TDcCYvpqtyLBYCU0fqfopO2Cd0SUB7CzcXPTGWfpR07n c+bBrxyRB0ytd4D56vKU408WlvgKziUqqyt0XHO+Uz+h/XZZPqFR9SkWksXtzTjPjeWU ENixyF4LcpU/l+UcXHGwaBaXY9JY+souYl1WCmU5uHKUg4l7gG7ehRg74bk3KeK/Knnw ZkGA== X-Gm-Message-State: ACrzQf2IYdTaIR6ou0a7qhkF2Fp/JU19w5ZfE5/RUJpUSGe64gDArg/a xupzMNd0KScXZF+xLALrJCWppOZk+90huw== X-Google-Smtp-Source: AMsMyM6rfF6Zog9UnhSGh2D8YyRTPeq4jbQtlLmnkTGFrKyeTNUnbA750l4BNBH8M2F0UNjSJsoahA== X-Received: by 2002:a05:6214:d69:b0:4b4:525e:c987 with SMTP id 9-20020a0562140d6900b004b4525ec987mr18272633qvs.82.1666381229612; Fri, 21 Oct 2022 12:40:29 -0700 (PDT) Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com. [209.85.219.177]) by smtp.gmail.com with ESMTPSA id az14-20020a05620a170e00b006ce9e880c6fsm10021344qkb.111.2022.10.21.12.40.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Oct 2022 12:40:28 -0700 (PDT) Received: by mail-yb1-f177.google.com with SMTP id 126so4515197ybw.3 for ; Fri, 21 Oct 2022 12:40:28 -0700 (PDT) X-Received: by 2002:a25:84cf:0:b0:6b3:c0c3:19d8 with SMTP id x15-20020a2584cf000000b006b3c0c319d8mr17385388ybm.349.1666381228574; Fri, 21 Oct 2022 12:40:28 -0700 (PDT) MIME-Version: 1.0 References: <20221020213327.2c284af5925b6a8ed915fe9e@linux-foundation.org> In-Reply-To: <20221020213327.2c284af5925b6a8ed915fe9e@linux-foundation.org> From: Linus Torvalds Date: Fri, 21 Oct 2022 12:40:12 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] hotfixes for 6.1-rc2 To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666381230; a=rsa-sha256; cv=none; b=u6/dM+bXfOnnVzb9Bs+Y1YCoD9RSZXkqEwlXP1VrTzEIO23YQr+d2rm8jPcSgq9ZLvyrb5 iPaWL9KtCUVkUzDBGHGz2kjGmcU9Guv68p1A4DsCpBBI3yrG4DjP+VoEnZj3xZ7ipsGSH1 WxaWLchVf4VEdLHoP9668pdmCvezcmY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=T9l49X7m; dmarc=none; spf=pass (imf30.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.219.43 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666381230; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8cEcPE5eJxdhlD5IGo/M7P7SxrnCieMphXj8buQz48I=; b=yzRHpVGN+9GD1yEcdHn0MIXFDf2dU3z/zdo2ZcNdxatVPbAwBUqbgDOoTg6S1ZELMWOXjf JwBAhEMQzO7uHp00L0rsbHN+ldFOTQQq4JakKXLgvXwtiauoNMP8IzXZGftEKNnxp6a+9N FpesXRmOPjtZVqR1G7lW5XeC8KuFF7Q= Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=T9l49X7m; dmarc=none; spf=pass (imf30.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.219.43 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-Rspamd-Server: rspam04 X-Rspam-User: X-Stat-Signature: ykwmcmubhf4yz7skoocxw6a18hgmzhp3 X-Rspamd-Queue-Id: A9A568002C X-HE-Tag: 1666381230-885162 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 20, 2022 at 9:33 PM Andrew Morton wrote: > > Andrew Morton (3): > Merge branch 'master' into mm-hotfixes-stable > Merge branch 'master' into mm-hotfixes-stable I've pulled this, but both of these merges look entirely invalid. First off, one of them is most definitely pointless - there's no activity between the first and the second merge, so that first merge shouldn't have been done in the first place. But the second merge is bad by definition too, in that it doesn't have any explanation for it. I've said this before - and I hope that some day I just won't have to say it again - if you cannot explain a merge, you shouldn't be *doing* a merge. It really is that simple. If you have no clear explanation for why you need to do that merge, then you simply shouldn't have done it. For example, that first merge clearly CANNOT have a valid reason for existing. There's simply no valid explanation for doing it, considering that there was no work on top of it that could possibly be a cause tor that merge. So that whole "if you cannot explain why you do a merge, don't do the merge" rule should have been a hard "NO" on it, and should have made it obvious that it shouldn't have happened. Please don't do pointless merges. Linus