From: Linus Torvalds <torvalds@linux-foundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Timur Tabi <timur@kernel.org>, Kees Cook <keescook@chromium.org>,
Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
Matthew Wilcox <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
roman.fietze@magna.com, John Ogness <john.ogness@linutronix.de>,
Akinobu Mita <akinobu.mita@gmail.com>
Subject: Re: [PATCH] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed
Date: Tue, 2 Feb 2021 14:51:00 -0800 [thread overview]
Message-ID: <CAHk-=wgaK4cz=K-JB4p-KPXBV73m9bja2w1W1Lr3iu8+NEPk7A@mail.gmail.com> (raw)
In-Reply-To: <20210202173436.6516c676@gandalf.local.home>
On Tue, Feb 2, 2021 at 2:34 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> "I also suspect that everybody has already accepted that KASLR isn't
> really working locally anyway (due to all the hw leak models with
> cache and TLB timing), so anybody who can look at kernel messages
> already probably could figure most of those things out."
Honestly, if you have to pass a kernel command line, and there's a big
notice in the kernel messages about this, I no longer care.
Because it means that people who _do_ care will know about it.
But I don't want it to be a kernel config option - if you do
debugging, and you want unhidden pointers, you can add it to the
kernel command line and make sure it's *your* choice and not some
random kernel config by somebody else (ie distro).
And yes, my opinion is that KASRL really only works remotely anyway. I
think we might as well accept that as a fact, and that it's unlikely
that hardware will be fixed in general, even if on _some_ hardware
might make it work better than it works in general.
Instead of fighting windmills, accept that KASRL is dead locally for
the "wide access" cases (ie not necessarily just "shell access", but
"local JIT of uncontrolled code"), but do it because the remote case
still matters, and because a lot of local accesses are fairly
constrained in that they do *not* give random code execution to the
local users (but that "fairly constrained" presumably also generally
means that they can't do dmesg).
Linus
next prev parent reply other threads:[~2021-02-02 22:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 20:18 Timur Tabi
2021-02-02 21:52 ` Kees Cook
2021-02-02 22:19 ` Timur Tabi
2021-02-02 22:34 ` Steven Rostedt
2021-02-02 22:51 ` Linus Torvalds [this message]
2021-02-03 18:53 ` Kees Cook
2021-02-04 20:48 ` Pavel Machek
2021-02-04 20:54 ` Steven Rostedt
2021-02-04 21:49 ` Pavel Machek
2021-02-04 21:59 ` Timur Tabi
2021-02-04 22:06 ` Steven Rostedt
2021-02-04 22:11 ` Pavel Machek
2021-02-04 22:17 ` Kees Cook
2021-02-04 22:20 ` Timur Tabi
2021-02-04 22:51 ` Pavel Machek
2021-02-04 22:57 ` Pavel Machek
2021-02-04 22:05 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgaK4cz=K-JB4p-KPXBV73m9bja2w1W1Lr3iu8+NEPk7A@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=john.ogness@linutronix.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pmladek@suse.com \
--cc=roman.fietze@magna.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=timur@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox