From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 670E9D3C92D for ; Sun, 20 Oct 2024 20:20:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86F626B007B; Sun, 20 Oct 2024 16:20:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81FAA6B0082; Sun, 20 Oct 2024 16:20:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E6B26B0083; Sun, 20 Oct 2024 16:20:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 507B46B007B for ; Sun, 20 Oct 2024 16:20:05 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3AA8DC13D2 for ; Sun, 20 Oct 2024 20:19:49 +0000 (UTC) X-FDA: 82695096624.06.9771C05 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by imf18.hostedemail.com (Postfix) with ESMTP id A154F1C0006 for ; Sun, 20 Oct 2024 20:19:56 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=cbsiH9bU; dmarc=none; spf=pass (imf18.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.48 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729455566; a=rsa-sha256; cv=none; b=XnsNTIxCNfVsxkC+T2a79iRm2mHas6+oCgk9AXhmpNUQjutnB0QTnaNdqznqzKfmwQ0YM1 sC+B+kVi6gHSatV5YnnIaJvQut//JN5/NnLa49As0Kal+b6vgJljNZDQVVnQxqjqerPa9f OR+SMtOnnsajXivD0qVALcXc6KuzGQE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=cbsiH9bU; dmarc=none; spf=pass (imf18.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.48 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729455566; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=88onBEAjrCo9PM88ELLaTVKMgRy8BmLUIyXxY2Wo4jw=; b=jF0YISy+fEiX84mc5e2HKTwm2+bE4Oqd8ddggfonir/KfKL/DipQgGJD2q//LBZqNDG+Pe YLLdXKVBC3F4+W6A5jG3CfHdpQ5KjpFv72OhM0Y7bKM3KoIq/UzYH/7+8vMg5Q1MzOKEhL tXiHNA6DMJd09cmLY/DCvvncJrLDql4= Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5c9150f9ed4so4588942a12.0 for ; Sun, 20 Oct 2024 13:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1729455601; x=1730060401; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=88onBEAjrCo9PM88ELLaTVKMgRy8BmLUIyXxY2Wo4jw=; b=cbsiH9bUTD5NYing8m/QZptK+7copqMdOrYRPKGtOqNirRBVD2R0+Vq6kg41tTEkLL dJYPHLue4WbEia9CIFNTM59jVRV3jmhBr6Vcfemh3b2opJgB7WQ8NN8WUwyxtDDj1mOg BrAMCTnRRGHpKEgaHul/G4GAkCvp6DnWwt9DI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729455601; x=1730060401; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=88onBEAjrCo9PM88ELLaTVKMgRy8BmLUIyXxY2Wo4jw=; b=HrhwYb0QJX1LzzdcWoRwvdxrDhzhAY823nmuHqU3ULq1ny7G/ZWIHJzqr+jYzNTdSz OcC1fljaenCnNN6fmEUez6D7vAylFRgglcPCmu9iE51zeWN8zaYY3Aq7KCLJSiS7R28U IfmHmLWWCo767tvlU0Hg1XWNvCHXPqZj+BFGgEE4nswtJZGHkoCsTRMKbDkYerP56Rqh 9qdL6SXlhvbGnyuBouXyFtxHWVEuOo6f8+qBsEppq7FALQl+rAofgQQPIstyG6n47xoK An0bdRzCAFTswc5QbzK5/OG6CnY2Nf6WQXu9pscILA5z+Zfa7KewbtPozKC1isi7a9Pl uMbw== X-Forwarded-Encrypted: i=1; AJvYcCWob+MiU2jpBw0RqHbRBJNrVXiykTDlz24Sa7hACZ8lLE39i2AWewoU0VNg1agVdL8mKdweezdTTQ==@kvack.org X-Gm-Message-State: AOJu0Yw4cK88cN+gFRvy+jqcH3BiOATuuNqov7XV1JaRq9NCy75CJ4fd xrLf+h7WZVXwFSFiU1FAGAymEHuDGkYR9dtiTyQZNeQnC5x1/5B8gx+cPFfPmKkPpwHKGQqHpJK IvMKyVw== X-Google-Smtp-Source: AGHT+IHpb1VUxPt+mZIXw9KgCQvcQ9xoyh1R0FtVyMxVOB4kEgYqODOT6xEpbXojupdeqBKqLQb+vQ== X-Received: by 2002:a17:907:6d26:b0:a99:fd32:11dc with SMTP id a640c23a62f3a-a9a69b75733mr885268266b.24.1729455600775; Sun, 20 Oct 2024 13:20:00 -0700 (PDT) Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com. [209.85.218.44]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a9159936dsm120648466b.201.2024.10.20.13.19.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Oct 2024 13:20:00 -0700 (PDT) Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a9a68480164so309642466b.3 for ; Sun, 20 Oct 2024 13:19:59 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXtfCXJ080O01Z4VIaDG1PIT/dtzLMyg9AZG0SK4rlMHFOmoCVqOzMiGOxKLdlPf1DxiHTgrZQc1w==@kvack.org X-Received: by 2002:a17:907:7da4:b0:a99:ecaf:4543 with SMTP id a640c23a62f3a-a9a69b7aec7mr918802566b.25.1729455599563; Sun, 20 Oct 2024 13:19:59 -0700 (PDT) MIME-Version: 1.0 References: <20241019210037.146825-1-kent.overstreet@linux.dev> <90bc0794-4cab-415f-a442-4af85a32eed8@lucifer.local> <6eo3gekf6twbnzhpsi2emz2s6sgtof6iba2rvbor7himmejoq5@qbfwtpbpvqoe> In-Reply-To: <6eo3gekf6twbnzhpsi2emz2s6sgtof6iba2rvbor7himmejoq5@qbfwtpbpvqoe> From: Linus Torvalds Date: Sun, 20 Oct 2024 13:19:42 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mm: Drop INT_MAX limit from kvmalloc() To: Kent Overstreet Cc: Lorenzo Stoakes , linux-bcachefs@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka , Andrew Morton , Uladzislau Rezki , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Stat-Signature: f3fdbqd4hksqh3tfiucpnikebg57izqt X-Rspamd-Queue-Id: A154F1C0006 X-Rspamd-Server: rspam02 X-HE-Tag: 1729455596-408364 X-HE-Meta: U2FsdGVkX18fibhcKfFB+BsIiDXQkUL6/2cY1KzytlkFJNp/Jt4zG17iyBg7zqOSGifAiaoLDgiHuJlR0MRkj5wt7kheiGvsvsGviBpygCty+siWcp/W5yJKK71idhSYdNaK9xVEFosASLG1F8RgaMzDmyvmd9u+y775M9+LltLVesxWGXkO1hQAni7/hsH9gw/cxKsDZmQQPYmPUII28WWCNeIvz3uVHmLKp5j3qNu1nA6yCSVExufy09svQh9aZ0M/OmdRJUW9jhhP7+0Hl36vHce+lXcI7mU3mzfRVHhT089MMCqfQI0BMB2q82NpCi7dhN4xJvgFOUPsRc/O8cexWQQUsw8QV57DEJnj6XZ4F4Uy2wDXjYHVBLOpQ+HXYlP2gNVVM8m3620HmvtpPKo8lh8qetbDXWL9W6aryqbf9RV+tKHz+1jfl/UFMQtAswHto6ucCCc/2/70v3FmkzGkcmlQTgtX+S0M2TfYixOJ8tSbpC59ZYTDXOwK6BOqTMSa0UxZ1Mq1Un1/jcPKCXwLxuzOOxWL2KjMH4vg4dyPNvHZihYi2Nntj7iL5mdhyeVkBfTVxV36CBQPVVXt2Z+N3/3bfHh41sqxpV6QxhZFetpcDm/HOtILb9LK0vPe1cyJKGmoBNu1yKTk06YOsoTyr+AKKQWyIKMVQDwmEDVZ+afSfxcGsqhbFThQFrb/tnrdpazFZa42+1vp5mF+AbagkExEocH+6iQDUKDjt/+4G1LlfVDWI6WQNOVxb62Dq/qWm0qzX5HNj/BrNsN9oyl3IwYE4BjkM1UzKPiUTULCW5qMs0msd4a1YtLmG0xjalpDGg5y89dL+FZgLfhuYQP9T4BKPlqDmSW/kXwqCOxgv8HTekXYM/aBq2dKXPTBkoozqMKjtCX9bMV74Tz+HhL8RvXw5M6QxyzAt6LS0r3oG4/8YG0gLNCinD59pqU7MpVXDk1sh3ifrdVAjEl 3+ckA0Br eqSygkPXLXf/0Q45Er79M72Ras2sn4QOThinI7Z2hCRthpweSvoMTz3Yd1gg0aGPUg8dCfShBdSLHdnvABnK9UWjX9/wbMSQkiVVJx201ay+curMF26oS2VuxqCpPdGCbarPqWwTUVUVtcFU701fn9N7ymm7zcyJA81r91Y4I3V4CGHF6884jfOS+6UR4PteWyD9aafOZIL6mQ9SE7oLiUcX0Jhhb/8J8phg/QOM4yyeYygHqlB5CAsw4ut8F4mKa1I+HRJ+wcdPjlW4/AOvJzpdkv1HkO1JAh2wfV2ocMf60Ie/Enf0VjEYyv9mdBaa8zyQPLAgprHeC3XRF4viZx+IdCSVkj4bb7nhLovvBNKQz5mR4KEQzuY4C6qfLfSC8uMmaJW5XAV7Ut2Fm81A2QLMMjA2uemRuJ6Aoy1U3W59vBhemIdO3RuhGKOdTeBNXNXWZQYGpxE/2snnxtlRJ/7p5IZQqFQKE1OUBmF2oZWaSDhilQ6BSoXkVlqiYT/9xFDHmvT/LemlHaHReb2Th4mbSRfIRQe37mXWJr60Sk0T2vOio0H1d0390EzQoAWruWMdHDG85KX4AIIQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 20 Oct 2024 at 13:10, Kent Overstreet wrote: > > And the INT_MAX check wouldn't catch truncation anyways - it'd only > catch integer _underflow_, but allocation size calculations pretty much > as a rule never use subtractions, so I don't think this check was ever > worth much to begin with. It fixed a real security issue. Enough said, and you're just making shit up to make excuses. Also, you might want to start look at latency numbers in addition to throughput. If your journal replay needs an *index* that is 2G in size, you may have other issues. Your journal size is insane, and your "artificial cap on performance" had better come with numbers. Why do you keep on being the person who creates all these pointless arguments? Not just with me, btw. Linus