From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8A19C2BA19 for ; Thu, 9 Apr 2020 19:55:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 568E42084D for ; Thu, 9 Apr 2020 19:55:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="aGkY8jiS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 568E42084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C38748E0010; Thu, 9 Apr 2020 15:55:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE9778E0003; Thu, 9 Apr 2020 15:55:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD70F8E0010; Thu, 9 Apr 2020 15:55:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A1CB68E0003 for ; Thu, 9 Apr 2020 15:55:37 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 70C063ABC for ; Thu, 9 Apr 2020 19:55:37 +0000 (UTC) X-FDA: 76689371514.08.quilt33_13f41d2c6212d X-HE-Tag: quilt33_13f41d2c6212d X-Filterd-Recvd-Size: 3798 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Thu, 9 Apr 2020 19:55:36 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id h6so629967lfc.0 for ; Thu, 09 Apr 2020 12:55:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FWqxa7IgEF9kjblzeGUACdh2V+Kc1/x9y1BsC32Ew80=; b=aGkY8jiS6vcqO54+MzZBq6t09AZ9z9nNDAnW2XAwn+SlblvC8sObX5Tr+07IwPurpA Tuaoiydplp3y51TfJ36L1C78h376noZYZ1tlNKwp67EXunNuIaFgvF6lyQsDZtvXg3TS yiPcAguS17DgYZhWDB9geFPpXHoUef6RG+gCY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FWqxa7IgEF9kjblzeGUACdh2V+Kc1/x9y1BsC32Ew80=; b=O8/HrJF0FBbWGTKCSM+2gKSzwxEFgIMeek3pwPJdxNf351bvGvIsmCsUY53LqDsd27 Wehy3j77XAd+3uVr0wFFqXVhwq1zaynen63xTSxJ4PkcXnlYCQoRXixepgOPnS3Ipcg5 KkqzqVOUZxYpBBBU0VTCK2Of3VRA9trQYSr4GEPb+tfdufSQQqDQEh4FtbX5LsJd1XKb 2RFOhIE06i1lQIgSn6rjJBOU2idhUWrnt+RX3OIXrgB2XIhuOV8+b+spPXoYt4hO+5P0 jF9vdLlg9zJ9EF3GPUhW8FUTlo4lUQ+UDp6N0LcCWlfMGjSyFl55RDzJKE3WIq6grHpY D5/Q== X-Gm-Message-State: AGi0Pub5rRP0x9Re73eEpnW4QNE/3QwzCCO6j9ogQAPEL2wDGFl1C9Z3 yPaluRBpVgZc0S3rFiHcONaBjI4cswk= X-Google-Smtp-Source: APiQypJi2AbrwOxevSBNWKv/QYaFmXCYS+NpA8xPEoy2Incbau/FQfxczFQmyOO5qUBw2H4CuEzm/A== X-Received: by 2002:ac2:4c94:: with SMTP id d20mr568053lfl.54.1586462134517; Thu, 09 Apr 2020 12:55:34 -0700 (PDT) Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com. [209.85.208.173]) by smtp.gmail.com with ESMTPSA id c22sm15926451lja.86.2020.04.09.12.55.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Apr 2020 12:55:33 -0700 (PDT) Received: by mail-lj1-f173.google.com with SMTP id t17so975499ljc.12 for ; Thu, 09 Apr 2020 12:55:33 -0700 (PDT) X-Received: by 2002:a2e:8652:: with SMTP id i18mr901347ljj.265.1586462132767; Thu, 09 Apr 2020 12:55:32 -0700 (PDT) MIME-Version: 1.0 References: <20200409071133.31734-1-mhocko@kernel.org> In-Reply-To: <20200409071133.31734-1-mhocko@kernel.org> From: Linus Torvalds Date: Thu, 9 Apr 2020 12:55:17 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mm, gup: return EINTR when gup is interrupted by fatal signals To: Michal Hocko Cc: Andrew Morton , Peter Xu , Hillf Danton , Linux-MM , LKML , Michal Hocko Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 9, 2020 at 12:11 AM Michal Hocko wrote: > > ERESTARTSYS is also quite confusing because the signal is fatal and so > no handling will happen before returning to the userspace. Ack. Except I'd rephrase that as "no restart" rather than "no handling". We do end up handling the fatal signal, it's just that the handling doesn't involve restarting, it just involves dying. That said, I'll leave this to the usual channels, since it isn't exactly the same kind of urgent fix that I picked up directly.. Linus