From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28B2EC0218D for ; Mon, 27 Jan 2025 00:08:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C03928010A; Sun, 26 Jan 2025 19:08:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 26F6E280101; Sun, 26 Jan 2025 19:08:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 110E328010A; Sun, 26 Jan 2025 19:08:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E56E9280101 for ; Sun, 26 Jan 2025 19:08:49 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5EFA2161EC5 for ; Mon, 27 Jan 2025 00:08:49 +0000 (UTC) X-FDA: 83051295978.28.2DA2D38 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf10.hostedemail.com (Postfix) with ESMTP id 34096C0017 for ; Mon, 27 Jan 2025 00:08:46 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=gY6WLow0; spf=pass (imf10.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.53 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737936527; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k6OF3+vySxnUkmergH/+kbakIWlWANHYDNwh50U2rJ4=; b=103hS9c6QWNZx0w5FbdT+A7Kgv5R0C5CNCZA8leKoucThLA9upU3szhK8tsqgxDDdvs/3b ax7ODJ/PB6RXPVK6khgOzNJswF7v6rJwIuLOo0AflKQPQ67CjQ3yAms8qMxheBNyswVPdu lZHHLpfejNUrbucM3CAV5kVwyo+yvs4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737936527; a=rsa-sha256; cv=none; b=Ofeug/CMrev45UaxgB7QChPV0Vj+oGehF7eu8rF/o+gwIADGCycnc9wVBtS5jMNA32QYFI 6uL150/Vt6SaH2oqctgJuovC1w6gO3n6tMf2Mh+5q0FZZIDrHLlfaPtiMpgxvJT0rqid0B 0hWJ0s4aOi8+UitCd4wxa4lI0i7zZh8= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=gY6WLow0; spf=pass (imf10.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.53 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-ab68a4ab074so227446866b.0 for ; Sun, 26 Jan 2025 16:08:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1737936525; x=1738541325; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=k6OF3+vySxnUkmergH/+kbakIWlWANHYDNwh50U2rJ4=; b=gY6WLow0qJuTBFi+P9C1HBvmoCy1ibLauib3+EjvHy28et4KgawYjLO0L4bwVh9oT5 a5tGADxH1aFt1O8mdn7/ckC4QMgMkAAFCkGMOT9cmU8FalUD3RMFb3538KNQ5ZZJu5kY B1xnlu4s0awRDN0Ft/lWsQ6MNp0B/IJ4SBCw8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737936525; x=1738541325; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=k6OF3+vySxnUkmergH/+kbakIWlWANHYDNwh50U2rJ4=; b=IwDfTpDs1d0DEvPVS3puaaq1/ajaK6cdCvH0qzCKK/2NgrUGQGFyU+z2jtGt0/xJ6U 21CyXcg/gJJpwDUPqFDEU0qDDJcvMXSc2mD2PosJmecFkq0jm01t0msMpjKwPHKzZmQ7 19YXyG2bdz2X258U2/6tyR4Hm/L4Z9Xm3yd321hoXJZhVBDIXFjXucVF66mHRi9i7Gpq ENSoHW5vQkGwuQv1sLi/aVmbMp14moDfdXQ4ISNyXqrh8Urx4wCqjmay51ewj3l5hgdX ZI6JIJv5mRFuzQdnGQZBm3DF2TXDEf257QXzabpVciQxI9x6soH9fzVZmCIUI9ls1q4/ 1UOA== X-Forwarded-Encrypted: i=1; AJvYcCXSXrjqLgnyxTTtkZELpoM3q+Ak70UYf4nlC82ofSZ30cVNIlkHPLba6c0YgLTOErWMO5ilCY6wCQ==@kvack.org X-Gm-Message-State: AOJu0YwsNyRUhf3k5iTYsOQ5SXcURjAt/a3K0S9Lp8NU1THZhCot7f0T 78l6OkGsCy0SWkR4jQghJJuRW/qAgwAvYj+19kb8k3SbSK6NPK7h8wOq9e+3/HCsf30JG+Bcs9n DDyM= X-Gm-Gg: ASbGncvRrGoEz6BVGjYvWPkJcprpXXO8XKsWheXutiQ8e8uy/Hxk/64IakJpknEGCVI N454b7xeB7fYWVPMPsIZmeopa2yquqo2nMqHeUH1nRAq/GJRDyn0DLp+N7+dXUeZ4Kg5FDiL9vf aUqU1p7aHQ2amiebxAw1lmUHE1YQzgQnjgDQD5FdzpWuCcBwXdn9soLNbVA6XBfFyg5YfFvLkeg HsCGQ53xQnnIBVh667gAUHM+r0OdU5zzrAy2Ua9zIvvPfViXssPUFwSSh3vUkGMYwKdfhmtBpAh nQitBwIXedj7+z4mOi3jZoOCTJD/Y/wq5Az290tebtcjIauAUb0Y234= X-Google-Smtp-Source: AGHT+IFOS2tIf2gYfSjp2cBavmIaqCROdaw3zVSaF9Vca2L7b5ne6vdzcEAceZxH3FYa5fxeJK9JNQ== X-Received: by 2002:a05:6402:518a:b0:5d3:ba42:e9e3 with SMTP id 4fb4d7f45d1cf-5db7d2f5ec0mr95101971a12.13.1737936525211; Sun, 26 Jan 2025 16:08:45 -0800 (PST) Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com. [209.85.218.52]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5dc18638ed2sm4604325a12.36.2025.01.26.16.08.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Jan 2025 16:08:44 -0800 (PST) Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-ab69bba49e2so125069466b.2 for ; Sun, 26 Jan 2025 16:08:43 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUE+P8TOcorthdTWYXtqF4ihr6T5rrBKjgOgDkTDIOaGtVug4f0BtIKoJ+qBl5u380MzRSbGIjxrw==@kvack.org X-Received: by 2002:aa7:c505:0:b0:5db:e7eb:1b4c with SMTP id 4fb4d7f45d1cf-5dbe7eb1df7mr41371775a12.10.1737936523125; Sun, 26 Jan 2025 16:08:43 -0800 (PST) MIME-Version: 1.0 References: <20250124162248.60104eec848619a187242392@linux-foundation.org> In-Reply-To: From: Linus Torvalds Date: Sun, 26 Jan 2025 16:08:26 -0800 X-Gmail-Original-Message-ID: X-Gm-Features: AWEUYZkgThD06LP6JnpPwSeEU-gztJJXCL1K6rChtIyUORLCFXJrOgAryyPNQRQ Message-ID: Subject: Re: [GIT PULL] MM updates for 6.14-rc1 To: Uros Bizjak Cc: Miguel Ojeda , Andrew Morton , linux-mm@kvack.org, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 34096C0017 X-Stat-Signature: 8rx6edwg6yk7abgmxpe9gcmc5ij1z5cj X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1737936526-352571 X-HE-Meta: U2FsdGVkX19JEXwjN1KOcHvEC0+AgY8yhA5MqaI3qg7WItFTThwOLO2Bt7hVabdKpJmObIGsy+vRVGuA8H0uVbo41CP3YfMEyNl41ECa7ffo/BwbEMMk/1URxNAkJT34S2khoEs4k8dcNT/+mGx2fjkE5X2vZgoHo4CKYOzXqd9e1N1zYRUzVVG//cAJ3NaCUiAoxmaqRhsq5duS72w1Ln6aI9jHgG2/4P4C+4j5y31Dmxsrx1F0pV30vcbnWRpHxL+uA3WFZQrwiIKqtQggGp308E742Mc+N5wRNt6CUJKHype0oeRhbAb3wVE+VV8nOi8OtrnWBsgiZYeRgopmDdRh/jnNRAeEYw5WKX4hX8BQOoWCYzKaxndYOKuvxw5gU33BcFM+xAju6B1E4CraUQlojHoCzWxAecNDrI3HPSPSp2KVSjT0KrV0rDulNltakRhn/8AZQmO+QrVJyIoJ1BF0FhIDkto3yvBN655hAhiH6ayG4sV8bg/kKiCVpwL2CtlqGKmXN+bEUd6ZYdBeE/zGN0n3++RVBjo8d8U2ewau8xKTFsC1eW67Yb07eZ95Q3smEqvs3trgSvsrwOSWuVGovxpGODN77Sbx1MSyj9oHIMaVGYdFDxEm7mMOvqYlop3olfXx/CpdmxaQkxjejtnoG8J6lLpuDcvaSpiDr3mJXcJXmc88eZ6P6KgkJ/fxg8oVJJeTB0RUlKsQ6zIWONCJ+koDPWndaiqs5s8QlroUzuNmA9rE51HBBhnE5tmakSqiUUeqB1NPnA5VCPaEUizPhaIbJLYndVQhJwP9LB6EDN39f37VlCbFQgwWafIF+uvKiX8mJI70bdgWEbB0YnLu5I4eikRAmuUv7pqEQpBfFcxcmaeBbz+aQpzH8OeoL4XKWWopkEf/htEIzQX5OZYm8wAJncw2EyDjuV/naGpJiNmsldtVSTNNczgJxd1UhorgBdQGRh+6qep5b3f /AlmnB8T YYXCVs7sC2JpdFoJhF+E5k8LW5VIDu2Vk7iYcPxQF6YgrbjXGRzgpSZNn+uMcEjHX1tvRdB2Bk+HyuyuCfu3NWm6XJggm5gyYZK3t1sDiE6T43aOrL6KPAxb0ZNWaL+xjpYhsTgCBu+I+uDuzE3WsHx4q473EwUJTwcXa5Pwk2plSz6Agf+W40q1jjldr+1R1tsnDrPmYGLKTqnsNfdLTfR5EETaZCjruDmHLToKVilQDj8mhGgCSPsbHKPDT4BwJxhkdTqh22aKZJWvrjVChXXlR3b0dOpd3XM7PlBUY/5nI60MmqroKTievUOI/ObhVikZhl22CRQNKvXieiwF5o5M5bHvZRx06FwHGFl+L1Cq/KZbnH9Oz63Xrlhy6D8WdvXDTQ72XjFeaSpd7Ksy0+RYqWWqqq5ay8VJDNqNm+eIi+y68MlcjdG7L0r+JC17peQypbvZu2eIt26heOW5Gkp9+RuaRmtABrzv/rumYRnotT8gTHFRkOUMW4w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.173368, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 26 Jan 2025 at 15:27, Uros Bizjak wrote: > > The detection is put in include/linux/compiler.h where we can > consolidate checks for both compilers: No. Please. We have compiler-specific header files for a reason. Exactly so that we do *not* need to have disgusting tests like #if ((defined(__GNUC__) && __GNUC__ >= 14) || \ (defined(__clang__) && __clang_major__ >= 19)) && \ !defined(__CHECKER__) and instead it should just be #define CC_HAS_TYPEOF_UNQUAL (__clang_major__ >= 19) in compiler-clang.h, and #define CC_HAS_TYPEOF_UNQUAL (__GNUC__ >= 14) in compiler-gcc.h. And then in the actual compiler.h, we could do #define USE_TYPEOF_UNQUAL (CC_HAS_TYPEOF_UNQUAL && !defined(__CHECKER__)) and now the places that then want to use __typeof_unqual__ have a very straightforward way to check if they should do so. Linus