From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AACBC02182 for ; Mon, 20 Jan 2025 19:15:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C92A96B0088; Mon, 20 Jan 2025 14:15:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C435D6B0089; Mon, 20 Jan 2025 14:15:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE37E6B008A; Mon, 20 Jan 2025 14:15:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 90A1E6B0088 for ; Mon, 20 Jan 2025 14:15:03 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 162E4AE7BF for ; Mon, 20 Jan 2025 19:15:03 +0000 (UTC) X-FDA: 83028782886.10.0062EBC Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by imf09.hostedemail.com (Postfix) with ESMTP id E2DAB140012 for ; Mon, 20 Jan 2025 19:15:00 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=X9DcqHGa; spf=pass (imf09.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.43 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737400501; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2A1SxqaKC9E04yxtcM0gBjhhzV82aFBvHScpwEZ6wwo=; b=JlZUz0FoFrHlLkjApYpox/Tz5FSANwCoK8sDXJtNSp68RD+/d2bEyS95w+xgHkkaPSm/nI MimmT2C3Zns5yEvFXeDJYPs3VkPp61pA/BB7jy2r5Nm4isOkXornt20JkWXXIP7xEcsQeJ WIsXBsYy8PqPvNIwmHIEg9S7nsj49kE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737400501; a=rsa-sha256; cv=none; b=y8GDixGJWWN5vri461B1ywYLK4aLOdM9ZVSf88w0vuOLhsloyxl6+DE2gGeT+wRsGQ/XCI 6QVA77VjAkwZxLvE9F91cX0YMv84v7KngkVO4RXu/KfKhDYeEegDe3xg7sUa76I+8RL+A0 L7EW2lYrT/T0P5NojpGshsrJZQWZJGY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=X9DcqHGa; spf=pass (imf09.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.43 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5d9b6b034easo9747317a12.3 for ; Mon, 20 Jan 2025 11:15:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1737400499; x=1738005299; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2A1SxqaKC9E04yxtcM0gBjhhzV82aFBvHScpwEZ6wwo=; b=X9DcqHGaSqG/2aF7vNTzpV2qTq0ga9MOcHkv2pPWvvP8e4ceveqzFUzleWza2q1lDw EWWjddTUkAD3KabZ5ayocY2bJd4TPtI+0gMzN9YUHKe1KZWgvWzRH7m0Y9BVk/QtZ18P HjCG/XpWtXeVjolxEZ8P3f1ZQL0wuA6D1HNJU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737400499; x=1738005299; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2A1SxqaKC9E04yxtcM0gBjhhzV82aFBvHScpwEZ6wwo=; b=ecm8vweyczD53piBQCUqBfIFZdtMEXSKItlG57BxaDdoFiqVqSR638PU6xUB0V2aOv AX46NfJ3xfu+QYzzE//6AhY9XhRAR9iN+X1zTNiK1/yHrciDzcw6krwnF4U93fD5lPgb lfia8hmcXL8Qz0U6/LtOv/Fbm48UK3OCGyXeR7bRi71rDVbZXx6CfvUg72VoR2Kqa7Xv bdOOMRbVyO3rDc1X4Alj/DiVQI1DAvH+JdvkMKgFL88o6Pcum6iRK/BS8AhzhMzRl3FK opcVNKIwom/anOJyCXC6RpkceMKXawQg0yGHk6KqHfUWKzli8qmtk1dNdUzensCd8SV4 kOVQ== X-Forwarded-Encrypted: i=1; AJvYcCVbpc+XkphVFAEyK+IBb5WQhf8yia4O2VuVJFqKy7RMUzoK4b2PcOf7SrulPNLc1oZCTml5zPpIDw==@kvack.org X-Gm-Message-State: AOJu0YxWKZruqkCvimu5b1Hozr1elsr6klT/p+Kn4/DaSu6D6z+lqsvd kE63Qpv+unVSNM2lUWJw2PoV570BSCfQwpEmC/pakwkTqEjwrq9WMj4RNO0kQPivsi1to+iA3O2 vBPk= X-Gm-Gg: ASbGncuSTSeDumUsL7dcwVNVYldqO8/SVyAXyB0MFviGb9OQSrpEHlpzoRw9ESH5LGj 0w/XgskPdpSj+Js/3jKym83B2OKLmdtoHimJINXL9EhYWax+cw6eNNnbjhxcavZW0r7x67M8lca 31NDox3iKlNiYmqMUSxqquke1WSNXfWDFaSB7TP2+YS2gEt3wFtUaHjZBAdjiKMlcU1rfKoUuAC 7J4B08WfA0jsA6oufMifUVNZhAQhhCUUK6lP16LBzGCXH5D5GRgGhhax668+7FM3Or5CCeVBQwN E71F0N9mnSp2b1g4uaWwz/u1ZWGeKuhY6Ud1orAS5X4f X-Google-Smtp-Source: AGHT+IF9yr8Pc0BzeCeW7/+SWPUFUV3khfBdYkF3c6NFFmHYFVGvGOkKeM9PEZkWFn0HTbU6gwmWqw== X-Received: by 2002:a05:6402:40c9:b0:5d9:b038:df0 with SMTP id 4fb4d7f45d1cf-5db7d2ec1b6mr13905548a12.3.1737400499459; Mon, 20 Jan 2025 11:14:59 -0800 (PST) Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com. [209.85.218.46]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5db736716d6sm6036320a12.31.2025.01.20.11.14.58 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 11:14:58 -0800 (PST) Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-aa69107179cso921113366b.0 for ; Mon, 20 Jan 2025 11:14:58 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVLWlwSrZXUZCDY1XztYZjcDittcNAEkh33KAfXAaoh81uPnoh5V7zUJ99+sHqNJF48wNnt46jb9w==@kvack.org X-Received: by 2002:a17:907:d1b:b0:ab2:dc73:34bd with SMTP id a640c23a62f3a-ab38b3cce0dmr1178261766b.48.1737400498031; Mon, 20 Jan 2025 11:14:58 -0800 (PST) MIME-Version: 1.0 References: <29ef57a1-e4dd-4d5d-8726-f1f79c698b66@roeck-us.net> <20250118221123.5bb65e64@pumpkin> <20250119090935.7c690f85@pumpkin> <87ed0xrcb8.fsf@intel.com> <20250120111551.435176c4@pumpkin> <878qr5ras2.fsf@intel.com> <0a65de6c-74d5-4d3e-be75-0aa9ecc82da1@roeck-us.net> <20250120184143.47615b21@pumpkin> In-Reply-To: From: Linus Torvalds Date: Mon, 20 Jan 2025 11:14:41 -0800 X-Gmail-Original-Message-ID: X-Gm-Features: AbW1kvanWbjjXlxUu-fz3APSBsTAMsHDuCb6rdyKw8tJpJDrImEOFs20uKWXbAw Message-ID: Subject: Re: Buiild error in i915/xe To: Andy Shevchenko Cc: David Laight , Guenter Roeck , Jani Nikula , David Laight , Arnd Bergmann , "linux-kernel@vger.kernel.org" , Jens Axboe , Matthew Wilcox , Christoph Hellwig , Andrew Morton , Dan Carpenter , "Jason A . Donenfeld" , "pedro.falcato@gmail.com" , Mateusz Guzik , "linux-mm@kvack.org" , Lorenzo Stoakes , intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, David Airlie , Simona Vetter , Rodrigo Vivi Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: E2DAB140012 X-Stat-Signature: t5zhmtsmtur918ukd9x3ohepo4h36jaj X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1737400500-940407 X-HE-Meta: U2FsdGVkX19yxfEvp0MZQMJspaF2UdH2P4rbQvLISKz8xNkzA7qMNApxOkeGgaySAEebJFSP6PC/NA4njiwLVQL2UhXabTVA1cu4B68g6/+eXeJ7DQV+pKaRb5UWr0B7RF1o+5rwkw+krF8/ZkMxWYBKFXuy3BMNneBPXhwRa4HYLy9LSnIoH8szRzowOsT8BnGBK3aUqiauWVEGQovpgOtieeIyHTcY7gjLJG56QMIRKqi5+2z43cToXtU9EpKOTP08zp8mpGhkO8J7UEkEODideX6YB8I1VoCFEAIlGPotXgD5QI5WR426qJU6ViWe4988i5deu6h63PZHbTZq+KSv79YCcdR6YKa+Ei7I50drn/q7s82ccB4x8D7moytrIK/AfnKmC+HJl7h/tfcMhMLH5p7B+W9RTsJcj4rKndaLk32qB3L+Ei6BwJMH/0yoKineZw4SJ1vZzwUV4rKFeqymD4FeJFIWVsCf3XmH7qrfzZUDCO9aquKufD+eLqa99GkuRmkmTIT8GrUgwccVqOa8cdfdZGtDyyuJ+6oyKbzYkUKuxgGhI+Z9Vv+77xL1vqbuGVCZVzeYWqhiU2oo7nsEXIZl35ped82KZQGIP+i5XA9nujX0RBNNmejjZX6MWkKehw/hObsnM2sjCZSIDdWA0eboDHa2+8+RnzbjB/2P0/jL4XiKOUNo96JAn9rZfIlnPg1Fbv8lVxpiR/nWV6nA98R8Mj+T6+sjdCzx/4Lp48f+1nAcN8BuCc6aoRRLf3jI+aHeyh3QpSYD/TetSdhF1i6uNhp1GvEqNoTIX311CB9hc6eZXpMziTL7PahP4+Siwr8m8ZlKEqRH8tH/ME1cSRy+BNcK8Q4x4KNFLSTOWULOI6tGdYYXS9FbgYdCKZ2vA2/1KsJP/20xVvFo1crOgb+7PLJ1wjw46MuqYh4VpPbTyh+4fW/unxteTtdwYWtFwyXEJ79QyHyLF/x Sf7LAk9/ G5vzH5Pq/CbWX+qCRgVTttr2+JL7VuoX2CKgpeNTXTx66rIV1J/qz2+OiA409jTS9xH79idpaImEEE1VlxkMcS/AQJHTSVSUq1JsZl5WP6wKPQMcllImKiVebuLEgEp0x7FKlQGHOfYYzSYdSM/1sIDGoCETLWnmlh2/HVfci7Zhbg5TPA+waM3oHGykDsN6bjZDsowbLNHAsYmN/xACLV4W+N6ARPwm2sOQqMEyZIzImJbZ6GY/+11jeetD5J6sldymg6pq9udOfXvXnuQPYwqdns8/edKnBh4gCG7kYeGZ9ULpJXUqkGUU+8vBoHdaLHKa1evjB73Zt7QLDymsEmHfJc6Ol4Sbw1Rlil2PBFr3ZrsNeoO4Cbplx2ea4YQK+Bks/PTjvA/RZsfzyaXV+KtmMXEog8f5B5F4Ta73yopY8n+E7HJvUTO9U6y8Jx+eSuyk8A1yJGPGeQRECDbn9QvSlm9/TW9IhPn9OG0ETPlGIU8rTgp/MLyfPjOEg/L/MMvn9ch45sAsAjbIdikNOz+lUqEDK5OBpmeTblRL5CvJBzjAa+zlXGrYYnzkM32RghUoIrLXhPhF4OhRU1XEZcoHPqkEkIwIxSTZ9+Fj2t/YRAULa422T2XM+n8JU3BI5K/LEzZGG8pW78QA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001748, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 20 Jan 2025 at 10:55, Andy Shevchenko wrote: > > Excuse me if I am missing something, but clamp() has a warning inside it, correct? > Why do we need an additional warning on top of that? Note: the warning in clamp() only finds compile-time obvious wrong uses. It's really meant to notice the trivial case where you clam with constants and just got the order wrong, so you do something silly like res = clamp(in, 15, 1); but it does also end up catching slightly more complex things where the compiler can figure out the range of the clamping. The build problem then comes from the compiler doing various *other* code movem,ent and optimization too, and - like in this case - finds an error path where the clamping is done "wrong". I think the real issue in the i915 driver is that it does that WARN_ON(), but then it just happily continues anyway. So if the i915 driver instead did if (WARN_ON(..)) return invalid value; none of this would ever have happened. Linus