From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5706ACD4846 for ; Fri, 22 Sep 2023 16:35:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A91386B02E1; Fri, 22 Sep 2023 12:35:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A41F56B02E3; Fri, 22 Sep 2023 12:35:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 908ED6B02E4; Fri, 22 Sep 2023 12:35:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 807426B02E1 for ; Fri, 22 Sep 2023 12:35:12 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 58E5D1CA4CC for ; Fri, 22 Sep 2023 16:35:12 +0000 (UTC) X-FDA: 81264783264.18.E81D220 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf27.hostedemail.com (Postfix) with ESMTP id 5323D40030 for ; Fri, 22 Sep 2023 16:35:10 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=C0ePjc1W; spf=pass (imf27.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.48 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695400510; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gOhjx56+C1/SUOCT4pJr+RaAn7PBsJsy8c2/c8L0wsg=; b=u0RPS45tEhxYVhCPxifCkFS5VfIAeN+NfSizcVvuqPy8i2XKHUYyZjlMKXIzB4x0YY3u2t wXr7rXEOlfWCrK5B/qgruh6Uq8V8gvsajK81+wHdXf/EMNjur1IWeazXM/xTpcousaL+Iu d5HfZd9/U9AW7WxDeioqwbyDZtBMOzg= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=C0ePjc1W; spf=pass (imf27.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.48 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695400510; a=rsa-sha256; cv=none; b=RZlmMRwaP8sCOvQsmTuOzY+boP/i9Krb/lEWRbSMqmUUT+di6WgKSJhU4FvDebMV1PrPQM u6ac7J1O5Aoady3AjRU8Gy4TWW4rSU9TT+ZVbnVpVLKuz4fpV+t4k0R44qKQUwZ+ek40GY AA2XBMItzEPFfV64GWFwTJDIhRJyAEk= Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-9aa0495f9cfso874646766b.1 for ; Fri, 22 Sep 2023 09:35:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1695400508; x=1696005308; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gOhjx56+C1/SUOCT4pJr+RaAn7PBsJsy8c2/c8L0wsg=; b=C0ePjc1W5XM72YgOWVYjH8gM4DjC2Qvup6aLwFe0qCdvo7eXG02NssLELjB0UjrfL+ Pmxb8TQyemC1xVQRWz88gnqFr2gmsxC7ebYp5738gS94nRx3DaXrMckO04fMsQO3aQvW q4Y+ZCQFr5ci1lU9LUVQfSnqk9fqcblTkOh90= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695400508; x=1696005308; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gOhjx56+C1/SUOCT4pJr+RaAn7PBsJsy8c2/c8L0wsg=; b=S6KlmR+YTTgWnV0BgjN1FjY8ghN8bcCaKHlVmZTYGACvbe4wmljIz1KkaarlvUR7D3 VlMHQkz1fRzCXQ9No2DyEqQs/ZjUDG6Ca9McLgKZb1lKuDzktDzQ7mz/DfEMD078rqRw UCYoqMi7hz2/abTWLsqZalJ6h8Y22lKGKlI1R8fPGwYFdk8kx/+dJHxKHDq+tJt25TUa zVyx0QwX17eK/aFdb+jx89jDpYUCWZMPJUrII6RI4kpcMEFS4bZpQTaWwmYA0fdOcdQ3 KWQKPteHAA9fslCB1qRom6w2EPLYpbRe4xTZeaGgGZ24UA8uci6va9CD9oRYqZ5yaAVo YP1w== X-Gm-Message-State: AOJu0YwCbIuMs1wKN2MvKat7E+d5FzHnkxxC/e4Ux9l6PUILjUO1zOnt qqZpdetk5Q55PUzyLrmzoY+OrNI+YMHnFqmIFWE9Dl/a X-Google-Smtp-Source: AGHT+IERnW2gnpQYoKtK3XgvnijQ2boEw8b9B8wjA08Zzttkl7xRBnCO9WyE1zqSSrJ3ZGyOrxMWcg== X-Received: by 2002:a17:907:ea5:b0:9a1:e0b1:e919 with SMTP id ho37-20020a1709070ea500b009a1e0b1e919mr5057143ejc.4.1695400508466; Fri, 22 Sep 2023 09:35:08 -0700 (PDT) Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com. [209.85.208.49]) by smtp.gmail.com with ESMTPSA id i18-20020a17090639d200b00982a352f078sm2901771eje.124.2023.09.22.09.35.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Sep 2023 09:35:07 -0700 (PDT) Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-51e28cac164so8589100a12.1 for ; Fri, 22 Sep 2023 09:35:07 -0700 (PDT) X-Received: by 2002:a05:6402:27ca:b0:52c:f73:3567 with SMTP id c10-20020a05640227ca00b0052c0f733567mr4854122ede.13.1695400507255; Fri, 22 Sep 2023 09:35:07 -0700 (PDT) MIME-Version: 1.0 References: <20230922120227.1173720-1-dhowells@redhat.com> <20230922120227.1173720-9-dhowells@redhat.com> In-Reply-To: <20230922120227.1173720-9-dhowells@redhat.com> From: Linus Torvalds Date: Fri, 22 Sep 2023 09:34:49 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 08/13] iov_iter: Don't deal with iter->copy_mc in memcpy_from_iter_mc() To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Christian Brauner , David Laight , Matthew Wilcox , Jeff Layton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 5323D40030 X-Rspam-User: X-Stat-Signature: mcfrhzr3xd89oto4c4dyriguf3adhjog X-Rspamd-Server: rspam01 X-HE-Tag: 1695400510-251568 X-HE-Meta: U2FsdGVkX18PbPXqoY1yrp8MWmH4ZtuUbDM131k1ICLGXnm7GJnXP1J5LYNhMWXBVRhBSHda6CK6udSHrwcPoBx/59Lr5Z/T5rXcWvkrgUiP1+oPSxp/YkPXNzjYllZesV+WG8Cgd/+Ao5C5n+bSE946cWhC9XxRe8XTAh2CZBr+r4UCv47FGnbfGWwka85wiSgnxSC3xP1CRNI+U9T4vH+9ZwycsnUXJ9R2JeYelEIyX4mvkAz/eQ/3pe0ff6CMxxOTdr7ZKDjJldLzExL/I09+oTn73HpXJ4bPE5V7qdG1IlPPlCrNX5KymP3HRqsSMeXaBCI3CjbacA+q/inL/jX+vT4/zYJ9ivhm00YLHzpgLg/vW/+KuQeUGHQhz08lzuOGTngpoGvu8CxeDk3CHWR6q9IK1XJkZG6bA7Ct75mmt0ZQc8NnQUhDKP+oTMchz6peuPlJkeRSj2gZfeWS9CV2nlBMvuq8uolOckgabKSYXphX7hF8diGmpCAwGTjykzs31YQocJGykMR0NS5be+fd5kSmSjkLhbCG7eCKzvq7MhTgkWUsZTBfbgDyJrKPUtSzkisxFC1CfhZxYsO4hp7Oli9kVOowHg06sk2+DyotlpmcUR1h6Ybww051Vf7dJksC0dmKaDgYY948QOX54jNtVAZdoLgWgD+QJGyz7bQv0a72jja2K+fyPA5HEaQcdV5gsOS/Z128hGYTU8D/s0R5QXMC/nNiRqMb2JgbX0uzLyp/GaXd55x/df2wh70nT6HRk0cMvNR0yCmKrTtzEZDqtK2RGJAZVR5oO13jwA8tPXW7oEnaoBlQ1w+RRdJamV8uwep5vAAKjjkXe6mXTevjgOSbw2EP+yBVh8JoUCWlIYlSFcwT9N1npgYCRXHe14r3ksdx2hj8ll3H3vKiziFbjePDZq0HSeADPt7+Z6vwZgGIL92B4Su4g8njAH7JJNJuLx9X4XYJshbfVLt p7S5k5Qd sfgmsEKoJzciPdmDc0wAvvZOP13lIHeYAkccTUeLwAhe3np4T0/u8t9sgwFK1dhXX+mX08tk/OhxkxF/+1xcWymyYEXAQ+d36SgZmFgebic3DSACi0VsayBjbW9qdroaBANZPiMhG2iF/5jTnD+zKplPmp04ENF8dh17CsdQfMc0GR0Jgwc2SOlFHRhvBxDw8EyGVSKl20CWMFNzPg3tIgn7RDJvUuq8yZNM5hSqErCM76oQasucRkmgod5b1LkosXDJgiKWojEW22WsQpPQbhUewXiKVB6Kq60M1x+PgTCotiKn6uQL+03lQxKlcw9nskXOePYeSP9JQGRXbqYyVXNTF/7vaLSeg8bXxf7ijW78OheLtT0Wj1sx2ts7NIR2sF2wQiUi28wLZtaMEvfGamVNAdtRLC/RkwUbELyvBZVfgRUO9/LNkCY1W6i3f4ih57apP7vs/ZDdXrcrDHDhO3jGFQhpVSwjJWCLKFHp996OyOicmZQJQgdpZvQMdYCjPUtCmHbPMy3F4JFti5XrummtL6T2X4BabgG1DdteFpdrVT6iLZjChp/QNiuDgdCaABEng X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 22 Sept 2023 at 05:02, David Howells wrote: > > iter->copy_mc is only used with a bvec iterator and only by > dump_emit_page() in fs/coredump.c so rather than handle this in > memcpy_from_iter_mc() where it is checked repeatedly by _copy_from_iter() > and copy_page_from_iter_atomic(), This looks fine now, but is missing your sign-off... Linus