From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC312C433F5 for ; Tue, 10 May 2022 17:18:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3EC396B0071; Tue, 10 May 2022 13:18:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 39AC96B0073; Tue, 10 May 2022 13:18:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23B236B0074; Tue, 10 May 2022 13:18:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1400A6B0071 for ; Tue, 10 May 2022 13:18:20 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DC56332301 for ; Tue, 10 May 2022 17:18:19 +0000 (UTC) X-FDA: 79450491918.03.7BFF5F2 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf28.hostedemail.com (Postfix) with ESMTP id 0DD41C009B for ; Tue, 10 May 2022 17:17:58 +0000 (UTC) Received: by mail-ej1-f45.google.com with SMTP id kq17so34319999ejb.4 for ; Tue, 10 May 2022 10:18:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1zNOhYhMmOf2oC+35ttTupc2oZM3Rq+mPFR6uZmiyWs=; b=SVtOS8E/bEl5utAGPbNiPoiwfX4boLQX+OlSQkP6h30LngrZXUTEQwcWzn0S2n95U/ o6sPQWgS4PKMB+Wl41tlBAJEC00agmRTO86/bMz3y/tZXrfw/STez1ah+3+0AEd97gq9 39C5HSNM+CjnCJc8Wj5JyVL/bXtjI9OJ7aX0U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1zNOhYhMmOf2oC+35ttTupc2oZM3Rq+mPFR6uZmiyWs=; b=7FI28vNerSgzTFCLDMdX2Tqz/yF3S90k23ReBGNtOWPLwuRi8IMdqkGzO2gBz5VWhD ET9woELgHIArj8thgdJLYI8QNkYoPpkYYjH00hKeovBRqf8Oatp3iCCEgCXbGoaM6P+h pZtSj7eKkyGSVfxMX2G4z7o311S6GV26pYkKhTkggsSu5JrmB8tLQi8+OQV9zMycH5uE iv1hl/Nolbtf9qdiUfqxKnzJTtTOrDn8zjrohUkQMjvJOUV2QHkaJSbdNs/TBHhxC0xS tBG5PM1GGLtwI3KquarqGubyRzUYIkGlEIFRRnksPZXXTsND+g/thJL9hpwNaNp0elHs hUjg== X-Gm-Message-State: AOAM531XL2Q/YLXDc4zV7Wd9zKzxjRtIux93elpyw6+0POsZtCAr3B+0 K1ObhCqrLgwpzcVqs1tbvYKDlL5EELeiEhDU X-Google-Smtp-Source: ABdhPJyx/PuBATHGI7bSkrdy3DtTyl3l/ym2hu71thtBnUgH08lQ/1KyoWnfPB57dEUDW7RiTL+Cvg== X-Received: by 2002:a17:906:314b:b0:6d6:da31:e545 with SMTP id e11-20020a170906314b00b006d6da31e545mr21333225eje.125.1652203096592; Tue, 10 May 2022 10:18:16 -0700 (PDT) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com. [209.85.221.41]) by smtp.gmail.com with ESMTPSA id er10-20020a170907738a00b006f3ef214ddesm6345030ejc.68.2022.05.10.10.18.14 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 May 2022 10:18:15 -0700 (PDT) Received: by mail-wr1-f41.google.com with SMTP id e24so24754428wrc.9 for ; Tue, 10 May 2022 10:18:14 -0700 (PDT) X-Received: by 2002:adf:ec08:0:b0:20a:d39d:6ab6 with SMTP id x8-20020adfec08000000b0020ad39d6ab6mr19343203wrn.442.1652203094068; Tue, 10 May 2022 10:18:14 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Tue, 10 May 2022 10:17:58 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: clear_user (was: [patch 02/14] tmpfs: fix regressions from wider use of ZERO_PAGE) To: Borislav Petkov Cc: Mark Hemment , Andrew Morton , "the arch/x86 maintainers" , Peter Zijlstra , patrice.chotard@foss.st.com, Mikulas Patocka , Lukas Czerner , Christoph Hellwig , "Darrick J. Wong" , Chuck Lever , Hugh Dickins , patches@lists.linux.dev, Linux-MM , mm-commits@vger.kernel.org, Mel Gorman Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 0DD41C009B X-Stat-Signature: ur8ai31iikwtweb4nnehtm7za1ywykei Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b="SVtOS8E/"; dmarc=none; spf=pass (imf28.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.45 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-Rspam-User: X-HE-Tag: 1652203078-157424 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 10, 2022 at 2:31 AM Borislav Petkov wrote: > > > I haven't really done serious profiling work for a while (which is > > just as well, because it's one of the things that went backwards when > > I switch to the Zen 2 threadripper for my main machine) > > Because of the not as advanced perf support there? Any pain points I can > forward? It's not anything fancy, and it's not anything new - you've been cc'd on me talking about it before. As mentioned, I don't actually do anything fancy with profiling - I basically almost always just want to do a simple perf record -e cycles:pp so that I get reasonable instruction attribution for what the expensive part actually is (where "actually is" is obviously always just an approximation, I'm not claiming anything else - but I just don't want to have to try to figure out some huge instruction skid issue). And then (because I only tend to care about the kernel, and don't care about _who_ is doing things), I just do perf report --sort=dso,symbol and start looking at the kernel side of things. I then occasionally enable -g, but I hate doing it, and it' susually because I see "oh damn, some spinlock slowpath, let's see what the callers are" just to figure out which spinlock it ls. VERY rudimentary, in other words. It's the "I don't know where the time is going, so let's find out". And that simple thing doesn't work, because Zen 2 doesn't like the per-thread profiling. So I can be root and use '-a', and it works fine, except I don't want to do things as root just for profiling. Plus I don't actually want to see the ACPI "CPU idle" things. I'm told the issue is that Zen 2 is not stable with IBS (aka "PEBS for AMD"), which is all kinds of sad, but there it is. As also mentioned, it's not actually a huge deal for me, because all I do is read email and do "git pull". And the times when I used profiling to find things git could need improvement on (usually pathname lookup for "git diff") are long long gone. Linus