From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDDBAC433F5 for ; Fri, 30 Sep 2022 19:43:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A5096B0073; Fri, 30 Sep 2022 15:43:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2550B6B0074; Fri, 30 Sep 2022 15:43:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11BE88D0002; Fri, 30 Sep 2022 15:43:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 040976B0073 for ; Fri, 30 Sep 2022 15:43:17 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C6C8C161023 for ; Fri, 30 Sep 2022 19:43:16 +0000 (UTC) X-FDA: 79969775592.15.E14F974 Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) by imf02.hostedemail.com (Postfix) with ESMTP id 4365C80012 for ; Fri, 30 Sep 2022 19:43:16 +0000 (UTC) Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-131fd187e35so2890855fac.7 for ; Fri, 30 Sep 2022 12:43:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=8CE3Iabg2NpyHioPDddF/UlYh7dtUO0nVnT8qt44FKI=; b=IC84e+qgneQiadY8Da1KC/ooqTpFF7UZWB7qFQEKvywWBk74UdwDLIsNAhG/qWUz3/ UR22fTaoR10FzZzcDj3COGzOTQnHM5GAqAHvLhPmQuZDMk7XWJ/3j1FQ0wI3JD0vxoh+ RCmQDj0UW6zI1HUIR7hGP9y0aghmCZxDP8/mQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=8CE3Iabg2NpyHioPDddF/UlYh7dtUO0nVnT8qt44FKI=; b=jR6IHBefSbwCOs7MfV+WKDjSQj2XPVg4pExxFSMxtcxF7KILwmXC3SSeMwtqCK/24U Ja9dafJY5e6UVlVEN3QfZMcxr04b9AzRqcuUpCFE3RpLitHBNqgxnHR1OacD103LMGpB rJ14EfBxiRkWCkqY5/bpOUGfNdl8BYowin7GGktYtb/q7cV+xR6IH64PqAYEhELZkaLQ RQTuKPWYD78hewoTe5e2tsRomHmr3wlGIXNn06uWe5/xZ+1s8UkWogpwDsDfDhXqsPAr vfddwmnnc2/YNLDJdx+PVEWyunXEAqKUy0aVDsdFi0n/z0FteepblsgpgIbrQSXjDP2i n4yg== X-Gm-Message-State: ACrzQf01UTDtvI0986ZY+5+98XdIiQbZQOZ7EWd1Ikr7p+qOoDVnysCg SuFA5vi/4wwqXezQO2fgt0waIYJ4x/9q8A== X-Google-Smtp-Source: AMsMyM50sjqPllo6z21OfkD/OasooEaG8vjdMnTypuUIojhJNmLgoGLaQ/rWT3lHxUeHCkNRtje/xA== X-Received: by 2002:a05:6870:4714:b0:131:b107:5eba with SMTP id b20-20020a056870471400b00131b1075ebamr7744546oaq.91.1664566994920; Fri, 30 Sep 2022 12:43:14 -0700 (PDT) Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com. [209.85.167.173]) by smtp.gmail.com with ESMTPSA id y9-20020a056870e3c900b0012d6f3d370bsm902845oad.55.2022.09.30.12.43.14 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Sep 2022 12:43:14 -0700 (PDT) Received: by mail-oi1-f173.google.com with SMTP id v130so5764915oie.2 for ; Fri, 30 Sep 2022 12:43:14 -0700 (PDT) X-Received: by 2002:aca:b957:0:b0:351:4ecf:477d with SMTP id j84-20020acab957000000b003514ecf477dmr4491126oif.126.1664566561733; Fri, 30 Sep 2022 12:36:01 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Fri, 30 Sep 2022 12:35:45 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 07/10] crypto: Use ARCH_DMA_MINALIGN instead of ARCH_KMALLOC_MINALIGN To: Catalin Marinas Cc: Isaac Manjarres , Herbert Xu , Ard Biesheuvel , Will Deacon , Marc Zyngier , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Linux Memory Management List , Linux ARM , Linux Kernel Mailing List , "David S. Miller" , Saravana Kannan , kernel-team@android.com Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664566996; a=rsa-sha256; cv=none; b=kyVRjWxK2sIwR67J2ASaGuhU6iiJcQK9RCTZ0Spj8swbOWt0DPx1csUls6PMbQplRytzgS OVV3Nmi+rxqe/D0mtt+HdA59vsZvpp+P6Sw44ikVRB9byUACePG+LQFC38ynNrGKsyLY1+ S5S4K9/pENbmxZdtvG9FfdMSt3F9UKQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=IC84e+qg; dmarc=none; spf=pass (imf02.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.160.41 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664566996; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8CE3Iabg2NpyHioPDddF/UlYh7dtUO0nVnT8qt44FKI=; b=h+UMZhagyvv39+mjT2um1Do80d4Vub6+3ZfIwdqbqG0JiGRndHWhB/Km1x/zDJlFhk07Qg T/ASaoNnh5nN+e91abeb+NZvN39m7k67WCZ23K4jfyhX4QV7+SNFIQbNzSEAxVXlXna3zH KoiMFUJA5bj0uV40iEUeNt42yfF4VWY= X-Rspamd-Queue-Id: 4365C80012 X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=IC84e+qg; dmarc=none; spf=pass (imf02.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.160.41 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-Rspamd-Server: rspam03 X-Stat-Signature: mgcmjmbj7aym6k4tat6q3gsfdrq7fn48 X-HE-Tag: 1664566996-659605 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 30, 2022 at 11:33 AM Catalin Marinas wrote: > > I started refreshing the series but I got stuck on having to do bouncing > for small buffers even if when they go through the iommu (and I don't > have the set up to test it yet). May I suggest doing that "force bouncing" and "change kmalloc to have a 8-byte minalign" to be the two first commits? IOW, if we force bouncing for unaligned DMA, then that *should* mean that allocation alignment is no longer a correctness issue, it's purely a performance one due to the bouncing. So then the rest of the series should be about "ok, this is actually a hot enough allocation that I want to force alignment", and be purely about performance, not correctness. No? Linus