From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B640C3DA7F for ; Tue, 30 Jul 2024 22:44:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 126AA6B0089; Tue, 30 Jul 2024 18:44:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D7466B008A; Tue, 30 Jul 2024 18:44:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE1296B008C; Tue, 30 Jul 2024 18:44:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CCC9A6B0089 for ; Tue, 30 Jul 2024 18:44:41 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4D9E7120132 for ; Tue, 30 Jul 2024 22:44:41 +0000 (UTC) X-FDA: 82397899962.13.F48C863 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by imf08.hostedemail.com (Postfix) with ESMTP id 2BABF160008 for ; Tue, 30 Jul 2024 22:44:38 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=IFGZHv1F; spf=pass (imf08.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.52 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722379475; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aVok3QjVVn6gnM13EoNxYFfbYWcnFAKc2fMvNq85Bsk=; b=J7tdVDrlB/sS5qE9KLvy3HH8gmQ+VghuBjXdcdhSlhYpIkhV+oTTN9mbavhWGS/ajCZRW/ jICTUnm+aTmWE0UgBU6QyHWbmv8+yr9ifG8HGDDnzgWgMQaw50HQaaAjawUqj0VDTAnv4K vVidDkM3eZxA0PPmU/4YYtwR0eQlyao= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=IFGZHv1F; spf=pass (imf08.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.52 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722379475; a=rsa-sha256; cv=none; b=FfCZ3vbi2vrwtDMjtwrttTuRZmWMUxtzZ5AzexfFz7BBDVT/a/duyG8yfTWkW9rnoSSVGb uwV5bDrw6Co+VmBS7yqGaM4mdrUoNGSIeH8P44eDDfbdXI8/gC/OpyU9S+ClYmXEBVvnce 3/QPXn+D1qZd5x7asImSdHV7LGHDMo4= Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-52efd530a4eso8010246e87.0 for ; Tue, 30 Jul 2024 15:44:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1722379477; x=1722984277; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=aVok3QjVVn6gnM13EoNxYFfbYWcnFAKc2fMvNq85Bsk=; b=IFGZHv1FivTh+qnQlXzdtaGDqKvzkP4X6WZB1GMZUQXBqtxJm6USpzOVSJES01/T8a nkcrxz9XtqxeZ90Zzgbwg03Wr+j8JKc3zuxL6teh9lzkmUhCgHPbxDaufU73ESonkjil XhhXrfUl8cghN/b/mzZ62xWdJyr2sIKBeKuWs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722379477; x=1722984277; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aVok3QjVVn6gnM13EoNxYFfbYWcnFAKc2fMvNq85Bsk=; b=RWki6gnOM+BL8Z6Ae9Nj6PhGngG+dScxK48LTax44OuNbUjLxbdo/IfqV+tNv/9U+D TbXF6wmPf8/RYB2QLMjRap4dSwKL/w/yIGNSqX3vTvnAiRuksqW8AIhfIpUgvChxXnpz J9zvy3exDB0aXr/VHRimeY8lPD6x+MMI+LKe58VUwUxX3c5rHmf/2jyV67QK1RUXR2xM EZccNSm/BR8y6LOYYwydvoj1Bfo8r8gywuXQUXUHDJM+1jnyv4svKr1NeDhm0KjyeyDa 7Xofy/cl6SjedrM/xMVJ07768B2tIAGa8gxbeptC1skSaopYse5JsERBRJZU7Mv5J73B WLvw== X-Forwarded-Encrypted: i=1; AJvYcCXK3qNJ+QxkNK9gam3CdorqafM9fPCtBJR4dJZPOqhFKMdhA3Oxmt4SvoIpysM+YCSuQxqLMEdoTpVrK7hDL/odPzg= X-Gm-Message-State: AOJu0YwkZ5sYtMx3CW5QrNkJ4bv+7ithppXIuUAMFDvW9dh/MEK2XUWO 67i0bUJjTMyrfBJtJ7VMla5rN5kplEgZMBqbrOYrC3oL/3oRICHRheaBtxp0ZrnlxgLV8Wa+yf+ rSnNZWg== X-Google-Smtp-Source: AGHT+IEQPg/mo8W9f7DkvIK6yMOHZpn8eVPqW5hb9s8fmuQnX8h7fa4DFnIpKCyjBJodPVsrp8UXdQ== X-Received: by 2002:a05:6512:3b26:b0:52e:fd53:a251 with SMTP id 2adb3069b0e04-5309b2de601mr10357167e87.59.1722379476847; Tue, 30 Jul 2024 15:44:36 -0700 (PDT) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com. [209.85.208.169]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52fd5c081ddsm2031337e87.132.2024.07.30.15.44.34 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jul 2024 15:44:34 -0700 (PDT) Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2ef27bfd15bso70712891fa.2 for ; Tue, 30 Jul 2024 15:44:34 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWYhvLWAlOCwRWj+8s+Gg6Rzyeg/G5E4hRCUNOpl5PDeNn4LCPn7S5JTd6PH6wNzMikQHYM9HoN9iqfVvko/T8QEhY= X-Received: by 2002:a05:651c:4ca:b0:2ef:1db2:c02c with SMTP id 38308e7fff4ca-2f12edf9d3bmr106863941fa.10.1722379474221; Tue, 30 Jul 2024 15:44:34 -0700 (PDT) MIME-Version: 1.0 References: <402c3c617c29465c898b1af55e3c6095@AcuMS.aculab.com> <5cd3e11780df40b0b771da5548966ebd@AcuMS.aculab.com> <8111159a-c571-4c71-b731-184af56b5cb1@app.fastmail.com> <73d65e2553e543069f9969ccec4ea9b3@AcuMS.aculab.com> In-Reply-To: <73d65e2553e543069f9969ccec4ea9b3@AcuMS.aculab.com> From: Linus Torvalds Date: Tue, 30 Jul 2024 15:44:16 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/8] minmax: Put all the clamp() definitions together To: David Laight Cc: Arnd Bergmann , "linux-kernel@vger.kernel.org" , Jens Axboe , Matthew Wilcox , Christoph Hellwig , Andrew Morton , Andy Shevchenko , Dan Carpenter , "Jason A . Donenfeld" , "pedro.falcato@gmail.com" , Mateusz Guzik , "linux-mm@kvack.org" , Lorenzo Stoakes Content-Type: multipart/mixed; boundary="000000000000bb9224061e7eb857" X-Rspam-User: X-Stat-Signature: 8awpet1st4qf4hg3yngbnbw5o55t31z1 X-Rspamd-Queue-Id: 2BABF160008 X-Rspamd-Server: rspam11 X-HE-Tag: 1722379478-520315 X-HE-Meta: U2FsdGVkX1+GfstRJ5qKHtP0tKcSwTwNkFz59v7Zb9SgEznphcjZH4GGwelw6E0yxdEYVBRAeCFDqLcucmuNEJEVTUFX6rXFlxhXnP7GK6j02dPhtZzfxk0j5AfUbYjG+yShIOCqgrIt6QfoZ6Zh/zhNWV9uoURIX6D5KlRG393ioWV4khaqiFbXpSzh33iOMLxqk+YgGiA57jBVBRfg4SUSSE2NHjOqF1qGtWSknQaVh1WEmNJ0QYprE4jcaywtKfVR0ThPUc9ru4RM9hbAzK4Mu1oq7hIrpYYRr2/zufza/l1q6OptOBBbC+zEi9nLzaPN5YpZ0yE0YM4tX0zEeXWRtefJ+cxu8I33Nq/A0NrwMrjE1sPXe47yBag8GyhtTsfEiF6EuXi/seNcR4ZvyJpIXeUI+EzW2chfaLcFbAH1C02GAA7V+iZH3KBFCcqDnouDNcGw66JWFoalNcfx2t2tTJOlX/MZ9a61iHRBwZuNU6A+9HebBJLU8qn1waCWUaU++HIfO+HdD/+Pgwu3OWP8D0L5FTOHe5UQKgkhVkjroqb1wY01Qd0ImtxURHmY2d5DMYsPhXsEOuI3JpUawl9T8il30/S2daGzkhxQ5EWl+/rbe6Nrvu1kcTw15lD5IHxzeFvJ/W7W2rR8Gv9PcOSH+DPVBQUfTie7za5X9xyv9VxWoBlPWO8aJXkWm2nEd41KeiSzQkO1TW7yfTqrzNAp5SwUgASLh7i0VoPLYExDis/dV22t/3uVoo3NV/JH4oADRpknZbCV93Mxh4W+eL2ZgkjfD3hpWfib9viYtprwCP1lcApfgSJvCoWxf4MOT7TWyk9nh6rTjM0lqhmVNU6c0fBf3UdQI2uyWvCsx/Fe9yPQEsi1UVdqZSYzOFJ6GlvHAHwrzY+cyNUY27bfbjCwzfLmKCwd/8g15GIasP3tYtI1z95/KiBGllhHOCsEg5QbP97SPZQHS6C3JFi qyQT5nVM T1W2qqRH0SI7KRVAERx4XvzWJUNzgXX2l0pCxqiq0hXScWFMK85Gw5QCOYhBAFG2ICMjN9A6vP1b11m4pnjATkRQgEVSo1P3+JRPIWLhcX8Z9Vjhor2+u6ApluWpEb/+a7tsi7zca7V9ejt7MklAZNqolrALGsqcYHAuK1gIa8jW9D72YRIkTcRVSUn7GyrUBTxKx/OqcyBjMgrCIeMAgJMQzT5/Pgq3rjnmKEox0fM49zkEZ2gYVFrJcTmaTvnfuGKLg4X8IvwD85Os5ELEbOFS2I9KEmZTN7+otobjJAIMudadyKvODs84tyMyJKAlCf+AiyjkWwyE7gJR5LvZeu6gSHPHRJIR2iA85w7G3FNoJ8KsZ8PFmzA1HNxduWiq/bhWABWNjwLRxf24wGgEjSAzPcpdgQMJDWBxwOna30c40lBqm/ENTRjjUEtoMrFosiGyUgPoLdYViJuHiAJ59oWdkROk4DzDSg5bUE4Mh9ibLaij+5qCghhJdtKCLE1MyWEV0tOXbM5bCyErHcOZ52mW8C3KUIsLrF4eucgZ79TMDvy0+Cyjw5pD7nA15iJbmub7gL/uDj4GVherrU0irV7tcNiFTy4krEqn7eTyscXFk1fGWhT6xgmHCJk8p5PXFBHDrnNxWjetDJMV2kTMQwDu8Pve7VYz3fOElJE7Oe1ThheFc+Iag4GDvjBdR5w9ck1AsobGR3UJ6U6013s/WQBwzsQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --000000000000bb9224061e7eb857 Content-Type: text/plain; charset="UTF-8" On Tue, 30 Jul 2024 at 14:48, David Laight wrote: > > Have you a plan to 'fix' min3() ? I didn't have a test-case that showed it being a problem, particularly after min() no longer expands exponentially, but maybe something like the attached would work? All the infrastructure is in place for it, this just uses it. Does this work for you? Was there some particularly bad case you were looking at that I missed? Linus --000000000000bb9224061e7eb857 Content-Type: text/x-patch; charset="US-ASCII"; name="patch.diff" Content-Disposition: attachment; filename="patch.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lz90996r0 IGluY2x1ZGUvbGludXgvbWlubWF4LmggfCAxMiArKysrKysrKysrLS0KIDEgZmlsZSBjaGFuZ2Vk LCAxMCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2luY2x1ZGUv bGludXgvbWlubWF4LmggYi9pbmNsdWRlL2xpbnV4L21pbm1heC5oCmluZGV4IDQxZGE2Zjg1YTQw Ny4uOTgwMDhkZDkyMTUzIDEwMDY0NAotLS0gYS9pbmNsdWRlL2xpbnV4L21pbm1heC5oCisrKyBi L2luY2x1ZGUvbGludXgvbWlubWF4LmgKQEAgLTE1MiwxMyArMTUyLDIwIEBACiAjZGVmaW5lIHVt YXgoeCwgeSkJXAogCV9fY2FyZWZ1bF9jbXAobWF4LCAoeCkgKyAwdSArIDB1bCArIDB1bGwsICh5 KSArIDB1ICsgMHVsICsgMHVsbCkKIAorI2RlZmluZSBfX2NhcmVmdWxfb3AzKG9wLCB4LCB5LCB6 LCB1eCwgdXksIHV6KSAoewkJCVwKKwlfX2F1dG9fdHlwZSB1eCA9ICh4KTsgX19hdXRvX3R5cGUg dXkgPSAoeSk7X19hdXRvX3R5cGUgdXogPSAoeik7XAorCUJVSUxEX0JVR19PTl9NU0coIV9fdHlw ZXNfb2szKHgseSx6LHV4LHV5LHV6KSwJCQlcCisJCSNvcCIzKCIjeCIsICIjeSIsICIjeiIpIHNp Z25lZG5lc3MgZXJyb3IiKTsJCVwKKwlfX2NtcChvcCwgdXgsIF9fY21wKG9wLCB1eSwgdXopKTsg fSkKKwogLyoqCiAgKiBtaW4zIC0gcmV0dXJuIG1pbmltdW0gb2YgdGhyZWUgdmFsdWVzCiAgKiBA eDogZmlyc3QgdmFsdWUKICAqIEB5OiBzZWNvbmQgdmFsdWUKICAqIEB6OiB0aGlyZCB2YWx1ZQog ICovCi0jZGVmaW5lIG1pbjMoeCwgeSwgeikgbWluKCh0eXBlb2YoeCkpbWluKHgsIHkpLCB6KQor I2RlZmluZSBtaW4zKHgsIHksIHopIFwKKwlfX2NhcmVmdWxfb3AzKG1pbiwgeCwgeSwgeiwgX19V TklRVUVfSUQoeF8pLCBfX1VOSVFVRV9JRCh5XyksIF9fVU5JUVVFX0lEKHpfKSkKIAogLyoqCiAg KiBtYXgzIC0gcmV0dXJuIG1heGltdW0gb2YgdGhyZWUgdmFsdWVzCkBAIC0xNjYsNyArMTczLDgg QEAKICAqIEB5OiBzZWNvbmQgdmFsdWUKICAqIEB6OiB0aGlyZCB2YWx1ZQogICovCi0jZGVmaW5l IG1heDMoeCwgeSwgeikgbWF4KCh0eXBlb2YoeCkpbWF4KHgsIHkpLCB6KQorI2RlZmluZSBtYXgz KHgsIHksIHopIFwKKwlfX2NhcmVmdWxfb3AzKG1heCwgeCwgeSwgeiwgX19VTklRVUVfSUQoeF8p LCBfX1VOSVFVRV9JRCh5XyksIF9fVU5JUVVFX0lEKHpfKSkKIAogLyoqCiAgKiBtaW5fbm90X3pl cm8gLSByZXR1cm4gdGhlIG1pbmltdW0gdGhhdCBpcyBfbm90XyB6ZXJvLCB1bmxlc3MgYm90aCBh cmUgemVybwo= --000000000000bb9224061e7eb857--