From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47A23C433F5 for ; Fri, 1 Apr 2022 19:01:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 843FD8D0001; Fri, 1 Apr 2022 15:01:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F3396B0072; Fri, 1 Apr 2022 15:01:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6935B8D0001; Fri, 1 Apr 2022 15:01:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0058.hostedemail.com [216.40.44.58]) by kanga.kvack.org (Postfix) with ESMTP id 57DCB6B0071 for ; Fri, 1 Apr 2022 15:01:38 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1B55BA78DD for ; Fri, 1 Apr 2022 19:01:28 +0000 (UTC) X-FDA: 79309228656.31.D2C8F41 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by imf28.hostedemail.com (Postfix) with ESMTP id 97E1EC001F for ; Fri, 1 Apr 2022 19:01:27 +0000 (UTC) Received: by mail-lj1-f170.google.com with SMTP id by7so5207818ljb.0 for ; Fri, 01 Apr 2022 12:01:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oDw8S5KrFCWwz/lG5l+hXBDsrtf0IQ3Qu1r88NhJ04Q=; b=JO2RfQc0LSop+AwFNQt7LZomcriv9oithuEpIPz1RWcT7BtDWwYWEllPLjFCJk/+B5 NpRbbmfBwT/y4YIiiLNkzwmiDVep2a32Q1EfobrHj1iVl+veNANmaIf7pwi6LGT5oaBS HzFohZtFV5xDxWv2+R58A5YDtFJbjZX65VapA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oDw8S5KrFCWwz/lG5l+hXBDsrtf0IQ3Qu1r88NhJ04Q=; b=1YdiqzHohdl5dCuNfYpa+TcsSHjMduQO7dg/bnp7VJIkQQuRLlM7VX/1lHFp200GEf tHS8sixGciPis9Ek1h8J+H+P1h5PJfMuzJUW8s/rRESeT3d5nYF8HAmYOsv+t5Y8GmYB 8rJM7kTd4s+z2cXxwTBCshDF7zl8CQdHv0AFJ7lJEhFGpVAeZVFkonvMwxiO9FbGVZr+ go+oBBsSAqdWXkbhcu2sLqTvMR0LaKoY3qAglaaxgApKiYMh6RY04SVgxcv1UwcEOqat L7FG1gkweIFXca6oOO9HO9mor+Ags7avv0ptvFQ4vxT2MikUI9s3o3MC2j2sEaMuR/S3 5lcQ== X-Gm-Message-State: AOAM530/nLs3FqlR0PC5iddgyGWnLfSTrCKq7CRpPuk0MHkpSjmTv1q1 RW0pvYSo18wglUZudLnBm0QKZCUl3tgjIca4mQY= X-Google-Smtp-Source: ABdhPJwfQdRyWdXarZ3Jt3Lsd6HKKOaKwsj8Tti5wNBYSx6pm8kOwEz5OsSOu1H/ud9Zj4ZaIeQirA== X-Received: by 2002:a2e:7c14:0:b0:24a:fefe:bba7 with SMTP id x20-20020a2e7c14000000b0024afefebba7mr3658669ljc.272.1648839685448; Fri, 01 Apr 2022 12:01:25 -0700 (PDT) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com. [209.85.167.43]) by smtp.gmail.com with ESMTPSA id z26-20020ac2419a000000b004484bf6d1e6sm318333lfh.233.2022.04.01.12.01.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Apr 2022 12:01:24 -0700 (PDT) Received: by mail-lf1-f43.google.com with SMTP id t25so6568471lfg.7 for ; Fri, 01 Apr 2022 12:01:24 -0700 (PDT) X-Received: by 2002:a05:6512:b12:b0:44a:ba81:f874 with SMTP id w18-20020a0565120b1200b0044aba81f874mr11728022lfu.449.1648839683880; Fri, 01 Apr 2022 12:01:23 -0700 (PDT) MIME-Version: 1.0 References: <20220401181109.1477354-1-zi.yan@sent.com> <20220401181109.1477354-2-zi.yan@sent.com> In-Reply-To: From: Linus Torvalds Date: Fri, 1 Apr 2022 12:01:07 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/2] mm: wrap __find_buddy_pfn() with a necessary buddy page validation. To: Zi Yan Cc: Linux-MM , Steven Rostedt , David Hildenbrand , Vlastimil Babka , Mel Gorman , Mike Rapoport , Oscar Salvador , Andrew Morton , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=JO2RfQc0; spf=pass (imf28.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.170 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Stat-Signature: 8sskshm3uaqd58f9nfzi8j9bux44kegp X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 97E1EC001F X-HE-Tag: 1648839687-906898 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 1, 2022 at 11:56 AM Zi Yan wrote: > > How about the patch below? If it looks good, I will send v3. I can't see anything worrisome, but by now I've looked at several versions and who knows what I'm missing. Making it inline and allowing a NULL 'buddy_pfn' pointer for the cases that don't care might be an option, but I don't think it matters hugely. Linus