From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 456D4C3DA64 for ; Sun, 28 Jul 2024 19:55:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92E0B6B0089; Sun, 28 Jul 2024 15:55:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DDBA6B008A; Sun, 28 Jul 2024 15:55:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CE336B008C; Sun, 28 Jul 2024 15:55:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 61DD96B0089 for ; Sun, 28 Jul 2024 15:55:29 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D57CAA01E3 for ; Sun, 28 Jul 2024 19:55:28 +0000 (UTC) X-FDA: 82390215936.09.45C6A98 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf25.hostedemail.com (Postfix) with ESMTP id 9ED1AA000D for ; Sun, 28 Jul 2024 19:55:26 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=A1sZi1Af; spf=pass (imf25.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.54 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722196523; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bso3oc3/1moVUnYBS/9tcxc93Inl8H8ROTrw4KGIFu4=; b=mhh/iooXBubt/5Iiryd7SjhayhUEDbPNNCI1SQhZwVHi1JJFcWzGH0laS8sgx/LBi0usqm St3XjzxRr0eiL3+8eL555/BEk+cf8rCyP1NTyfdvgLsw8/zlbc9imvXmn6FZEQUHCsOxKZ 5x8IDGRP7vjT2vYgN9utFuFaywVqaUs= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=A1sZi1Af; spf=pass (imf25.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.54 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722196523; a=rsa-sha256; cv=none; b=RmPi2eIgJM1nz9bQXAd5Ek8XGNEzvNbnCPfp4o1kcamYDEe1GmvDmB7nMxc+Z1zYDM9tyR qYzN8E63R/9bxIvVtsXFs5QR8/+R+IPXxMMxLcIdQnlOUHexEgX3QtvuZK2dPBZ05OWWj3 Xw/3lloKgchYo/d4MCdOlP72xUwAEf0= Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a7aa212c1c9so394785066b.2 for ; Sun, 28 Jul 2024 12:55:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1722196525; x=1722801325; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bso3oc3/1moVUnYBS/9tcxc93Inl8H8ROTrw4KGIFu4=; b=A1sZi1AfJ7OneY+l8hYfryHmgYOH3SNWWKMf7CsHA9ZOEhffsSl2WD0Pi8Q4NI51+4 KsL2XxvFdS6tWwsvlzNG3F0ZJBuFqpSgUtOG4t0OFp036fet0I6mjA3d1Am9pf++AVSs SL3LIFRcDmaoaqKtl/FJU2lq/199oeFu7MG/4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722196525; x=1722801325; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bso3oc3/1moVUnYBS/9tcxc93Inl8H8ROTrw4KGIFu4=; b=gMQdY9Kn+40rxDbnCxDPwSdyfGSZ2Yj/r3Ob88m/T+ySHEvoO+BTltT+L/IBWJQnXr bPuFGE2QuPL7lgOlWMf1OfByKf66oM2VVJGGYcTvq4xsm25lAFJZiypUVfewzoUCZyp4 Tf+2FHYhmC0XQ0Jewnnv4xwDxs0ORrVtwBTyR5eKdNlFk450qp19BW78rGvuUKKDwCT0 fWlr4NJdwmufPcvM2gPMkJnnDmMQt5ZKywnnMnAunIyBtSgBGrNalYe6txfv/4v9Ovjg OZ+A85iuy1kTGWIRFDjrliRtNv26cPLDUxUP0SufK2+0rWYGXUdBtWRvdtMtkBYEjuvS fdrw== X-Forwarded-Encrypted: i=1; AJvYcCUMsj9OsQlAPTKlzWw7U6bM+2LDOnRsqkNc16ijPUvlM3iOYScTTDVV5zgo6aCuW0j8Y893kEvoSJzKek0rFOg/Dzk= X-Gm-Message-State: AOJu0Yy5aw7Fk/oMcbEK238sHygWaRegzpkbkQubYuMTAk1NJEnnRhNw dtHS4nsFTeA2ilpzs7Q6SMkeydPCiUdodeFloyTsBHnCI1gE5e0YrqnmAjPVJBOSynA9UYDYTRu vfUGn3A== X-Google-Smtp-Source: AGHT+IFrZ/LXeTdn3hT0Jld1uqL6esZU1xLTZy9quQyhaDwyMP8WFVnS1QNq3Seea+Faj3xPGRIarw== X-Received: by 2002:a17:907:3e1a:b0:a7a:8e98:8911 with SMTP id a640c23a62f3a-a7d400d7295mr397323866b.38.1722196524749; Sun, 28 Jul 2024 12:55:24 -0700 (PDT) Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com. [209.85.208.48]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7acad91eeesm424073766b.178.2024.07.28.12.55.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Jul 2024 12:55:24 -0700 (PDT) Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-59589a9be92so4449062a12.2 for ; Sun, 28 Jul 2024 12:55:24 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWPt7AOChqkPKcgywAnKKeXpzCv5oBmaN2J6I+vlD2N1GAXDCORafpTPGf4Wt3nHJF4ZKtvRUVWwxKESJnbtgvkOjU= X-Received: by 2002:a50:9318:0:b0:5a1:c43:82ca with SMTP id 4fb4d7f45d1cf-5b021f0d87bmr2806527a12.26.1722196523942; Sun, 28 Jul 2024 12:55:23 -0700 (PDT) MIME-Version: 1.0 References: <402c3c617c29465c898b1af55e3c6095@AcuMS.aculab.com> <5cd3e11780df40b0b771da5548966ebd@AcuMS.aculab.com> In-Reply-To: From: Linus Torvalds Date: Sun, 28 Jul 2024 12:55:06 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/8] minmax: Put all the clamp() definitions together To: David Laight Cc: "linux-kernel@vger.kernel.org" , Jens Axboe , "Matthew Wilcox (Oracle)" , Christoph Hellwig , Andrew Morton , Andy Shevchenko , Dan Carpenter , Arnd Bergmann , "Jason@zx2c4.com" , "pedro.falcato@gmail.com" , Mateusz Guzik , "linux-mm@kvack.org" , Lorenzo Stoakes Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: oyj1onjx1hkyommheobrudzgq7j48sob X-Rspamd-Queue-Id: 9ED1AA000D X-Rspamd-Server: rspam11 X-HE-Tag: 1722196526-349680 X-HE-Meta: U2FsdGVkX1898vl7irg8p7H5ORwEO7hIq9n7FsqA7JFFsuOd91afPjrp07YmLy46gop2KA9h48Ndqa/2jmVcAdj/eRFi6v4R1l4DGBaJooUT82fDBTQHISQ8oe3kYa9ONHI+joqg78rc9ZDPELxESKrw+2xJDfA/aF7G/ebPXum9K9CmZ3WEvbW0GSbu7otG0INcGsMGCN1dQk4BAP35OLGm8W4nmfM7I8szrZMOFcHRBi/RSgbfUVhut7d6AGnB36GSxmyK9pAeNDgYY5pAArB7YbPLQiJGdZAxKMzPb4hTncOipuFfqdq52Oky12yYXUWevQmN/q2p7gRO9ZoejoU9X3SICpi/Wmb/o1ek2T38e/MiEEuONNgbvreWVAFVXp+6M7q3Ae+9ciqFCtbqsWV60cvihtTkMN+iB12ytVMxU8KUMJpnyKbvsP7dT7jVvh4ZE3XNVh8M+iYR+fG1+wOo5lQNOgZCL+9Q8qhNH69mnZirIm1xmHpu8F2uElLMP4ozIG3fk9p0CsXQnqyo5LPV5zVOto8ysQxZh/yNbWgNoUAxMgQ2VultF5hpb7y6lfmfNvvxVSJc2VvW5e/z2zrIKrX+YMYNEpmNTJw5U0+zHp1qjVzgTQGc09V0+amTMgJAmrQhp9JP848aL1ZPimMWFEg9rsn9AtzDPuFNsMcDOpdySGb35iYt+9UBjKXXWjdEHw+iUKmxUM8gy01jXKAmEq4i2dZvojcDFp6I95t1fDDPoP2SYKiHOyWbTvs9LINBGJo9mOF/ZIgjfL8UpqupHRWoRgTc2mL1nc53ys3sFFWwYFGeU/y5EbPgqf5rPI/Is1h378AWScN2lS3GjNU1YlzfG2H3vnjZYvYpS+IIRtLsckn17WL0zVVzvYgQsU5toBjwP79A2WbhQZxOmNa5GfaTOY02iRcwpbKLJHPceQHs3RjP3T9wg3+FaECzOcB8u/xMqlUPt0BEei1 9fFBF5TG ClGqm7hBgIsqPCteJFrAybTVM95mVIIUgizlhK/HUzyEd7CkprR6NzOuZb/J7mCSgs3qBmdk2qJ7CY1VcrssMufMkMMwOX9JTU7JVHU2R+02dWSX7do0aRbbqsE2yDGHNQ6osEuWR2i9YID2lae0EKI3cvAMEKGJJjS204p+WUAEpfp/h2BvfZccrfuziO1ntwIJEz4OJxGv8Ha3kGJ94SFDNAWVyz6RTvk7nePH3ZDnI5hzdJnbHNPNGQr26s5wCENLEpDybueSSt/kpGB8RQ5DSzrZAwMTRmT9bBBQtfGy9k/xlRp3/wWUQcIsU7oE2Q7IuOzhDHdGR5mps2AL0PcQzFQcojgBedC3OUTY2/0UBt1+IxFJbWV6mvIThgwiPDHhaBd4+2SuOj0pPIS4dnWEBjgzNzbZESQeesnyh3Wk0rc3k/++pnLFtQLTnQXosnZ0pfrUtCXVhppRLbFGTuRrDbKJlDuo71lHULM1zG15KF/A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 28 Jul 2024 at 11:12, David Laight wrote: > > Although min_t(type,x,y) should just be > type __x =3D x; > type __y =3D y; > __x < __y ? __x : __y; > Absolutely no point doing anything else. I tried it. Doesn't quite work: net/ipv4/proc.c: In function =E2=80=98snmp_seq_show_tcp_udp=E2=80=99: net/ipv4/proc.c:414:9: error: ISO C90 forbids variable length array =E2=80=98buff=E2=80=99 [-Werror=3Dvla] 414 | unsigned long buff[TCPUDP_MIB_MAX]; | ^~~~~~~~ (and same issue repeated twice for IPv6). Similar case here: drivers/gpu/drm/drm_color_mgmt.c: In function =E2=80=98drm_plane_create_color_properties=E2=80=99: drivers/gpu/drm/drm_color_mgmt.c:535:16: error: ISO C90 forbids variable length array =E2=80=98enum_list=E2=80=99 [-Werror=3Dvla] 535 | struct drm_prop_enum_list enum_list[max_t(int, DRM_COLOR_ENCODING_MAX, | ^~~~~~~~~~~~~~~~~~ and drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function =E2=80=98stmmac_dma_interrupt=E2=80=99: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2915:9: error: ISO C90 forbids variable length array =E2=80=98status=E2=80=99 [-Werror=3Dvla] 2915 | int status[max_t(u32, MTL_MAX_TX_QUEUES, MTL_MAX_RX_QUEUE= S)]; | ^~~ and several cases in drivers/md/dm-integrity.c. I guess all of these could just be made to use MIN_T()/MAX_T instead. We're not talking hundreds of cases, it seems to be just a small handful. Let me go check. Linus