From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62DE8C4338F for ; Thu, 19 Aug 2021 20:32:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 00FC661075 for ; Thu, 19 Aug 2021 20:32:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 00FC661075 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 8A4976B006C; Thu, 19 Aug 2021 16:32:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 857516B0071; Thu, 19 Aug 2021 16:32:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FFC48D0001; Thu, 19 Aug 2021 16:32:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0211.hostedemail.com [216.40.44.211]) by kanga.kvack.org (Postfix) with ESMTP id 5299F6B006C for ; Thu, 19 Aug 2021 16:32:06 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id EE1F5184075AD for ; Thu, 19 Aug 2021 20:32:05 +0000 (UTC) X-FDA: 78492977010.25.CD3203B Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf06.hostedemail.com (Postfix) with ESMTP id 90E1C801AB05 for ; Thu, 19 Aug 2021 20:32:05 +0000 (UTC) Received: by mail-lf1-f50.google.com with SMTP id y34so15538527lfa.8 for ; Thu, 19 Aug 2021 13:32:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JSRl6XnmOGLdmR851bn1ceo0KMOXukfn1cvOdweS6EE=; b=YxSNY3tcB7ZEMZu0Z0uGdi8ar5s5xZlqAXYmvuLSL5Espa/B5SBqCqsJ9cmkN+bmLP rOw4J3P4KUQ5iMNyYm1z9LDNJp2brMQ3m6OAtitK1DaqnVDYf13di4+NSRR4Wkr/ONNL +zWGKJJrYWx1bmFzoHq6hrhbUfPi4rkOHip8U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JSRl6XnmOGLdmR851bn1ceo0KMOXukfn1cvOdweS6EE=; b=pagmf2Hr50KOsmFUqYMP6vj/uBYL3sE9IpqPipoWTbFqMpT7mCjdl91cEFSiQ2rgQP XAY4RA5n/yipEuRYpE0FNzRvEdfmEOXQSn9Z1b1rZKlFw0QEj3ogwCKt6kpnjmZPTyvh QNwh5mAdbvsQIanFxLcD9O1k8dKATWe4xip1nfu2oq27MAF5czhq+h0zjqHrPoIy2Vyu oGLInsT85CcksecprRePuKEoLdhbn4N0FnJwgXASGVmsjEDC7UP2/nJy2W56XWYJnEZq eLe6ISvhq396q4wPZrVJWPH54ssPQefYy7j9pTONzlTOk5KDZ1G45iYgEXYhdVeEN9ct 3Teg== X-Gm-Message-State: AOAM531OP4m/635x29b99XQn9xcni1Wsr4VPwprW0BO/C2Ogl66MqDzl 6qDCn0Z8EjsbFyRPEh0BeEbVTLXVQrRrzssMD+4= X-Google-Smtp-Source: ABdhPJzhXkUpYRwfVUKY5AFHhkAN8NoD1EZVYnsPiN6wsa/MTwW6w4h6kAt7atycnilb8t/1VOFPJg== X-Received: by 2002:a05:6512:33cc:: with SMTP id d12mr11688402lfg.577.1629405124056; Thu, 19 Aug 2021 13:32:04 -0700 (PDT) Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com. [209.85.208.182]) by smtp.gmail.com with ESMTPSA id bn16sm352606ljb.74.2021.08.19.13.32.02 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Aug 2021 13:32:03 -0700 (PDT) Received: by mail-lj1-f182.google.com with SMTP id h9so13525640ljq.8 for ; Thu, 19 Aug 2021 13:32:02 -0700 (PDT) X-Received: by 2002:a2e:3004:: with SMTP id w4mr11952338ljw.465.1629405111331; Thu, 19 Aug 2021 13:31:51 -0700 (PDT) MIME-Version: 1.0 References: <20210812084348.6521-1-david@redhat.com> <87o8a2d0wf.fsf@disp2133> <60db2e61-6b00-44fa-b718-e4361fcc238c@www.fastmail.com> <87lf56bllc.fsf@disp2133> <87eeay8pqx.fsf@disp2133> <5b0d7c1e73ca43ef9ce6665fec6c4d7e@AcuMS.aculab.com> <87h7ft2j68.fsf@disp2133> <87k0kkxbjn.fsf_-_@disp2133> <0c2af732e4e9f74c9d20b09fc4b6cbae40351085.camel@kernel.org> In-Reply-To: From: Linus Torvalds Date: Thu, 19 Aug 2021 13:31:35 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Removing Mandatory Locks To: Jeff Layton Cc: "Eric W. Biederman" , Matthew Wilcox , Andy Lutomirski , David Laight , David Hildenbrand , Linux Kernel Mailing List , Andrew Morton , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Al Viro , Alexey Dobriyan , Steven Rostedt , "Peter Zijlstra (Intel)" , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Petr Mladek , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Kees Cook , Greg Ungerer , Geert Uytterhoeven , Mike Rapoport , Vlastimil Babka , Vincenzo Frascino , Chinwen Chang , Michel Lespinasse , Catalin Marinas , Huang Ying , Jann Horn , Feng Tang , Kevin Brodsky , Michael Ellerman , Shawn Anastasio , Steven Price , Nicholas Piggin , Christian Brauner , Jens Axboe , Gabriel Krisman Bertazi , Peter Xu , Suren Baghdasaryan , Shakeel Butt , Marco Elver , Daniel Jordan , Nicolas Viennot , Thomas Cedeno , Collin Fijalkovich , Michal Hocko , Miklos Szeredi , Chengguang Xu , =?UTF-8?Q?Christian_K=C3=B6nig?= , "linux-unionfs@vger.kernel.org" , Linux API , "the arch/x86 maintainers" , "" , Linux-MM , Florian Weimer , Michael Kerrisk Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=YxSNY3tc; dmarc=none; spf=pass (imf06.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.50 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-Stat-Signature: mbg9u1juhte3m4od341xhy6k1jr87eob X-Rspamd-Queue-Id: 90E1C801AB05 X-Rspamd-Server: rspam01 X-HE-Tag: 1629405125-779573 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 19, 2021 at 1:18 PM Jeff Layton wrote: > > Now that I think about it a little more, I actually did get one > complaint a few years ago: > > Someone had upgraded from an earlier distro that supported the -o mand > mount option to a later one that had disabled it, and they had an (old) > fstab entry that specified it. Hmm. We might be able to turn the "return -EINVAL" into just a warning. Yes, yes, currently if you turn off CONFIG_MANDATORY_FILE_LOCKING, we already do that VFS: "mand" mount option not supported warning print, but then we fail the mount. If CONFIG_MANDATORY_FILE_LOCKING goes away entirely, it might make sense to turn that warning into something bigger, but then let the mount continue - since now that "mand" flag would be purely a legacy thing. And yes, if we do that, we'd want the warning to be a big ugly thing, just to make people very aware of it happening. Right now it's a one-liner that is easy to miss, and the "oh, the mount failed" is the thing that hopefully informs people about the fact that they need to enable CONFIG_MANDATORY_FILE_LOCKING. The logic being that if you can no longer enable mandatory locking in the kernel, the current hard failure seems overly aggressive (and might cause boot failures and inability to fix/report things when it possibly keeps you from using the system at all). Linus