From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16D7BC00140 for ; Thu, 18 Aug 2022 23:30:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DD398D0002; Thu, 18 Aug 2022 19:30:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68D268D0001; Thu, 18 Aug 2022 19:30:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 556528D0002; Thu, 18 Aug 2022 19:30:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 494E58D0001 for ; Thu, 18 Aug 2022 19:30:49 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2177F802AF for ; Thu, 18 Aug 2022 23:30:49 +0000 (UTC) X-FDA: 79814310618.29.51164F2 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf31.hostedemail.com (Postfix) with ESMTP id E1C2F20126 for ; Thu, 18 Aug 2022 23:04:34 +0000 (UTC) Received: by mail-ej1-f44.google.com with SMTP id k26so5872135ejx.5 for ; Thu, 18 Aug 2022 16:04:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=8C8Dlbh6hGdjbOzzw+aOgiCLWngIvwE1cGPWagEPaog=; b=SoX+TY0L/rFLydx6islcW0cPp3zArfZX1L5teZW57X9csGqiO6VZGcHCnZmjqss5ZB 8LVaZlv0G2jdvgvLG035gdYCm0vbOdZxpv+GQLfINDFBiaPtRfu44FxFUD+kYM8eXwih eR8dFlewXiXk3bVOa9S/0ZqHWvRKs+n5rwSHI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=8C8Dlbh6hGdjbOzzw+aOgiCLWngIvwE1cGPWagEPaog=; b=1/YZoSElYmnu8ELPPTO+5dlnbpw/YDtV5OMxCqkemdA8yMF17p7x8v5Xugx3fDn3wU LcG9C8bmejIS/nwC1q8MJ8iUKAM1jq5UcVhZIBfJzv47gwbgwKE2VRXxaYCxqowcIBSi rrRRcgS4eb1pY879KGmZQg5Hd4zXKhdVw+yi0G7jsETZRFHOlC1YKwhXu+D9q1i/ada+ 67bMGR99LLlwEyuhCGH++mQfYz5IzknqMP39DNCOe+on2iT+U6q/jRoxA+ScTFQNhx7b +hmCUQSfizziaaY8OYlwvU4L14ervFtWmgyPjmwL3PZSRj1fI/I8X9Gixcn+6JnQWrEU 2gXA== X-Gm-Message-State: ACgBeo0yy2QhBht9Nh557u+z1WNY8YDe20pCK78wxLK9ZIJBblncjy38 0tltAf647PSm+bOKn2i8VV11anKMx8Ytxlvh X-Google-Smtp-Source: AA6agR4hwFpvswRL5opK/UUf/x41vvckJAPvdzkD6IaY/xqlyMqQFL12sVpYF7GC+OkCt+tCxR3NvA== X-Received: by 2002:a05:6402:10d2:b0:445:d9ee:fc19 with SMTP id p18-20020a05640210d200b00445d9eefc19mr2972864edu.81.1660844086660; Thu, 18 Aug 2022 10:34:46 -0700 (PDT) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com. [209.85.128.54]) by smtp.gmail.com with ESMTPSA id 1-20020a170906210100b007307e7df83bsm1111950ejt.21.2022.08.18.10.34.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Aug 2022 10:34:45 -0700 (PDT) Received: by mail-wm1-f54.google.com with SMTP id h1so1171007wmd.3 for ; Thu, 18 Aug 2022 10:34:44 -0700 (PDT) X-Received: by 2002:a05:600c:4ece:b0:3a6:28:bc59 with SMTP id g14-20020a05600c4ece00b003a60028bc59mr5714170wmq.154.1660844084283; Thu, 18 Aug 2022 10:34:44 -0700 (PDT) MIME-Version: 1.0 References: <20220817162703.728679-1-bigeasy@linutronix.de> <20220817162703.728679-2-bigeasy@linutronix.de> In-Reply-To: <20220817162703.728679-2-bigeasy@linutronix.de> From: Linus Torvalds Date: Thu, 18 Aug 2022 10:34:28 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/9] slub: Make PREEMPT_RT support less convoluted To: Sebastian Andrzej Siewior Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Peter Zijlstra , Steven Rostedt , Matthew Wilcox , Andrew Morton , Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , Vlastimil Babka , linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660863876; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8C8Dlbh6hGdjbOzzw+aOgiCLWngIvwE1cGPWagEPaog=; b=gyintZ57NZP5cdw3SQiCS310/DBzV6YhKiqaDlGZMpgcQWHEWuD1xPmR7+ajlahRk36uBo qOKZSkCfA0ZtJKyiHD4KMSWc4+jmdrra6+d8itUOU0XYy1uZMjge0k3s6jwcUzM4yYz3Qz EJUdratm7CVr0yqO6SVbTHhkV99vOYo= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=SoX+TY0L; spf=pass (imf31.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.44 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660863876; a=rsa-sha256; cv=none; b=s44AMNIqMLRBnQlHDajPlF81DOuhHfkALxlogG3UO64rjKfAkhdf+7DkEz5A2TdQp2CzGV OGJLAPkKMbH4qdBsZMq8v9i04ieEKaOF8F1b/7o5Fnz4MIDX/kVPuhsbAnV3PT9+Wj3vSk R/9Lcv94Don+PcVLzSp+lVfQ4VpcEU8= X-Stat-Signature: bchcti5ozpxoe6augptk8jc4xn4g1uoi X-Rspam-User: Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=SoX+TY0L; spf=pass (imf31.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.44 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E1C2F20126 X-HE-Tag: 1660863874-412032 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 17, 2022 at 9:27 AM Sebastian Andrzej Siewior wrote: > > The slub code already has a few helpers depending on PREEMPT_RT. Add a few > more and get rid of the CONFIG_PREEMPT_RT conditionals all over the place. > > No functional change. Looks like a fine cleanup, but I'd prefer that #define use_lockless_fast_path() {(true)/(false)} to look much less like it's some function call. The first read-through it looked like some very dynamic thing to me. Just doing #define USE_LOCKLESS_FAST_PATH .. would make it much more visually obvious that it's not some kind of complex run-time decision. Linus