From: Linus Torvalds <torvalds@linux-foundation.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Matthew Wilcox <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux.com>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Pekka Enberg <penberg@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org
Subject: Re: [PATCH 1/9] slub: Make PREEMPT_RT support less convoluted
Date: Thu, 18 Aug 2022 10:34:28 -0700 [thread overview]
Message-ID: <CAHk-=wgCRJx74T0NyRrpWi6XRwy50y8Wzap5XK_3-hN8dbuxTw@mail.gmail.com> (raw)
In-Reply-To: <20220817162703.728679-2-bigeasy@linutronix.de>
On Wed, Aug 17, 2022 at 9:27 AM Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
>
> The slub code already has a few helpers depending on PREEMPT_RT. Add a few
> more and get rid of the CONFIG_PREEMPT_RT conditionals all over the place.
>
> No functional change.
Looks like a fine cleanup, but I'd prefer that
#define use_lockless_fast_path() {(true)/(false)}
to look much less like it's some function call. The first read-through
it looked like some very dynamic thing to me.
Just doing
#define USE_LOCKLESS_FAST_PATH ..
would make it much more visually obvious that it's not some kind of
complex run-time decision.
Linus
next prev parent reply other threads:[~2022-08-18 23:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220817162703.728679-1-bigeasy@linutronix.de>
2022-08-17 16:26 ` Sebastian Andrzej Siewior
2022-08-18 9:42 ` Christoph Lameter
2022-08-18 14:37 ` Vlastimil Babka
2022-08-18 15:22 ` Sebastian Andrzej Siewior
2022-08-19 15:04 ` Christoph Lameter
2022-08-25 5:15 ` Hyeonggon Yoo
2022-08-18 17:34 ` Linus Torvalds [this message]
2022-08-23 17:15 ` Vlastimil Babka
2022-08-24 13:25 ` Sebastian Andrzej Siewior
2022-08-24 13:54 ` Vlastimil Babka
2022-08-24 13:57 ` Sebastian Andrzej Siewior
2022-08-17 16:26 ` [PATCH 4/9] mm/vmstat: Use preempt_[dis|en]able_nested() Sebastian Andrzej Siewior
2022-08-17 16:26 ` [PATCH 5/9] mm/debug: Provide VM_WARN_ON_IRQS_ENABLED() Sebastian Andrzej Siewior
2022-08-17 16:27 ` [PATCH 6/9] mm/memcontrol: Replace the PREEMPT_RT conditionals Sebastian Andrzej Siewior
2022-08-17 16:59 ` Johannes Weiner
2022-08-18 2:45 ` Muchun Song
2022-08-17 16:27 ` [PATCH 7/9] mm/compaction: Get rid of RT ifdeffery Sebastian Andrzej Siewior
2022-08-18 8:55 ` Rasmus Villemoes
2022-08-18 15:51 ` Sebastian Andrzej Siewior
2022-08-24 13:50 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgCRJx74T0NyRrpWi6XRwy50y8Wzap5XK_3-hN8dbuxTw@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox