From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29099D7360A for ; Sat, 30 Nov 2024 21:34:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8AF836B0083; Sat, 30 Nov 2024 16:34:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 838546B0088; Sat, 30 Nov 2024 16:34:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 701436B0089; Sat, 30 Nov 2024 16:34:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4F64C6B0083 for ; Sat, 30 Nov 2024 16:34:28 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BB9C41C77ED for ; Sat, 30 Nov 2024 21:34:27 +0000 (UTC) X-FDA: 82844064660.17.C1297D6 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf20.hostedemail.com (Postfix) with ESMTP id B09B21C0008 for ; Sat, 30 Nov 2024 21:34:14 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=bOKkahR8; spf=pass (imf20.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.53 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733002459; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RNyysF0czXG+9VpzTWGbzEwJuxUcYyjjRR4QdXrg+wU=; b=ZdsgEu/so6oYdFb51erKEOc9M9T5zstRN6FfiLAwFEf2/xpm7sgG0DAzaonba8nyLFmuUy J8dzL/MiBJbHQxxDX9fM2YlVNRIPnz5mU4M8y/qpYGNQvFuCdqN+DHmLuIg8JBrHMm1fmL l4uHOvoThjX2K3SxF/RJRbYYdeKN4XA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=bOKkahR8; spf=pass (imf20.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.53 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733002459; a=rsa-sha256; cv=none; b=Kr9Jx80yFGOEVBTWTKQgRn09c/IzpJwiRqj02+Zoga/g7fhGOOejBSyY4Wrp/k7OU7Fa2J oaVZzbQI62CtwKwS7NQ6JjtYyi+X+o9WFoHOORTZYn4YzPELxFT2N7BB/tohG4Php+k3c3 QsPoXJNPhnzVU9stDScKW89kT7FuSCY= Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5ceca0ec4e7so3711588a12.0 for ; Sat, 30 Nov 2024 13:34:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1733002464; x=1733607264; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=RNyysF0czXG+9VpzTWGbzEwJuxUcYyjjRR4QdXrg+wU=; b=bOKkahR87g0LZFKFX2DQqJq8N/ZEUg9CzacSAzP+r3Njp1H2N2XOeLg3/R9eYWP5Vo j7XPSu67q/zWNLC0T0ahk3Ocg6otNqqc1hR9NHMdc2saZvd2Gi8r/PRqJor5jKH4ZWQ5 Dpxae1LoZZMkSB/HGZA4LFSEp6nIOO6BnBluk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733002464; x=1733607264; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RNyysF0czXG+9VpzTWGbzEwJuxUcYyjjRR4QdXrg+wU=; b=C9fKDrd6fnSxZmA2cEmM5bIUQuP0YeCBxfKp4omDBrmJSHcAMzOxFMaX+MlkBhQfu4 YAQbfn4gO2//WNXQ8a7K4ojZzC/Ukrli4zAfaH8ihro/brIto4KfJxk868yvRZseadQF BtYma9hCa/XGo1+tVLqpOIZOubzW3036NMb6bQLAMis4J+JSgRQcqsJD3Dq3TXzQwno+ 2su4YNPS/6bWKrhyCmHCBmeI6bq8E0QKeLh33CNJCFmTFcEkP4vtQmZ5wbjbfGUpOs1m gQmw/9LrDK4fGyFhpuSQhYH/yooEKPRSvfhSU+1mEGujoIP/hkZ4i51cGVHfBAKoCa9V 8+FA== X-Forwarded-Encrypted: i=1; AJvYcCVE4c1vq3nfZ9wJ2uNWW/N/G9UswrNO6vNBdNVYM89w1mUUyLdVrn6/HGJvPXbpUqcI8MqO55Tdig==@kvack.org X-Gm-Message-State: AOJu0YycVsvZWJzK/C7sQtMWK8+tZeUnaHefaKKij5C/yQ/Owqbvnkhf KZUIWbgcpy/BxtLvXHbwq2bCQ6CXAaQSGyT8w8C0Qikl4GZ1Bej0rHN9gE6fCP71H7+PFgnf3kD oPMIzOg== X-Gm-Gg: ASbGncuUCs6V3K5qHy8Kv61SlQURAEv0L8RjVLiOTAtv1pyaZi+iIjRlRhHf0trSKHC f5eXpOQKOs6JI/A6AcYlYSD6kyNsUZsffR9e90S8np6O/A7+5UJkHyb2hWyGUwD2a3eGpphoDxX wFRcwXZeQT7G03x9qZW3pEvkXW80URFmFJsatJaXRRf5Kj6pfgXgpTwpWzL9glt5tdZeoLezpn8 Yky7syViiRdiJB5UPuGs3JkcpivXyG6BMiOazJExolCcX4pZMsaJs2IYS2RxOfjKODSJIawPgWW ks6VROIxdK2v1OAxtUIUdf4h X-Google-Smtp-Source: AGHT+IFCC/0xcXzdxLPG/ntlMEHBPMY/PKhgkO83S2+KDG6G43fhvVG8QHnvh/sqpv7I03YJZOurOQ== X-Received: by 2002:a17:906:cc5e:b0:aa5:317b:3a0 with SMTP id a640c23a62f3a-aa58108f995mr1530412266b.57.1733002464102; Sat, 30 Nov 2024 13:34:24 -0800 (PST) Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com. [209.85.218.43]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa5997d5672sm319352666b.77.2024.11.30.13.34.23 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 Nov 2024 13:34:23 -0800 (PST) Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-aa53a971480so441637166b.1 for ; Sat, 30 Nov 2024 13:34:23 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCW6CEoVvbqYdNS8waiLT5Sj3x52k8TstXu/PG3cYXpulJMGTqU3zC1LGxTsY117zttOTh0I1wvQxg==@kvack.org X-Received: by 2002:a17:907:ca20:b0:aa5:3b5c:f640 with SMTP id a640c23a62f3a-aa58108aa80mr1263837466b.54.1733002462844; Sat, 30 Nov 2024 13:34:22 -0800 (PST) MIME-Version: 1.0 References: <20241130045437.work.390-kees@kernel.org> In-Reply-To: From: Linus Torvalds Date: Sat, 30 Nov 2024 13:34:06 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] exec: fix up /proc/pid/comm in the execveat(AT_EMPTY_PATH) case To: Mateusz Guzik Cc: Kees Cook , Al Viro , =?UTF-8?Q?Zbigniew_J=C4=99drzejewski=2DSzmek?= , Tycho Andersen , Aleksa Sarai , Eric Biederman , Christian Brauner , Jan Kara , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Stat-Signature: 8xi8nianrgnbzc5gen6rwko3u7kd7ksh X-Rspamd-Queue-Id: B09B21C0008 X-Rspam-User: X-HE-Tag: 1733002454-970194 X-HE-Meta: U2FsdGVkX194G+H/EMZCXxsWtKrTSfmkw0/hJRuNGdg3zhQXGt5E0XSWpwR6Hnn7gudLfnXfSKmtwvGtac//mt4h1yAkFVjxFZqC4ynC/Q3CBBll7uqGe2BW5QzGfBC4TJVTh4grlw62HYzDp/h4rpbHj3HLutBEQ6ayfSL3FTfc1TGIWQh1Rt4Jo0eetoWFDiYpF9hkx6hrLbePZLR9k9Wfi6OtsgBieq2g5RTY2JK9UoodVuzMPxB8dFEKx2iBeiU5QfuhIYKWT+4N61gTGX2TGI1TaqzYuAW8RU2EaBtSsqVdZ9piNbyS0FuiYttfJgnptUTc0R+2XRZfJ6QbVF9Wj5NaxSG75oPFLtiDIKpUkujFoDCcTTe5yaE+JYGPc41yYDOR+V+kzwP4Y5yIPDhymYPsDnW1ExP63PkBKX2Im1oAjeYNXEemY/t9KABkBn/C05uUppELsCpc1h4G2fjDiwIyoGTW6SbnRYhr6nYreKGTkGbv4PXQOMF009uHynyhUY/QiWx611ZQ1d90Piu0d6G0MLGrcFwHKHrRc7edCSxLTgDEqAr0Jpwn9G5E7cKxTmwS5O1xYBzyCMbCbpQhKoGYaqPtUYTncMgsLBkj+MuNwJmiwvfIDGWcxPuLxBzTfL89Yypjq3qeMkyJOsdlulBLe7zYhuD0f2T84liOE6PdeGWgFA/DLKVkPCrW+CbtyZEcrc/ccu3OAl5APm61SQccOZ/OE9WBuJLMi1Ev66smKouogtNGjzd0XAL35kAM/0rh65AOs9ICKW7pZGyi97QtN1UKb26AR+KCOjMTI4C/x80Sng5eSzOkJSN/9DmUOnDmQWvDz4hfOG0QerSJROFqY77GXmHYJoRbrfdTkzP5dUJZAP2rwGCyF2ttd5Mq9p750oCBUMfaqGL0TWTAOc/kfiRTnN/eU1jBEDcbo1NBsGiqAa0JqpRQ7faGBC4e7yI8IdjHRzTyEv+ uyP9FQNi zX8YnYjv32oe8VHKTRhagTxBWKdW8La3rg3d/jVNvivTvoPYjUvHKJMlLMcnKvbqrNt0Kk2Paee30glSa1JoHnTkEw+9sXRHjyH+Ti+7DfgxkelYQKkZrWBj4zUpnbveTLWtorx5qcMX0Ev60hXpxh2jKcDOXZd/tZqMurXqU8j8A+BSBBNShBt226NNkgqS0dvmGeqPCRaNLdxEvWWqYdkHk66t0uQMG6Fk+dojbrl6AJpJjG+joOFpr76/M9fwrscLZIhKQaqyqnBmkEdqFzciObx8oTI5tiwnNqZ/jt3lL7mi5swYFSKcQffKhOubwpJMnroSORLg1Lw/hm+vb0treo6nyBKHiQ+rjyiF4T4+Q+LG+Bzu9Sxh0g93cGf6WZjeQTcozUa3IPnpeNTJvm/t5lwjse+q4ZxTKKyv/muU6Ni42S4rtfQAD0fV+JIfQFk/mLlVL/8tF2TGhk1tLDq0TjWD4IXBuBh+zB+bgj/t+aM94F7BDu8b7aqmaeXGQaW1iolNpOg2GRbGGlNdT8Pt+pPrhdTFaLHoSK3qWSkYR97634xCj4UlhwswbK+Jxq3Ur X-Bogosity: Ham, tests=bogofilter, spamicity=0.000016, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 30 Nov 2024 at 12:28, Mateusz Guzik wrote: > > > + /* The dentry name won't change while we hold the rcu read lock. */ > > + __set_task_comm(me, smp_load_acquire(&bprm->file->f_path.dentry->d_name.name), > > + true); > > This does not sound legit whatsoever as it would indicate all renames > wait for rcu grace periods to end, which would be prettye weird. Yes, the "won't change" should be "won't go away from under us". Linus