From: Linus Torvalds <torvalds@linux-foundation.org>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: "Kees Cook" <kees@kernel.org>,
"Al Viro" <viro@zeniv.linux.org.uk>,
"Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>,
"Tycho Andersen" <tandersen@netflix.com>,
"Aleksa Sarai" <cyphar@cyphar.com>,
"Eric Biederman" <ebiederm@xmission.com>,
"Christian Brauner" <brauner@kernel.org>,
"Jan Kara" <jack@suse.cz>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] exec: fix up /proc/pid/comm in the execveat(AT_EMPTY_PATH) case
Date: Sat, 30 Nov 2024 13:34:06 -0800 [thread overview]
Message-ID: <CAHk-=wgAVEbjFzhNpqvgTxKymCi6uE5UO7BzyB6ch7pDiUz+Yg@mail.gmail.com> (raw)
In-Reply-To: <ej5vp7iifyy4s2faxsh72dytcfjmpktembvgw6n65sucyf77ze@gmbn2bjvdoau>
On Sat, 30 Nov 2024 at 12:28, Mateusz Guzik <mjguzik@gmail.com> wrote:
>
> > + /* The dentry name won't change while we hold the rcu read lock. */
> > + __set_task_comm(me, smp_load_acquire(&bprm->file->f_path.dentry->d_name.name),
> > + true);
>
> This does not sound legit whatsoever as it would indicate all renames
> wait for rcu grace periods to end, which would be prettye weird.
Yes, the "won't change" should be "won't go away from under us".
Linus
prev parent reply other threads:[~2024-11-30 21:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-30 4:54 Kees Cook
2024-11-30 5:55 ` Aleksa Sarai
2024-12-04 23:50 ` Zbigniew Jędrzejewski-Szmek
2024-11-30 12:29 ` Christian Brauner
2024-11-30 18:02 ` Linus Torvalds
2024-12-01 14:17 ` Christian Brauner
2024-12-01 16:54 ` Linus Torvalds
2024-12-01 18:37 ` Christian Brauner
2024-11-30 20:28 ` Mateusz Guzik
2024-11-30 21:34 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgAVEbjFzhNpqvgTxKymCi6uE5UO7BzyB6ch7pDiUz+Yg@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=cyphar@cyphar.com \
--cc=ebiederm@xmission.com \
--cc=jack@suse.cz \
--cc=kees@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mjguzik@gmail.com \
--cc=tandersen@netflix.com \
--cc=viro@zeniv.linux.org.uk \
--cc=zbyszek@in.waw.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox