From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21FBCC3DA49 for ; Tue, 30 Jul 2024 04:10:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 75A2E6B0089; Tue, 30 Jul 2024 00:10:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 70A236B008A; Tue, 30 Jul 2024 00:10:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D2106B008C; Tue, 30 Jul 2024 00:10:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3FBF76B0089 for ; Tue, 30 Jul 2024 00:10:34 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9338A1C078D for ; Tue, 30 Jul 2024 04:10:33 +0000 (UTC) X-FDA: 82395092346.21.AA6F76F Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf16.hostedemail.com (Postfix) with ESMTP id 759EB18000C for ; Tue, 30 Jul 2024 04:10:31 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=Rpe4UGzA; spf=pass (imf16.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.51 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722312627; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aXa9bufO4QoTVzOfdBHgkq9nJ6lZTCxYBpwj3AeX9M4=; b=wek2syP9Qv0VRlUVZsf5cUCh4mwLml8CaRDigMRdSFhzXF2IwascX0HoOjczVF8c5qr5/r J9HNnYpkbE2IGRdCmBdFC55df9zF7lecLp02rUEBvEVDupjcmgH0V7IFUzNsFnN7c/tA64 /+XKNwQauNwjhkPrLRYeiY+GjBJd/HM= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=Rpe4UGzA; spf=pass (imf16.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.51 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722312627; a=rsa-sha256; cv=none; b=Fy5PRxk1tdTDARA2WuUPXH5iUuXnlUHIu6ridVBcw9853AdWg7BeGV4YM0xSzKdmrPO/FT zMgSDXu4x076AFttBEVbEhIeda8d6Jxhrr4tlwM9/j07Zcr+tbSmJK8iIRDTspLmCqr65J +TjdEOdlYp8Z86GoihNMkTNRhAsBbr0= Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5a1337cfbb5so7134311a12.3 for ; Mon, 29 Jul 2024 21:10:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1722312629; x=1722917429; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=aXa9bufO4QoTVzOfdBHgkq9nJ6lZTCxYBpwj3AeX9M4=; b=Rpe4UGzAh1y3M2nNyivRoWqVhZmTlsCTWfFMdfxGIHiueKtzauBbYhYoWQRqS3agG+ aYTRh5Y26WaV+6kpLIJtDgo7Chgtki8tCJb2PKZfzBBrJAaEaMvV763A2tUrEy4ZfMEs bcyGqMLrgqw+bZv1aROsilae1llgUOyMDUuMc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722312629; x=1722917429; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aXa9bufO4QoTVzOfdBHgkq9nJ6lZTCxYBpwj3AeX9M4=; b=hCHiABnQ3kb1e6yQRKKYQk1Gn940Vf3RTNiipWJRxZrhn23ZhTW4DJDLi+tk6Wlnlp x6rfCHkSo1lnwU6Rd0mXCZ1G1cQOC0eY2c8uyWBeBJFStE0rKnWiuZOrEU1aix4XNGvD 2wP9vJbcU+ub0zIT2qKuG8vPMUfM7uluyJs0VIwth039AM0I8OknmNSOlSdV7BtuAP4c Ny0uxCHgAzpAdw8VO9Kdl/6Iyy2nT3rPFgVPG4yGc2z+NmgDl++EZ26DKQNzXVxujerg ZxySnWolWsBPDAJSjRvDMfXHQvyiEDU57SzJALkiYx+Lkh5veqtvnrTnOpbG5FcbVUB9 AiCA== X-Forwarded-Encrypted: i=1; AJvYcCXj5W0JUvI5AoUMEGt+HtyYyb21mkTWv6FdHa/vZbdVPY0N2gYuRByfAQqH9YSkdjF2iot9JrC6Y8AHSjUUkdhHGFA= X-Gm-Message-State: AOJu0YwMU+eRLU96ZbAx1sQhq3o4sqqnjNAfw3EeWYWigayAmvHwZCzs f4vEP+4E1eGNKlO4ftrIVyg2gzWE6cRAzzR8Uhe3p0WYZI40fUMVgSWxdta78gjNBEF9BO9+Evy KaKSiEA== X-Google-Smtp-Source: AGHT+IEDvCJSeGkXx9tMbMo8sHJCk0k1/42fu+lmp139rgT8hhJusRGEsQD+itytHMTDa8i2av+ncg== X-Received: by 2002:a50:ab5e:0:b0:58e:e2a:1b58 with SMTP id 4fb4d7f45d1cf-5b0201015b8mr6031127a12.2.1722312629678; Mon, 29 Jul 2024 21:10:29 -0700 (PDT) Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com. [209.85.208.45]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5b2d0b878b2sm2093606a12.85.2024.07.29.21.10.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jul 2024 21:10:28 -0700 (PDT) Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5a10835487fso6345095a12.1 for ; Mon, 29 Jul 2024 21:10:28 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXnFGtAuDqzrvP6QiriZMvTe0cCzRRFnoUSocHSAmPA/xZNZBw9dMiIS0kAe1CrwpNp9h+6qNyKJH5+E0mQNm/SfAg= X-Received: by 2002:a05:6402:5254:b0:5a3:5218:5d82 with SMTP id 4fb4d7f45d1cf-5b020cb9510mr6968944a12.18.1722312627923; Mon, 29 Jul 2024 21:10:27 -0700 (PDT) MIME-Version: 1.0 References: <23bdb6fc8d884ceebeb6e8b8653b8cfe@AcuMS.aculab.com> <902a9bf3-9404-44e8-9063-03da3168146a@lucifer.local> <137646a7-7017-490d-be78-5bd5627609c3@lucifer.local> <36aa2cad-1db1-4abf-8dd2-fb20484aabc3@lucifer.local> <2f1be7ee-2d70-4dd3-bfa2-1b94a4fc5a66@lucifer.local> In-Reply-To: From: Linus Torvalds Date: Mon, 29 Jul 2024 21:10:11 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/7] minmax: reduce compilation time To: Lorenzo Stoakes Cc: David Laight , "linux-kernel@vger.kernel.org" , "Matthew Wilcox (Oracle)" , Christoph Hellwig , Andrew Morton , Andy Shevchenko , Dan Carpenter , Arnd Bergmann , "Jason@zx2c4.com" , "pedro.falcato@gmail.com" , Mateusz Guzik , "linux-mm@kvack.org" Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Stat-Signature: ipupgiryj4jj9duhx8s68jidnfr4jcnf X-Rspamd-Queue-Id: 759EB18000C X-Rspamd-Server: rspam11 X-HE-Tag: 1722312631-397748 X-HE-Meta: U2FsdGVkX1/AL+By3MKehscOPY+r1no6Onq7ZdO6l+i2iyDCNZkAVGFIIsN7NeWWe+nKpUtR3lzfMPE03UNysxUWgOM/EPEPILPM4uKnDmQVfEuAMVTBmrg1sq6PUd2S9Qoj3BX3pRE2iIYHBqUgGDvKs1rXNDZ8iaKDnRBqWVzOqtiH9FliZXtFOlh1PeY/LEPkvPLYo0r2aqNvcE5kxP+nOgZJjpOtvWuOznGhbDbu/ejJVps5OT19fD0k+c1DF80JvWpaaaSAaz40eHDPDReVzQZg2M97i9QkAr2i8k3OdVfk2m0R9nYgtHE4ORifhH2pTghNYkUzpJBpP85jUSnlRChQxzyLPtB3dA5JxVbQtKqyOHeQ/N/GN1KSBCSDoOlCqskNIeJ41KDYImbQ8zmwfGQnpwSZEr3eAYAFZyDJ+LIa8Du9YG9qi1yhwhuB6RubVIrQflvYRjjoJKXUjo4/XkkxSjViCArLYAQyv9nfXF5GpcUDm7sTJZj0sTSCQenTFJh3bPQGF0Kq5GUj8FpZqkp/exlLM1gmxtA99vczzlzJ8MkjmKbM4tXdxjl5/581wcvcftIqigrpA+42XYzm1lS6tMJjlJAlLlf/GCFKoLzry5iHf0LoNYQYMQM/1DltUJQoFCgwGm/GHt+39CJgJVwRqy4Uzu1iwRS2jzLbMWpRs4md6jJNtCdy+kmKNxeVG7bnOBojGkLQBOXpF/bia3u5V4JqgsDsaVYwDu0WUsPXNp4HuMExCB4nhnfA1H1a0ierol3N3jgcLCU3DKjLKQjLbsHT5bSo+SBL8ouFu8B8Y6Uxt1bWeu67UaL7ggF9jSD2BKcC87VzpnUH8cFZ/tXz2+T9whGZ8jh8FuPm77F55giGtHgp9MgvNQhtZ2zck3y95rzyC26RnzMDtlcR0Gke1RvSymMWUcQAwgSdzRo+H82w74fkySvHBhLFAJwzsAIcaBYexk1K4xt psDrhXuU 1xaz0KFIFtL5XfJ/bhASOpNuYlm6nmDiuiW/AEzbnkFeuxqv5WNwLlZSP6JqUMe4Nz5xCZYbfhJG280VbZZ4g9PMVAMt6JP8LnozBCC/PQ6rR8G0AuoHa/RuyPjiaGC4RdAx8pXFA0OOXSnrrVq04o101Onb6DQ9EAqjwl+G2gdgKWO0y8zur+VvkSpSbU38P4hZXzNfXv9bxrw7bFUbomhF7BKras6CSMZVBn9VWhGDyiFJTnQLaNzwxmIEOfujBpmgoFN6acftEazkSTuWSKVZEXWAL6AWVmS4Lh3QI9Cb+DzfwKoqlItxXwppdzG2xHgZxlYGqhOZoLxBsWxKFHO8wzgatCcCgcFuAoROVI+1zn/EQRjAPaiFSfuucm7/eWlAu8DsJ7E021wfh/v9PUCcPB6vLVPHuCxgdtqCG2BeeOy35Jph186q2vsrnUNTKCz823IhYNEEJW7u4KfOUi/lug4kB14fRsSyB3ysLx3Oi6VgM5dPSGQsBIQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 27 Jul 2024 at 09:26, Linus Torvalds wrote: > > Longest line is drivers/.../ia_css_ynr.host.c:71 (27785kB) So that 27MB shrank to 23MB and then to "only" 1.4MB with the patches that are now in mainline. Now with the patch I just posted at https://lore.kernel.org/all/CAHk-=wgRDupSBzUX_N_Qo_eaYyDfOH=VTihhikN36cGxCc+jvg@mail.gmail.com/ that nasty line expands to "just" 82kB, and the file builds quickly. Still not exactly small, but hey, two and a half orders of magnitude isn't bad. And yes, that one driver is disgusting and Lorenzo had a nice patch to change some macros to inline functions which just made the whole problem go away, but as a test-case for horrid macro expansion of min()/max() it was lovely. Of course, I never did any build timings. I'm not sure how much it actually shows up on that level. A couple of bad cases won't be *that* noticeable when most cases aren't too horrid. Linus