From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4246BC25B78 for ; Mon, 3 Jun 2024 22:38:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AEFD16B0095; Mon, 3 Jun 2024 18:38:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA02C6B0098; Mon, 3 Jun 2024 18:38:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9673B6B0099; Mon, 3 Jun 2024 18:38:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 78CDA6B0095 for ; Mon, 3 Jun 2024 18:38:42 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 301051C0781 for ; Mon, 3 Jun 2024 22:38:42 +0000 (UTC) X-FDA: 82191043284.20.159DFA2 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by imf26.hostedemail.com (Postfix) with ESMTP id 0EBB0140004 for ; Mon, 3 Jun 2024 22:38:39 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b="T/1l2KB5"; spf=pass (imf26.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.172 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717454320; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6K+BGd/sjVibNL1YxWnASTBR3LzmvEWN/LqVUKBH3Cg=; b=4O8Y95M216yOhaHiMa5AesEtycw9CPv+qBTOU/02cCQSEv9vUM1tpnpAhOqqNEiuefbcWB 13jbkLd87EyW6GYeCdpjPOsv0Dti96tLMCEYCBCXkNMpkmwPHmML7isCo9ZjPymbVAr9fp 36O8trVAWoxUiacXAMZ0v70eFSBjLvo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717454320; a=rsa-sha256; cv=none; b=7ZgGcB4xPpdOGBAkQkrcNbXWOIvakM4cCmj7JkCTeo2jWVrSubiwsa4Zqnmns76fZUgExn 9VN9hrxTZtn/4KPWxkV7pCXtWyjPVd4QzyHY3vfmQnaTzJtBtVTxYpZh2lo4c8sPFPATLs xbbMSPjljATe51nOkBD9YOCL7HdxvpY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b="T/1l2KB5"; spf=pass (imf26.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.172 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2eab0bc74cdso17747051fa.3 for ; Mon, 03 Jun 2024 15:38:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1717454318; x=1718059118; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6K+BGd/sjVibNL1YxWnASTBR3LzmvEWN/LqVUKBH3Cg=; b=T/1l2KB5saI9drT03qZMQsiuuYmYu84RmgXlp83qhvInPcpiy9v9pyXE68DTU0zRVo PQtesEpIWX2Jg5eQuPiGjxqPVKAdrP9c9klCGGjWHQLz8AuYhJwR71Kb199TqP6usjuu ue2e/m/FNwwpIbLQAQmpHgoZp+DKSoO4E6a7E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717454318; x=1718059118; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6K+BGd/sjVibNL1YxWnASTBR3LzmvEWN/LqVUKBH3Cg=; b=b14N8CWttcDMOQ9xVvLi4ioz9DQKhQDbRVrElUn4QM0jvdhMqFn3w0bS+nra4JNGme gMq041jNLnNHdtY0pQy2Fvm+s3AUJ5VriJ8a9Fdlb04NSmBOGhruLEFTRtG0BgTOr1Qr z45/ihhmF7gjpAcYJgziwmjbaEARCoU8yOHBThnz+39Cu93pvTb5gi+TdYettVRaQWEl 77LZ68Br5aEyL/vMgnTkam6yFYEyCFUzXMH+NZ1lwrX+kxcAuet+Ifzpeg430Q01HhNW yNx+t/Y/3Z7ms6ohV/aPvYB8IAm61eIJXkfly02Tg+/Gzw3ccmhaHWOg/4sBTS2IIr0k 5s6g== X-Forwarded-Encrypted: i=1; AJvYcCXHGyfm6lnSmFQ9dyvDVA0bFiPK33iTcjMLTWkS4Mwx8mwj+33/hcg+zUwRVlxROTHVZZMpNe+0bHrg/o9yL/gohd0= X-Gm-Message-State: AOJu0YzFCAX6tfQCaq/d/mKMlB570Y2XW29/X1MnoYw9u889R7glTHFI vIYp1NsfCr70aF0VdA9MErCzBnWq00mhrwAPs/1IWTsSGwcVk5+/lueyj9+r23uDIphVUOsYsgJ Q3I3VDg== X-Google-Smtp-Source: AGHT+IE9lDvMe33ny9oMjS3AbEu9oTFvu6i/lZbv0Tm7oBJOnl9rlUHmmwYVhbQ56nB3FSCcdrh3eQ== X-Received: by 2002:a2e:9903:0:b0:2e9:794c:19ae with SMTP id 38308e7fff4ca-2ea95122772mr68742331fa.23.1717454318295; Mon, 03 Jun 2024 15:38:38 -0700 (PDT) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com. [209.85.167.51]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2ea91d20138sm13055891fa.137.2024.06.03.15.38.37 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jun 2024 15:38:37 -0700 (PDT) Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-52b9d062526so1408680e87.3 for ; Mon, 03 Jun 2024 15:38:37 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVH2RIWK/67suOBvaTlARAE4MOcmaCV/PbCr6wm6uCgrsLEJmCsO49Tb4paYbu9cXnxjsR1ZrgBZxkqxtBMJFWK9xY= X-Received: by 2002:a05:6512:159a:b0:52b:9f37:3ec2 with SMTP id 2adb3069b0e04-52b9f373f5fmr1374809e87.11.1717454316895; Mon, 03 Jun 2024 15:38:36 -0700 (PDT) MIME-Version: 1.0 References: <20240602023754.25443-1-laoar.shao@gmail.com> <20240602023754.25443-3-laoar.shao@gmail.com> <20240603172008.19ba98ff@gandalf.local.home> <20240603181943.09a539aa@gandalf.local.home> <20240603183742.17b34bc3@gandalf.local.home> In-Reply-To: <20240603183742.17b34bc3@gandalf.local.home> From: Linus Torvalds Date: Mon, 3 Jun 2024 15:38:20 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/6] tracing: Replace memcpy() with __get_task_comm() To: Steven Rostedt Cc: Yafang Shao , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, Masami Hiramatsu , Mathieu Desnoyers Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Stat-Signature: 8wyndhwwp5bj88cmrshgqrccfxnrdjfd X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0EBB0140004 X-HE-Tag: 1717454319-126810 X-HE-Meta: U2FsdGVkX1/7tyL23LMXqzgGk6Nbml/Jiz1oPfwszrqDyjzSvyXhiBnAuINH9Mo2K0DnVrkTbAeK9f07lavWq7JJu4qpmzBrIsQE7KjEYwCvqIbtT3Ppl9GCrLCDbJAz5jhVBBPQuxw6nQfolgMiYwecY5TRfFKSj0g2C7TKMUB0lFUcZg5skiTxhfoyYlzyOZ/PT6MCi3B3O8cbshmGo4GBRv0QZ+jSzzLk1s5Vkbkr/Z/fMDoRURBhJwufLOWopfXyqB/ceTkujqy7HcBtYzlYoKZ5Yfu5rrTCVUM6eOL+5gUr9QDqTVy5mPclhCrkIDbl7zgEAKeqFzFbcYHGTW4HJ5/Adi8bo7hEX7o55Rpz6AQonstkMpSKorEHpBDn73cxaFvgDIuw3ufBL4KIhpfs+1WIT4sxOs21Nz4k4zM9llKxb8JeEOb3SxTAX1FG3iDOmqWyHow0guGlKxzsN4+y7jP0eCLC23couLg0aG/aVGF/ICXNhOKaOs5D6Dr2JZJYvddzkmTK1Qlqfnza7d4hpSwlcuPCUiBA5JvRtlpbyCdu3v+P5XwS+gOfHQQg07W1v9CZV/ZKgnDvLbOfsEKhFzLmeM3VWCGwnplymEZqqUCjZME22DJ8jDnK+sx6VYvCNsHuUo/Bnd+F3xN4K0/twF67kT4AwKWG4oR4mnhC+IZdr624dq6IBxpzcBACUSuecQzT3+7Em4zn4F1vvbPVd5LDD95guKx9y8br7QgswLA8cFnmjc13qO4jMSMVRVRSvqMkMAW1jiAZz8Jy/eZ8YRlZANK8QHMTOz919GE7UYbeU8hO8hwHSoac8vZAt7TWcOdM5gHsKdM7/yBl0g6U2cw/jt4yJIxhko555tfOpNEiLy+teBsqFMDc17IGsbk8Y1HGElwrKsYSKxPlkf1ltWnBMrzCsrRpDpkLcT/RmO7zaiMFKep+im1QFASihfs8oFQ3WXA9nY2o9Yh zo39ZslJ MXt1K5va3mDbKRksv54H2Y+NqESiEEvSZP3l+UCHEcBHZ8LI/lWlZwqt2Ue59q+QCfnjT6z2Cf6T2vrQQKDCorVV04L6VIktB1FLOHiEQAEeRDJTABUWvrEixcus5JA+wF8VngVYDaF49qjJdG3eS4BSnN7MREaZty2UmJd4e21H5+jVkacHZrmMaKxU+4scoiqcN4J0uyzU3a/3Yj+RQxVjfh3lwjwE/CdMNmJLDYGJqqrns/XxTAtzD526niTsMZKmaOq6RoJ+kcQ4y9GgEoaWP6bXe3itkKd7WvcpLfPwheAmXdAK+J6C/k1EaV2LAoAio652IktOucwkBcobrKL93fyL5ekjNIPUaAunmt7uOrX0tlrOXeesw6Sz1GBJfl3GMiPw4AnVBVwEPRS9Fype29K7FQcb/hEqlvNFaxEwP+JTtUniNmDM3qXsM/GmaamROlCwmkcvb3MpPNVcCPu3fcPQr9FPZ2yvCHQyq6177bdQU7sA4iTslmkDpRMS6NQA4pDILPr3uRMp7QZjp8tpo9xhAYo7prvjN27rAvO5HwHeIiYczWBEVCe0sgybI2Xb7gWh8zSM/Ufu5IjES/9Lne3kv8WgwTwOdZt8z1aDhjbUvosT0+uwGvBL25d70RI/aFlpgsH0KScsxBBamRCwTX4I+VruP4sQS/YPsLmuQsarkISGkhvC1LJgWW/ychmpfCivj2bmB6ei+R+k3wqOSsBB3HZ7mzhmdROHl8uBmqaOA05IZsQP0TQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000035, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 3 Jun 2024 at 15:36, Steven Rostedt wrote: > > It's actually a 4 byte meta data that holds it. Ok, much better. > Note, I've been wanting to get rid of the hard coded TASK_COMM_LEN from the > events for a while. As I mentioned before, the only reason the memcpy exists > is because it was added before the __string() logic was. Then it became > somewhat of a habit to do that for everything that referenced task->comm. :-/ Ok, as long as it's an actual improvement, then ack. Linus