From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DD2BC433F5 for ; Wed, 15 Sep 2021 01:57:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CA4046121E for ; Wed, 15 Sep 2021 01:57:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CA4046121E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 5CA0B6B0071; Tue, 14 Sep 2021 21:57:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A97B6B0072; Tue, 14 Sep 2021 21:57:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48FA9900002; Tue, 14 Sep 2021 21:57:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0095.hostedemail.com [216.40.44.95]) by kanga.kvack.org (Postfix) with ESMTP id 3CB806B0071 for ; Tue, 14 Sep 2021 21:57:54 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E27F63A7BB for ; Wed, 15 Sep 2021 01:57:53 +0000 (UTC) X-FDA: 78588146826.20.5DA1606 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by imf30.hostedemail.com (Postfix) with ESMTP id 9E515E001981 for ; Wed, 15 Sep 2021 01:57:53 +0000 (UTC) Received: by mail-lj1-f180.google.com with SMTP id i28so2256474ljm.7 for ; Tue, 14 Sep 2021 18:57:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rJlZqUnq05iJIzEBlrGrw/a1VC/WyblwcDwPRrzG8+s=; b=D9WudYt6WVVp/tcN7gHFkmiiaEW43rvvqowvnIKM9qBE3EO0QYWgLUsxIMElUa1OJx rOBgMPWXc/Rozox71pKWzkBLgUcrmGqdU18HA76b5LSAjuM2rajb0ex2RkKbS1DhiCkH 0r6bnQynmV3maQKnjVhP5JEXVQ5T91Xxig1uY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rJlZqUnq05iJIzEBlrGrw/a1VC/WyblwcDwPRrzG8+s=; b=ZXsBttSwHOmgIS5LYXS8Yg1ku092WBZfX/TsBpVt1Q123SYRCtCE+iL6GXnxxTjDKk 2+80MsBdIEhl06DVQgRDvuOhDfE/BqO5BFkTuW+xeLETC0k1YrfSQHjdfRijB3NRfi1d n9kIWNW+1sF0DxmZpt6GjMwXxaJcpaF5WoUGevuc93q/bYKxTqntKIVhSOlA2g9xtDJP hwtMYwDxiJ5WPkXlB9RwamRFRRlHf6uxla5X+HXkRyuDjNzFkO5YSAyXqN+4wfSqUBsy 4+JaoQbtq/xvvnhC7SYsF5y0VQUebcnMsYHlig1pReFkUvW5gjcUIBJBaD4Mcwq+jFZI 5VOA== X-Gm-Message-State: AOAM532bw7/jShc8VhTK6FeKZTd4CebPSQJ/3/yU8neVMPtiH3Cev2hx 5aHDmrRAxdGKEyO5BY2rnNEEh4YcCfHa3qL9hwI= X-Google-Smtp-Source: ABdhPJzBy+z4txhyFNwjKHNTA2LsVmGEt1bqVG6fGb+wzsH0NSaL5wc6iLLZdDvCHB6IRijX/vfMug== X-Received: by 2002:a2e:9bc2:: with SMTP id w2mr18242793ljj.266.1631671071621; Tue, 14 Sep 2021 18:57:51 -0700 (PDT) Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com. [209.85.208.177]) by smtp.gmail.com with ESMTPSA id g31sm1258359lfv.43.2021.09.14.18.57.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Sep 2021 18:57:51 -0700 (PDT) Received: by mail-lj1-f177.google.com with SMTP id o11so2237821ljp.8 for ; Tue, 14 Sep 2021 18:57:50 -0700 (PDT) X-Received: by 2002:a2e:7f1c:: with SMTP id a28mr872480ljd.56.1631671070565; Tue, 14 Sep 2021 18:57:50 -0700 (PDT) MIME-Version: 1.0 References: <163166717752.510331.12843735095061762373.stgit@devnote2> <163166721835.510331.4931010992364519157.stgit@devnote2> <20210915104718.135cb7393fb63bd8140105a2@kernel.org> In-Reply-To: <20210915104718.135cb7393fb63bd8140105a2@kernel.org> From: Linus Torvalds Date: Tue, 14 Sep 2021 18:57:34 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 5/5] tools/bootconfig: Define memblock_free_ptr() to fix build error To: Masami Hiramatsu Cc: Steven Rostedt , Mike Rapoport , Andrew Morton , LKML , Ingo Molnar , Linux-MM , Vlastimil Babka Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9E515E001981 X-Stat-Signature: 69ukd88ijfwmpp1bpaxmxq1rexjy535e Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=D9WudYt6; spf=pass (imf30.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.180 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-HE-Tag: 1631671073-7064 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 14, 2021 at 6:47 PM Masami Hiramatsu wrote: > > Hmm, OK. Let me copy lib/bootconfig.c itself into tools/bootconfig > as a user-space code. Well, or we need to have some really good way to mark these shared files. Normally I don't think we share any *.c files with tooling, and tooling copies over the *.h files it needs. Is this the only one? So yes, copying the *.c file in this case would match what we do for the header files, but particularly if there are others, maybe we could have something like the "uapi" directory that allows people to explicialy share files with the tools. But it would need to be very explicit in the pathname, so that people would have that big warning sign of "hey, now you're editing a file that is shared with tooling". That has worked at least _somewhat_ with include/uapi/ and arch/*/include/uapi/. Linus