From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FEFBC25B78 for ; Wed, 22 May 2024 16:00:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1E7D6B0085; Wed, 22 May 2024 12:00:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CDC46B0088; Wed, 22 May 2024 12:00:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 895936B0089; Wed, 22 May 2024 12:00:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 674F96B0085 for ; Wed, 22 May 2024 12:00:27 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0B3D112101A for ; Wed, 22 May 2024 16:00:27 +0000 (UTC) X-FDA: 82146494094.22.A1F7F82 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf06.hostedemail.com (Postfix) with ESMTP id A305C180013 for ; Wed, 22 May 2024 16:00:24 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=RCsXsBKx; dmarc=none; spf=pass (imf06.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.54 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716393624; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cEeqNZMxqfKYuQmEXCXsoXwHfU4Me5x6oZXofMLyGCs=; b=5Lyw+S1eXU7c++vrDmoMnQxMp4C7T/gOpJmZpvg/u2Io3x9K7UMlTjunf/w1Qtn7R82m0A NCQxUdTOMQ+6ySm3aibmlcMt7wEPh3WDH2kPbugdV/WlWYD2EbPhVf9renfbw6WzQ7ETNM dl/pHEa0LvY6duGNWCy9lM928jJgRT0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=RCsXsBKx; dmarc=none; spf=pass (imf06.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.54 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716393624; a=rsa-sha256; cv=none; b=ja62pPnL+s69cf6PmvDgBjWaLWczlpm/59vr89ezM5OU80RZZwUXEUpsH05gBzcl4MO4xR 9SX26hJVudjtKGlKqpYmNCJSDxDh1RrUXwDRI5LXuQmiCZyN/Xck/O8nIthZa+8C7TG7vb ioPfT8DZPre5qoICKqUjkp3ArFZa2JQ= Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-520f9d559f6so8047132e87.3 for ; Wed, 22 May 2024 09:00:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1716393622; x=1716998422; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cEeqNZMxqfKYuQmEXCXsoXwHfU4Me5x6oZXofMLyGCs=; b=RCsXsBKxRXBabOlsTxtu+SRpjnLUN3blLMlEezx8AEOnIVF6GgjyFCAy+gYuLGjOLM 7ldLAE8mkTdTpH+w1/kH8d63KR9xGeafzuImL3ZZS9sVOEs89GzBFhpOLt0sCMamEK8E IpLXg54uVlQq7+OMsHAHEkvW43De51rD/0JTc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716393622; x=1716998422; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cEeqNZMxqfKYuQmEXCXsoXwHfU4Me5x6oZXofMLyGCs=; b=uJHLjlB10AJJet1vZ1ZbKleUk4N67fUI67Nz4KDChKYHs42Wb3xDI1/nc6AJmukV3h fIpb9QSRy9KbDr2Owj1yihOvWPfBI3c9Cm/NF5WKLsiDIRIChEvVxEvJ7MBDw3Ad8TxM +CP6C4HbAZonDSOY8EZi1S02FUo5VfbUk/4XepKU/RFfRZWn+e8q1wrekqPdv0m1BcTg PvGOWX90DDzwTTaucMOE0Do7CazRXtmLGT3M1MAYquu143YvfhUis2a7O12/0Uk3JsjO 1HEm7eHByMClq35srOxw+af3CT1khzZvZXvbnz+Zy9psUKo6RCW4iqEppFDGnRLIA5K9 vpSg== X-Forwarded-Encrypted: i=1; AJvYcCVnBSrufvQ0vlmOfZlTOnOu4iLhacOIdNCpByIju6ZGk+Ve7EueyZzZTFErmhbVmrz276eYc1Xzocdqk15SB4/3JH0= X-Gm-Message-State: AOJu0YxYkoGHsnBcbG0tJwUx6MRvjfXr1SgW2rYQRZSkQdoCH/KXe5lF J+Syjup0OpEwWKLQJPmgm0qIUxJRE/XIKnyBbZjVgkXIKLseYXRgdyusInAzFuwZZpmzGuCnEO6 9QFg= X-Google-Smtp-Source: AGHT+IH8TghIUBlwt2NLcebmQGdFy8lMEclnCKwGPdiEg6PmRLhnb7bAEiedUNmtOety8P48qgjF+g== X-Received: by 2002:a2e:7002:0:b0:2e6:a7c3:775a with SMTP id 38308e7fff4ca-2e9495f133dmr13697351fa.52.1716393622692; Wed, 22 May 2024 09:00:22 -0700 (PDT) Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com. [209.85.218.43]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-578398e16e2sm541724a12.65.2024.05.22.09.00.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 May 2024 09:00:21 -0700 (PDT) Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a59a934ad50so980374666b.1 for ; Wed, 22 May 2024 09:00:21 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVkSDrz5cW3FBZfZaPf8IYLO3ak1KQZDdPcETuMbRgF5Yl3kJ5AkJhjTt6wS7XMNWjt4kB0e77OnPJxwaTKYVuZGgc= X-Received: by 2002:a17:906:d101:b0:a5a:423:a69f with SMTP id a640c23a62f3a-a622806b4c9mr166102266b.9.1716393621105; Wed, 22 May 2024 09:00:21 -0700 (PDT) MIME-Version: 1.0 References: <20240515091727.22034-1-laoar.shao@gmail.com> <202405221518.ecea2810-oliver.sang@intel.com> In-Reply-To: <202405221518.ecea2810-oliver.sang@intel.com> From: Linus Torvalds Date: Wed, 22 May 2024 09:00:03 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] vfs: Delete the associated dentry when deleting a file To: kernel test robot Cc: Yafang Shao , oe-lkp@lists.linux.dev, lkp@intel.com, Al Viro , Christian Brauner , Jan Kara , Waiman Long , Matthew Wilcox , Wangkai , Colin Walters , linux-fsdevel@vger.kernel.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: A305C180013 X-Stat-Signature: kz5qmmz69shnecen8oh47q8ouqsgfq8q X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1716393624-836047 X-HE-Meta: U2FsdGVkX1+YJU7aUESudre/eAwIzGeUmpvXMjr9nBWll8tXN9xurfSNOnYbMgsA+VEm+3D70Mue5dZD42bdyPH28NTVLFkO9/Y4wG8JdMn9A4555M2rA3Q08moLP7pJSYy0g0T4Bwf4t7Zpgq5tn7UKBjNrykITrzNt9KJdYC/1x+XTxtQYEI1ZSCbbfKs2OiJ5MA4DJeLP98zQJC+NKWnZQ51GN0ls+ml5MXao6WjOe4xcfP48EdFv8iVrAPE8PPITV/dEn6AR+cUR8o2Pac+9csZco5szmXgDppoeoo1KeeGQJYR1VEAuD+KjyWvqgzRtlhAlcOxD8WMK4bWG0OakkA1xUapKoQ4q9dF7QmAvQShiQuWUWSo9iGcd7CTE3xjlbojZdODnwmxSh+7/Z0t+N3ReHChy0WyqlJV9ofCcwsTyg6mcVmk6e++pWOSFJarg/4JbQv21QN+Rj3RzCHgLQa+nZeCJvTSD6uOnebBiZiP/YsQyssiQi4m9TY2KNVAhFsLBOcwJwXyi4KPZYbbYilW3h9H2KUOYJZkhHm4gLDH0PheuUK+IjCyU2SMdQW9Gs9cLLhGdgbCWspCSrj0oUixtXaMGnEaHi9S/tBAIWCGtVmQ2a/YQ57hDX28zgNM/TA/yvkggWmBLnir+4zL+V7hBKvRxqQEKcV98835aWWdkzZwgkclp0ppksENR1yvzAc8T0Hl+OHdcBeQY6MmpFDUpZvqDHgdJTeb6GxsOCjcFgagbRIUJ+T2Ry11h0Hu9gz0FvmvRbuZYOD/1RXWZMqYPXzjyLTXieSOsKgPwe5F1O0uYfijwGNO/mZHRc8UKK0dEOdJ8FHMKKDEQ0flXSFLDoGB0JmYtBoWULrEoz0zbfcSWMEibCD5FZNl+hT4RtflJD550dphFiOS/JBM1ZXXG2TpsNaNn83Uc/HPVW4s+xYHmBIZlGSH+ADNmQ/AJrSaonvbfMKSTcnu fhQNaV4d WLjV1un1yw0TZOFxz2z3mU6OYFCiW8jUAuQlPRzr+CVoqH9kqjL/qks8Rgs8Oko+Mi7yV/G0zYc6fORYw3fOt2x3uf0Q5XG0d7K5EzbxRBgWTdw5qkRlYiIrVMO78NA4G7dUxXI7oR5YZ8jUXcHRG8z9UDJaA2g2oXrr7Sn7VCDlh6ahGIGx8M/mbQiIScHOW7YlqmmJbBEYjjcW1470agOE3jlLpd6miR/ktpQN3ZRbqDU5wxa17Jt0D+EyZJcNQpOqOyvYy8cfGSXCSk9U08M8GecKYdH7CDBmu1+9Bp+pSU8lvLD2NCVHpmzCHzFp1GyXP32JT3ihF/grFV8PsOeRHO87qmvJZnujSrRgGnvl8Bs+tVeWn0sAt4jyKCxcUJ5jyC97V2/Cp/P0wgvPY0QulEqryXJWGAMErDpJ49bMdqtvf/oqrtDWDZhFuZdzo99PI5GEzYqeq0rtiMffWOYn1cUeSGesPp6lpAbBB1chm4vvrL4d7pKaU/J21kMCT1Xb0hQDzeKbzY5gJ/FB9mOHGOYzJIMoODTZ63zogAvWc9Fxy5fcMZkirxwvajHZumKD9KdGLLvZeClQmpzi90RAnhw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 22 May 2024 at 01:12, kernel test robot wrote: > > kernel test robot noticed a 6.7% improvement of stress-ng.touch.ops_per_sec on: > > commit: 3681ce364442ce2ec7c7fbe90ad0aca651db475b ("[PATCH] vfs: Delete the associated dentry when deleting a file") Ok, since everything else is at least tentatively in the noise, and the only hard numbers we have are the ones from Yafang's Elasticsearch load and this - both of which say that this is a good patch - I decided to just apply this ASAP just to get more testing. I just wanted to note very explicitly that this is very much tentative: this will be reverted very aggressively if somebody reports some other real-world load performance issues, and we'll have to look at other solutions. But I just don't think we'll get much more actual testing of this without just saying "let's try it". Also, I ended up removing the part of the patch that stopped clearing the DCACHE_CANT_MOUNT bit. I think it's right, but it's really unrelated to the actual problem at hand, and there are other cleanups - like the unnecessary dget/dput pair - in this path that could also be looked at. Anyway, let's see if somebody notices any issues with this. And I think we should look at the "shrink dentries" case anyway for other reasons, since it's easy to create a ton of negative dentries with just lots of lookups (rather than lots of unlinking of existing files). Of course, if you do billions of lookups of different files that do not exist in the same directory, I suspect you just have yourself to blame, so the "lots of negative lookups" load doesn't sound particularly realistic. TLDR; I applied it for testing because we're in the merge window and there's no reason not to try. Linus