From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by kanga.kvack.org (Postfix) with ESMTP id 766478E00F9 for ; Sat, 5 Jan 2019 20:51:20 -0500 (EST) Received: by mail-lf1-f70.google.com with SMTP id y24so3825802lfh.4 for ; Sat, 05 Jan 2019 17:51:20 -0800 (PST) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id a12-v6sor34922828lji.34.2019.01.05.17.51.18 for (Google Transport Security); Sat, 05 Jan 2019 17:51:18 -0800 (PST) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com. [209.85.167.53]) by smtp.gmail.com with ESMTPSA id f8sm13250941lfe.72.2019.01.05.17.51.16 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 05 Jan 2019 17:51:16 -0800 (PST) Received: by mail-lf1-f53.google.com with SMTP id c16so27835259lfj.8 for ; Sat, 05 Jan 2019 17:51:16 -0800 (PST) MIME-Version: 1.0 References: <20190106001138.GW6310@bombadil.infradead.org> In-Reply-To: From: Linus Torvalds Date: Sat, 5 Jan 2019 17:50:59 -0800 Message-ID: Subject: Re: [PATCH] mm/mincore: allow for making sys_mincore() privileged Content-Type: multipart/mixed; boundary="000000000000ff4c37057ec05817" Sender: owner-linux-mm@kvack.org List-ID: To: Matthew Wilcox Cc: Jann Horn , Jiri Kosina , Andrew Morton , Greg KH , Peter Zijlstra , Michal Hocko , Linux-MM , kernel list , Linux API --000000000000ff4c37057ec05817 Content-Type: text/plain; charset="UTF-8" On Sat, Jan 5, 2019 at 4:22 PM Linus Torvalds wrote: > > But I think my patch to just rip out all that page lookup, and just > base it on the page table state has the fundamental advantage that it > gets rid of code. Maybe I should jst commit it, and see if anything > breaks? We do have options in case things break, and then we'd at > least know who cares (and perhaps a lot more information of _why_ they > care). Slightly updated patch in case somebody wants to try things out. Also, any comments about the pmd_trans_unstable() case? Linus --000000000000ff4c37057ec05817 Content-Type: text/x-patch; charset="US-ASCII"; name="patch.diff" Content-Disposition: attachment; filename="patch.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jqk8qbng0 IG1tL21pbmNvcmUuYyB8IDk0ICsrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyks IDgxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL21tL21pbmNvcmUuYyBiL21tL21pbmNvcmUu YwppbmRleCAyMTgwOTliNWVkMzEuLmYwZjkxNDYxYTlmNCAxMDA2NDQKLS0tIGEvbW0vbWluY29y ZS5jCisrKyBiL21tL21pbmNvcmUuYwpAQCAtNDIsNzIgKzQyLDE0IEBAIHN0YXRpYyBpbnQgbWlu Y29yZV9odWdldGxiKHB0ZV90ICpwdGUsIHVuc2lnbmVkIGxvbmcgaG1hc2ssIHVuc2lnbmVkIGxv bmcgYWRkciwKIAlyZXR1cm4gMDsKIH0KIAotLyoKLSAqIExhdGVyIHdlIGNhbiBnZXQgbW9yZSBw aWNreSBhYm91dCB3aGF0ICJpbiBjb3JlIiBtZWFucyBwcmVjaXNlbHkuCi0gKiBGb3Igbm93LCBz aW1wbHkgY2hlY2sgdG8gc2VlIGlmIHRoZSBwYWdlIGlzIGluIHRoZSBwYWdlIGNhY2hlLAotICog YW5kIGlzIHVwIHRvIGRhdGU7IGkuZS4gdGhhdCBubyBwYWdlLWluIG9wZXJhdGlvbiB3b3VsZCBi ZSByZXF1aXJlZAotICogYXQgdGhpcyB0aW1lIGlmIGFuIGFwcGxpY2F0aW9uIHdlcmUgdG8gbWFw IGFuZCBhY2Nlc3MgdGhpcyBwYWdlLgotICovCi1zdGF0aWMgdW5zaWduZWQgY2hhciBtaW5jb3Jl X3BhZ2Uoc3RydWN0IGFkZHJlc3Nfc3BhY2UgKm1hcHBpbmcsIHBnb2ZmX3QgcGdvZmYpCi17Ci0J dW5zaWduZWQgY2hhciBwcmVzZW50ID0gMDsKLQlzdHJ1Y3QgcGFnZSAqcGFnZTsKLQotCS8qCi0J ICogV2hlbiB0bXBmcyBzd2FwcyBvdXQgYSBwYWdlIGZyb20gYSBmaWxlLCBhbnkgcHJvY2VzcyBt YXBwaW5nIHRoYXQKLQkgKiBmaWxlIHdpbGwgbm90IGdldCBhIHN3cF9lbnRyeV90IGluIGl0cyBw dGUsIGJ1dCByYXRoZXIgaXQgaXMgbGlrZQotCSAqIGFueSBvdGhlciBmaWxlIG1hcHBpbmcgKGll LiBtYXJrZWQgIXByZXNlbnQgYW5kIGZhdWx0ZWQgaW4gd2l0aAotCSAqIHRtcGZzJ3MgLmZhdWx0 KS4gU28gc3dhcHBlZCBvdXQgdG1wZnMgbWFwcGluZ3MgYXJlIHRlc3RlZCBoZXJlLgotCSAqLwot I2lmZGVmIENPTkZJR19TV0FQCi0JaWYgKHNobWVtX21hcHBpbmcobWFwcGluZykpIHsKLQkJcGFn ZSA9IGZpbmRfZ2V0X2VudHJ5KG1hcHBpbmcsIHBnb2ZmKTsKLQkJLyoKLQkJICogc2htZW0vdG1w ZnMgbWF5IHJldHVybiBzd2FwOiBhY2NvdW50IGZvciBzd2FwY2FjaGUKLQkJICogcGFnZSB0b28u Ci0JCSAqLwotCQlpZiAoeGFfaXNfdmFsdWUocGFnZSkpIHsKLQkJCXN3cF9lbnRyeV90IHN3cCA9 IHJhZGl4X3RvX3N3cF9lbnRyeShwYWdlKTsKLQkJCXBhZ2UgPSBmaW5kX2dldF9wYWdlKHN3YXBf YWRkcmVzc19zcGFjZShzd3ApLAotCQkJCQkgICAgIHN3cF9vZmZzZXQoc3dwKSk7Ci0JCX0KLQl9 IGVsc2UKLQkJcGFnZSA9IGZpbmRfZ2V0X3BhZ2UobWFwcGluZywgcGdvZmYpOwotI2Vsc2UKLQlw YWdlID0gZmluZF9nZXRfcGFnZShtYXBwaW5nLCBwZ29mZik7Ci0jZW5kaWYKLQlpZiAocGFnZSkg ewotCQlwcmVzZW50ID0gUGFnZVVwdG9kYXRlKHBhZ2UpOwotCQlwdXRfcGFnZShwYWdlKTsKLQl9 Ci0KLQlyZXR1cm4gcHJlc2VudDsKLX0KLQotc3RhdGljIGludCBfX21pbmNvcmVfdW5tYXBwZWRf cmFuZ2UodW5zaWduZWQgbG9uZyBhZGRyLCB1bnNpZ25lZCBsb25nIGVuZCwKLQkJCQlzdHJ1Y3Qg dm1fYXJlYV9zdHJ1Y3QgKnZtYSwgdW5zaWduZWQgY2hhciAqdmVjKQotewotCXVuc2lnbmVkIGxv bmcgbnIgPSAoZW5kIC0gYWRkcikgPj4gUEFHRV9TSElGVDsKLQlpbnQgaTsKLQotCWlmICh2bWEt PnZtX2ZpbGUpIHsKLQkJcGdvZmZfdCBwZ29mZjsKLQotCQlwZ29mZiA9IGxpbmVhcl9wYWdlX2lu ZGV4KHZtYSwgYWRkcik7Ci0JCWZvciAoaSA9IDA7IGkgPCBucjsgaSsrLCBwZ29mZisrKQotCQkJ dmVjW2ldID0gbWluY29yZV9wYWdlKHZtYS0+dm1fZmlsZS0+Zl9tYXBwaW5nLCBwZ29mZik7Ci0J fSBlbHNlIHsKLQkJZm9yIChpID0gMDsgaSA8IG5yOyBpKyspCi0JCQl2ZWNbaV0gPSAwOwotCX0K LQlyZXR1cm4gbnI7Ci19Ci0KIHN0YXRpYyBpbnQgbWluY29yZV91bm1hcHBlZF9yYW5nZSh1bnNp Z25lZCBsb25nIGFkZHIsIHVuc2lnbmVkIGxvbmcgZW5kLAogCQkJCSAgIHN0cnVjdCBtbV93YWxr ICp3YWxrKQogewotCXdhbGstPnByaXZhdGUgKz0gX19taW5jb3JlX3VubWFwcGVkX3JhbmdlKGFk ZHIsIGVuZCwKLQkJCQkJCSAgd2Fsay0+dm1hLCB3YWxrLT5wcml2YXRlKTsKKwl1bnNpZ25lZCBj aGFyICp2ZWMgPSB3YWxrLT5wcml2YXRlOworCXVuc2lnbmVkIGxvbmcgbnIgPSAoZW5kIC0gYWRk cikgPj4gUEFHRV9TSElGVDsKKworCW1lbXNldCh2ZWMsIDAsIG5yKTsKKwl3YWxrLT5wcml2YXRl ICs9IG5yOwogCXJldHVybiAwOwogfQogCkBAIC0xMjcsOCArNjksOSBAQCBzdGF0aWMgaW50IG1p bmNvcmVfcHRlX3JhbmdlKHBtZF90ICpwbWQsIHVuc2lnbmVkIGxvbmcgYWRkciwgdW5zaWduZWQg bG9uZyBlbmQsCiAJCWdvdG8gb3V0OwogCX0KIAorCS8qIFdlJ2xsIGNvbnNpZGVyIGEgVEhQIHBh Z2UgdW5kZXIgY29uc3RydWN0aW9uIHRvIGJlIHRoZXJlICovCiAJaWYgKHBtZF90cmFuc191bnN0 YWJsZShwbWQpKSB7Ci0JCV9fbWluY29yZV91bm1hcHBlZF9yYW5nZShhZGRyLCBlbmQsIHZtYSwg dmVjKTsKKwkJbWVtc2V0KHZlYywgMSwgbnIpOwogCQlnb3RvIG91dDsKIAl9CiAKQEAgLTEzNywy OCArODAsMTcgQEAgc3RhdGljIGludCBtaW5jb3JlX3B0ZV9yYW5nZShwbWRfdCAqcG1kLCB1bnNp Z25lZCBsb25nIGFkZHIsIHVuc2lnbmVkIGxvbmcgZW5kLAogCQlwdGVfdCBwdGUgPSAqcHRlcDsK IAogCQlpZiAocHRlX25vbmUocHRlKSkKLQkJCV9fbWluY29yZV91bm1hcHBlZF9yYW5nZShhZGRy LCBhZGRyICsgUEFHRV9TSVpFLAotCQkJCQkJIHZtYSwgdmVjKTsKKwkJCSp2ZWMgPSAwOwogCQll bHNlIGlmIChwdGVfcHJlc2VudChwdGUpKQogCQkJKnZlYyA9IDE7CiAJCWVsc2UgeyAvKiBwdGUg aXMgYSBzd2FwIGVudHJ5ICovCiAJCQlzd3BfZW50cnlfdCBlbnRyeSA9IHB0ZV90b19zd3BfZW50 cnkocHRlKTsKIAotCQkJaWYgKG5vbl9zd2FwX2VudHJ5KGVudHJ5KSkgewotCQkJCS8qCi0JCQkJ ICogbWlncmF0aW9uIG9yIGh3cG9pc29uIGVudHJpZXMgYXJlIGFsd2F5cwotCQkJCSAqIHVwdG9k YXRlCi0JCQkJICovCi0JCQkJKnZlYyA9IDE7Ci0JCQl9IGVsc2UgewotI2lmZGVmIENPTkZJR19T V0FQCi0JCQkJKnZlYyA9IG1pbmNvcmVfcGFnZShzd2FwX2FkZHJlc3Nfc3BhY2UoZW50cnkpLAot CQkJCQkJICAgIHN3cF9vZmZzZXQoZW50cnkpKTsKLSNlbHNlCi0JCQkJV0FSTl9PTigxKTsKLQkJ CQkqdmVjID0gMTsKLSNlbmRpZgotCQkJfQorCQkJLyoKKwkJCSAqIG1pZ3JhdGlvbiBvciBod3Bv aXNvbiBlbnRyaWVzIGFyZSBhbHdheXMKKwkJCSAqIHVwdG9kYXRlCisJCQkgKi8KKwkJCSp2ZWMg PSAhIW5vbl9zd2FwX2VudHJ5KGVudHJ5KTsKIAkJfQogCQl2ZWMrKzsKIAl9Cg== --000000000000ff4c37057ec05817-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FEA9C43387 for ; Sun, 6 Jan 2019 01:51:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C89F2222CB for ; Sun, 6 Jan 2019 01:51:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="Um4YEyAt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C89F2222CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0B39E8E0139; Sat, 5 Jan 2019 20:51:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 063088E00F9; Sat, 5 Jan 2019 20:51:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E6CC48E0139; Sat, 5 Jan 2019 20:51:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by kanga.kvack.org (Postfix) with ESMTP id 766478E00F9 for ; Sat, 5 Jan 2019 20:51:20 -0500 (EST) Received: by mail-lf1-f70.google.com with SMTP id y24so3825802lfh.4 for ; Sat, 05 Jan 2019 17:51:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:mime-version:references :in-reply-to:from:date:message-id:subject:to:cc; bh=AcswdOBczXk+iMEaWZLv2123bIfAtssmPcZQKRLxpec=; b=CRjAClVa2u/+nwIA+TITSvjVqe5VUuKC4fUEYz7NDW9MT0BeZT5YVFTo1ZZ62edxlR G1G8CwWulDkt/Zo/nxaXISQ648yn+WQpAFWYzQZiACD3wQ4VawdClYQ9siWX7mcDaZID 0ZtpFaf5iABSWoTi/acjgD5F80Sgt8KIiqCNOKnQYtqg9W8mWX7IhPXnR1JD6yYlnyWa 4PvWlMVjmaUQKwGIXTy2GBIHMeTVu7N5Bf0ZW0yZy8uB2oszMu/fbjXiu4oxP0nKf8P7 62MTx8hpwOz+/F7Q49lzWAy7IkxMnORanubg140I5/mqf5lUinqTI9LXkaQuFDwnLrT/ F3RQ== X-Gm-Message-State: AJcUukeyKKt0xuEdCP1FZPxq6ebUp/jrRmheGjve07vy9+3oeKAIe6O6 Rz5Z8x+5n+Zj745Yy9v7Q0ZGcH8zvJPg99XkaSr2BGjnY7BBcrgTYQGylvgx6P+Q45fSiL7P6hJ fjvjg/EUMmE3OR8kLrsohbpfR9GnDA18ea3ZFayeBBUJCpJoNT1TO6ykpzlH6QEzZi20ZJiE358 HMYfQyu3hXUcrVCnjC8OHrMfOJR3ufMud4bzp/LrNoSWmvYX7dDfX2stVhxAk41wS10b/KlE5of L4vktIInKCvzXiD1p++JuIwNmUo+N06rLL6RuFdpOPpFppaEydw2O9WtWW9OQfyOLZStLC6dSb/ wZdiMySGXfbLG/aXHAMKzjutaY5nojSYaZv7elIO5Xl45SxQq0gbcQeUngX9sKpBot1OIXnOZ50 l X-Received: by 2002:a2e:851a:: with SMTP id j26-v6mr30844319lji.163.1546739479661; Sat, 05 Jan 2019 17:51:19 -0800 (PST) X-Received: by 2002:a2e:851a:: with SMTP id j26-v6mr30844298lji.163.1546739478585; Sat, 05 Jan 2019 17:51:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546739478; cv=none; d=google.com; s=arc-20160816; b=zehevUtQ8TMxd2mjvYnTB+JezQu3qWbgnqoqS4UPk8oqXHRjTL7fk9jVn5vjKu2WL+ BN1yFc0jl5feUgwsjStnmxkp6r4UEd4c6oEnr+gk0H7XfLv8Yb5m0Sj2F76aPJ5btEIB xsRnpA+6eVFruKQ3LANAuFJ568vKvWOE9Z/pLQ+fTZZ6JdBg6j7vMlB4DzTjk7u4o05U iLFdleoRT92rjF205Q9TsWAFq6GnsZJjB1FXmFCWHXBOAwqF9Qz8c83iySgyVdYCnZUA 91I7ngx+hCdopqJl+EiojWUKYJyxFOXS2jrCN+JNUXJ7omi/Tg9wcKP/JgV3ctWh/5RY Xv5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=AcswdOBczXk+iMEaWZLv2123bIfAtssmPcZQKRLxpec=; b=TFP6gDBcqA74ZKoJambSZLxlnjOrkYvO7T34fTlVAsDyuapkidgO6pWqcQeeWOrbaf QTPYdWRuFYnAonvQuPMTBAzgh9rGIClghlX2NmVZASa+03dV347KYVo3yEsQbPsx7hz3 40Zk2RSwmuGsT1Ll7XLpzqafQceZ1lU/AsoQ+6vpL9oyI+Tg/GIi47GIMzjMcQq/xgQC k47olelHmANZjWzEPgcMajAZkEPegYNdpg0+Ej2qSPLJryAiFkcjhWxwAKM9sdFsx3Tl rklyLPASIcqVUZEfVuV4+ly4gy8ZDeI2yMeGGeYYN3YIWt4MuHlffqWYmqdLnXSImbrx R8Gw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=Um4YEyAt; spf=pass (google.com: domain of torvalds@linuxfoundation.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id a12-v6sor34922828lji.34.2019.01.05.17.51.18 for (Google Transport Security); Sat, 05 Jan 2019 17:51:18 -0800 (PST) Received-SPF: pass (google.com: domain of torvalds@linuxfoundation.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=Um4YEyAt; spf=pass (google.com: domain of torvalds@linuxfoundation.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AcswdOBczXk+iMEaWZLv2123bIfAtssmPcZQKRLxpec=; b=Um4YEyAt8jYVvSh/qfFiqPF+GCGUMUEdHNIOKX3UpSSg+Jiiq+gkn8CZUF4jdBJxd5 ZcIyf17YCpILnvKPAgOoflI/KyDQRA5TVSSZoMnoaUCNfSp9CUyGyNuqDxtLhGzrhKXo B7zTL8Hn+Ok5KsEFJHpktWBjGUYOLesmk/W0o= X-Google-Smtp-Source: ALg8bN6qm4cE81MbN4LzpCg0RGumd17a4AajAnN1pACN7prwI2x+jG3PnoYWQNo8XP7yJirEq7AC4g== X-Received: by 2002:a2e:568d:: with SMTP id k13-v6mr32610694lje.105.1546739477472; Sat, 05 Jan 2019 17:51:17 -0800 (PST) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com. [209.85.167.53]) by smtp.gmail.com with ESMTPSA id f8sm13250941lfe.72.2019.01.05.17.51.16 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 05 Jan 2019 17:51:16 -0800 (PST) Received: by mail-lf1-f53.google.com with SMTP id c16so27835259lfj.8 for ; Sat, 05 Jan 2019 17:51:16 -0800 (PST) X-Received: by 2002:a19:6e0b:: with SMTP id j11mr30297686lfc.124.1546739475480; Sat, 05 Jan 2019 17:51:15 -0800 (PST) MIME-Version: 1.0 References: <20190106001138.GW6310@bombadil.infradead.org> In-Reply-To: From: Linus Torvalds Date: Sat, 5 Jan 2019 17:50:59 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mm/mincore: allow for making sys_mincore() privileged To: Matthew Wilcox Cc: Jann Horn , Jiri Kosina , Andrew Morton , Greg KH , Peter Zijlstra , Michal Hocko , Linux-MM , kernel list , Linux API Content-Type: multipart/mixed; boundary="000000000000ff4c37057ec05817" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Message-ID: <20190106015059.5AXgIulqjhLCGoguywIFI_IN473JDPQZABPJh6WKUAU@z> --000000000000ff4c37057ec05817 Content-Type: text/plain; charset="UTF-8" On Sat, Jan 5, 2019 at 4:22 PM Linus Torvalds wrote: > > But I think my patch to just rip out all that page lookup, and just > base it on the page table state has the fundamental advantage that it > gets rid of code. Maybe I should jst commit it, and see if anything > breaks? We do have options in case things break, and then we'd at > least know who cares (and perhaps a lot more information of _why_ they > care). Slightly updated patch in case somebody wants to try things out. Also, any comments about the pmd_trans_unstable() case? Linus --000000000000ff4c37057ec05817 Content-Type: text/x-patch; charset="US-ASCII"; name="patch.diff" Content-Disposition: attachment; filename="patch.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jqk8qbng0 IG1tL21pbmNvcmUuYyB8IDk0ICsrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyks IDgxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL21tL21pbmNvcmUuYyBiL21tL21pbmNvcmUu YwppbmRleCAyMTgwOTliNWVkMzEuLmYwZjkxNDYxYTlmNCAxMDA2NDQKLS0tIGEvbW0vbWluY29y ZS5jCisrKyBiL21tL21pbmNvcmUuYwpAQCAtNDIsNzIgKzQyLDE0IEBAIHN0YXRpYyBpbnQgbWlu Y29yZV9odWdldGxiKHB0ZV90ICpwdGUsIHVuc2lnbmVkIGxvbmcgaG1hc2ssIHVuc2lnbmVkIGxv bmcgYWRkciwKIAlyZXR1cm4gMDsKIH0KIAotLyoKLSAqIExhdGVyIHdlIGNhbiBnZXQgbW9yZSBw aWNreSBhYm91dCB3aGF0ICJpbiBjb3JlIiBtZWFucyBwcmVjaXNlbHkuCi0gKiBGb3Igbm93LCBz aW1wbHkgY2hlY2sgdG8gc2VlIGlmIHRoZSBwYWdlIGlzIGluIHRoZSBwYWdlIGNhY2hlLAotICog YW5kIGlzIHVwIHRvIGRhdGU7IGkuZS4gdGhhdCBubyBwYWdlLWluIG9wZXJhdGlvbiB3b3VsZCBi ZSByZXF1aXJlZAotICogYXQgdGhpcyB0aW1lIGlmIGFuIGFwcGxpY2F0aW9uIHdlcmUgdG8gbWFw IGFuZCBhY2Nlc3MgdGhpcyBwYWdlLgotICovCi1zdGF0aWMgdW5zaWduZWQgY2hhciBtaW5jb3Jl X3BhZ2Uoc3RydWN0IGFkZHJlc3Nfc3BhY2UgKm1hcHBpbmcsIHBnb2ZmX3QgcGdvZmYpCi17Ci0J dW5zaWduZWQgY2hhciBwcmVzZW50ID0gMDsKLQlzdHJ1Y3QgcGFnZSAqcGFnZTsKLQotCS8qCi0J ICogV2hlbiB0bXBmcyBzd2FwcyBvdXQgYSBwYWdlIGZyb20gYSBmaWxlLCBhbnkgcHJvY2VzcyBt YXBwaW5nIHRoYXQKLQkgKiBmaWxlIHdpbGwgbm90IGdldCBhIHN3cF9lbnRyeV90IGluIGl0cyBw dGUsIGJ1dCByYXRoZXIgaXQgaXMgbGlrZQotCSAqIGFueSBvdGhlciBmaWxlIG1hcHBpbmcgKGll LiBtYXJrZWQgIXByZXNlbnQgYW5kIGZhdWx0ZWQgaW4gd2l0aAotCSAqIHRtcGZzJ3MgLmZhdWx0 KS4gU28gc3dhcHBlZCBvdXQgdG1wZnMgbWFwcGluZ3MgYXJlIHRlc3RlZCBoZXJlLgotCSAqLwot I2lmZGVmIENPTkZJR19TV0FQCi0JaWYgKHNobWVtX21hcHBpbmcobWFwcGluZykpIHsKLQkJcGFn ZSA9IGZpbmRfZ2V0X2VudHJ5KG1hcHBpbmcsIHBnb2ZmKTsKLQkJLyoKLQkJICogc2htZW0vdG1w ZnMgbWF5IHJldHVybiBzd2FwOiBhY2NvdW50IGZvciBzd2FwY2FjaGUKLQkJICogcGFnZSB0b28u Ci0JCSAqLwotCQlpZiAoeGFfaXNfdmFsdWUocGFnZSkpIHsKLQkJCXN3cF9lbnRyeV90IHN3cCA9 IHJhZGl4X3RvX3N3cF9lbnRyeShwYWdlKTsKLQkJCXBhZ2UgPSBmaW5kX2dldF9wYWdlKHN3YXBf YWRkcmVzc19zcGFjZShzd3ApLAotCQkJCQkgICAgIHN3cF9vZmZzZXQoc3dwKSk7Ci0JCX0KLQl9 IGVsc2UKLQkJcGFnZSA9IGZpbmRfZ2V0X3BhZ2UobWFwcGluZywgcGdvZmYpOwotI2Vsc2UKLQlw YWdlID0gZmluZF9nZXRfcGFnZShtYXBwaW5nLCBwZ29mZik7Ci0jZW5kaWYKLQlpZiAocGFnZSkg ewotCQlwcmVzZW50ID0gUGFnZVVwdG9kYXRlKHBhZ2UpOwotCQlwdXRfcGFnZShwYWdlKTsKLQl9 Ci0KLQlyZXR1cm4gcHJlc2VudDsKLX0KLQotc3RhdGljIGludCBfX21pbmNvcmVfdW5tYXBwZWRf cmFuZ2UodW5zaWduZWQgbG9uZyBhZGRyLCB1bnNpZ25lZCBsb25nIGVuZCwKLQkJCQlzdHJ1Y3Qg dm1fYXJlYV9zdHJ1Y3QgKnZtYSwgdW5zaWduZWQgY2hhciAqdmVjKQotewotCXVuc2lnbmVkIGxv bmcgbnIgPSAoZW5kIC0gYWRkcikgPj4gUEFHRV9TSElGVDsKLQlpbnQgaTsKLQotCWlmICh2bWEt PnZtX2ZpbGUpIHsKLQkJcGdvZmZfdCBwZ29mZjsKLQotCQlwZ29mZiA9IGxpbmVhcl9wYWdlX2lu ZGV4KHZtYSwgYWRkcik7Ci0JCWZvciAoaSA9IDA7IGkgPCBucjsgaSsrLCBwZ29mZisrKQotCQkJ dmVjW2ldID0gbWluY29yZV9wYWdlKHZtYS0+dm1fZmlsZS0+Zl9tYXBwaW5nLCBwZ29mZik7Ci0J fSBlbHNlIHsKLQkJZm9yIChpID0gMDsgaSA8IG5yOyBpKyspCi0JCQl2ZWNbaV0gPSAwOwotCX0K LQlyZXR1cm4gbnI7Ci19Ci0KIHN0YXRpYyBpbnQgbWluY29yZV91bm1hcHBlZF9yYW5nZSh1bnNp Z25lZCBsb25nIGFkZHIsIHVuc2lnbmVkIGxvbmcgZW5kLAogCQkJCSAgIHN0cnVjdCBtbV93YWxr ICp3YWxrKQogewotCXdhbGstPnByaXZhdGUgKz0gX19taW5jb3JlX3VubWFwcGVkX3JhbmdlKGFk ZHIsIGVuZCwKLQkJCQkJCSAgd2Fsay0+dm1hLCB3YWxrLT5wcml2YXRlKTsKKwl1bnNpZ25lZCBj aGFyICp2ZWMgPSB3YWxrLT5wcml2YXRlOworCXVuc2lnbmVkIGxvbmcgbnIgPSAoZW5kIC0gYWRk cikgPj4gUEFHRV9TSElGVDsKKworCW1lbXNldCh2ZWMsIDAsIG5yKTsKKwl3YWxrLT5wcml2YXRl ICs9IG5yOwogCXJldHVybiAwOwogfQogCkBAIC0xMjcsOCArNjksOSBAQCBzdGF0aWMgaW50IG1p bmNvcmVfcHRlX3JhbmdlKHBtZF90ICpwbWQsIHVuc2lnbmVkIGxvbmcgYWRkciwgdW5zaWduZWQg bG9uZyBlbmQsCiAJCWdvdG8gb3V0OwogCX0KIAorCS8qIFdlJ2xsIGNvbnNpZGVyIGEgVEhQIHBh Z2UgdW5kZXIgY29uc3RydWN0aW9uIHRvIGJlIHRoZXJlICovCiAJaWYgKHBtZF90cmFuc191bnN0 YWJsZShwbWQpKSB7Ci0JCV9fbWluY29yZV91bm1hcHBlZF9yYW5nZShhZGRyLCBlbmQsIHZtYSwg dmVjKTsKKwkJbWVtc2V0KHZlYywgMSwgbnIpOwogCQlnb3RvIG91dDsKIAl9CiAKQEAgLTEzNywy OCArODAsMTcgQEAgc3RhdGljIGludCBtaW5jb3JlX3B0ZV9yYW5nZShwbWRfdCAqcG1kLCB1bnNp Z25lZCBsb25nIGFkZHIsIHVuc2lnbmVkIGxvbmcgZW5kLAogCQlwdGVfdCBwdGUgPSAqcHRlcDsK IAogCQlpZiAocHRlX25vbmUocHRlKSkKLQkJCV9fbWluY29yZV91bm1hcHBlZF9yYW5nZShhZGRy LCBhZGRyICsgUEFHRV9TSVpFLAotCQkJCQkJIHZtYSwgdmVjKTsKKwkJCSp2ZWMgPSAwOwogCQll bHNlIGlmIChwdGVfcHJlc2VudChwdGUpKQogCQkJKnZlYyA9IDE7CiAJCWVsc2UgeyAvKiBwdGUg aXMgYSBzd2FwIGVudHJ5ICovCiAJCQlzd3BfZW50cnlfdCBlbnRyeSA9IHB0ZV90b19zd3BfZW50 cnkocHRlKTsKIAotCQkJaWYgKG5vbl9zd2FwX2VudHJ5KGVudHJ5KSkgewotCQkJCS8qCi0JCQkJ ICogbWlncmF0aW9uIG9yIGh3cG9pc29uIGVudHJpZXMgYXJlIGFsd2F5cwotCQkJCSAqIHVwdG9k YXRlCi0JCQkJICovCi0JCQkJKnZlYyA9IDE7Ci0JCQl9IGVsc2UgewotI2lmZGVmIENPTkZJR19T V0FQCi0JCQkJKnZlYyA9IG1pbmNvcmVfcGFnZShzd2FwX2FkZHJlc3Nfc3BhY2UoZW50cnkpLAot CQkJCQkJICAgIHN3cF9vZmZzZXQoZW50cnkpKTsKLSNlbHNlCi0JCQkJV0FSTl9PTigxKTsKLQkJ CQkqdmVjID0gMTsKLSNlbmRpZgotCQkJfQorCQkJLyoKKwkJCSAqIG1pZ3JhdGlvbiBvciBod3Bv aXNvbiBlbnRyaWVzIGFyZSBhbHdheXMKKwkJCSAqIHVwdG9kYXRlCisJCQkgKi8KKwkJCSp2ZWMg PSAhIW5vbl9zd2FwX2VudHJ5KGVudHJ5KTsKIAkJfQogCQl2ZWMrKzsKIAl9Cg== --000000000000ff4c37057ec05817--