From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 001F1D597B7 for ; Wed, 13 Nov 2024 00:23:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87DA26B009B; Tue, 12 Nov 2024 19:23:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 805C26B00A0; Tue, 12 Nov 2024 19:23:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67FA46B00B7; Tue, 12 Nov 2024 19:23:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3D15F6B009B for ; Tue, 12 Nov 2024 19:23:52 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B1AADC0689 for ; Wed, 13 Nov 2024 00:23:51 +0000 (UTC) X-FDA: 82779171510.09.D61365C Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf28.hostedemail.com (Postfix) with ESMTP id 8D2DEC0011 for ; Wed, 13 Nov 2024 00:23:06 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=aaNHQB2y; spf=pass (imf28.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.49 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731457374; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WupZbUO57pzsyzLIiF16uH4yNUQCRicfvRdbxH31iT8=; b=kiLYSKDK4ign8hyNQu/PWaFfNOQ9gJLxFk6Se3DzIqQKOgtWqXslytfV3/GUKiATvkruhS C41WP2TB8hPhSZ9VUgrO6M4EbqROlIfVpIMhQkjlIfVairM6yeXIUPmTxs8gS/cCHYSSd2 Djvgj2T2HfntNcvlgl+kX5qDjk0IG20= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731457374; a=rsa-sha256; cv=none; b=5FTrbd69Fk63NMSL9hAFmlxMHoGHZrFGUo+9R2qb1vj2aWqXV78kIxc/kU9Qn1GSNsb4qT FJWQDZajYb4eQVIkbNbGNTD2gKrtooqFsqfxWWAyUk8URP+rn2KZaT/ok883gXyBpaCYOg lSI7zNM2dEDUOem8Yjljd4FgEeWd5II= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=aaNHQB2y; spf=pass (imf28.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.49 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5cec9609303so7666525a12.1 for ; Tue, 12 Nov 2024 16:23:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1731457428; x=1732062228; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=WupZbUO57pzsyzLIiF16uH4yNUQCRicfvRdbxH31iT8=; b=aaNHQB2yeB7Yg0lvOmzv9PCwLNMyEtkuh15K4rgRdxAxJT9MtjMhskyEIveQ26TIhG 0rjymG4o5ncxLlpDZ1QvQ5ph0413O1lxL43En4IDr6hdLicNO7jkwg2RV9H0xal/BOK8 eYf3hI97SQNo29VGl22WBk1qZrQ+ojQ8jS31I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731457428; x=1732062228; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WupZbUO57pzsyzLIiF16uH4yNUQCRicfvRdbxH31iT8=; b=iPR+gv2oN1ulGNqB5h1xlJvq5ti6TWy5Etj5N910hEgvM1GdUTttnYV4ZZmctij8Ol pBqCpPFX0yCmSb9qjO+GiKBZoXMGW5Cp6kyNWvb7zmLIqmHqR29fYvFuBlwb5K54Vrka Ywc+5Vj7E5qVRfzjAx5OD8+GdfHMlckPe5TMVx5DA+GysF8WGDpOfR2+BdJ+uC4E7p94 Cf5efeC4Nw0IukWTCIloJt9tgicPWe+3B9095e+9HZTINFxYONXARBc14BnzMNFcCNfI ouP43mBSgG/aeGaXwHMzeucM+tz9YDAKuDdfDNGdCtGfZLIe856iZFvHUgygo1cyewHd EiOA== X-Forwarded-Encrypted: i=1; AJvYcCXsqkwzg1VEcDQSQeBG2WfAJ25uQK1FC0hjgmvv7pj8Kv6iwoGQ5gRQkGw8duuT7irxNnNiIgKgjg==@kvack.org X-Gm-Message-State: AOJu0YwBPBRiL6vNMWs0Ry5YdXdZ+m2xz+QeCosM/SPholiZ8SrHn/pZ wSEk5IzUBFdL5kl9XSWjSELYdQOIzgRjob2aJdwhMhy/j4F8EPQDAygt9Sf0coSkzmIQ7Vr3g3m NRw7raw== X-Google-Smtp-Source: AGHT+IElsUUDXnvJUyr0vCk94cKol7lIEzHhEfSEinAZhzqIE0bhqHnhOn12GT25jPkOK5jaER1/tA== X-Received: by 2002:a05:6402:1e91:b0:5cf:22ab:c3b3 with SMTP id 4fb4d7f45d1cf-5cf22abcbb9mr10592058a12.2.1731457427974; Tue, 12 Nov 2024 16:23:47 -0800 (PST) Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com. [209.85.218.49]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5cf03bb5ed3sm6579414a12.38.2024.11.12.16.23.45 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Nov 2024 16:23:46 -0800 (PST) Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a99eb8b607aso902690066b.2 for ; Tue, 12 Nov 2024 16:23:45 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWEMfHlZo8snLqn7h/vLE79WORytsZyNRIDarW7Rk81EzxBzkYa/6WXaKwz0Xn629VyU+XI7JbspQ==@kvack.org X-Received: by 2002:a17:907:94c4:b0:a9e:8522:1bd8 with SMTP id a640c23a62f3a-a9eefebd13bmr1910160166b.6.1731457424914; Tue, 12 Nov 2024 16:23:44 -0800 (PST) MIME-Version: 1.0 References: <141e2cc2dfac8b2f49c1c8d219dd7c20925b2cef.1731433903.git.josef@toxicpanda.com> <20241113001251.GF3387508@ZenIV> In-Reply-To: <20241113001251.GF3387508@ZenIV> From: Linus Torvalds Date: Tue, 12 Nov 2024 16:23:28 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 05/18] fsnotify: introduce pre-content permission events To: Al Viro Cc: Amir Goldstein , Josef Bacik , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, brauner@kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: p8nigfnocn66t84epdt5k1djkfasng9d X-Rspam-User: X-Rspamd-Queue-Id: 8D2DEC0011 X-Rspamd-Server: rspam02 X-HE-Tag: 1731457386-573553 X-HE-Meta: U2FsdGVkX18nlUv7XsdlNaKo/Nje4WUncXqcc9NPtapp8LF96dYMOZ8HYs9UhifMhDAGNtfjf5LmXO3SopKxhF+olrV8YXvqs7RknZWEvbwxr40JApOKpJKvbXT/3pqRBF+hZd6ydCn89Kf+OU80ybLNouS+uGnXXhDgMcLdDXf0gNULZ3gt+Ak8U82xptGew28SBu0z8aQMzsuvim6mQDd5YfzM71tygK6+F5xZdP/4Fs6HVJOdQVWjhwQv323cbM3K6QvFLQdCIbyb91cwMeXOD7BzZed5Fd3tTkowdUN/tUcfux+5/sycWKhjr3gKry5MXNmYh8X2FEfhSsv+9prj4FMVeoyq0MaP7xsIFpVclATSnuq351PU6jSez0qcybmykiaCt1G+hPj9+sNyhXGh7lUmDqFXnP40gMAU6gtyvLRI0wS+0odjJBqTQl/GDqSfYFlRXcofVh7tJwkEKmJaB7zj15iB31DXCqsVoZk3UQoUmprE5TK8EyyUARyLdnei2JSZay8J835rWUTiIBpET+RyFPfs4AGZKyl0OHpxJ487YGh4Ju1kskFER7dnlw8JBe1eJ3YKDWNsCpYPHImePPDhPRqWhPU1UJax2yZdphQEX66/2x6C+AcF5+iNaR2rDrlhi8WvXCo4CfjqEQWOv/LtexqIxWL1ghNVZO3PpVBnlKHIESq3V3Iabw4JYZQ9WxCTPXrF+3rrkFMSzKmxPJdmvkyWNMVMnkWSpWMUJ+eLrZ+z1+OOGemRfOwxN08rqD/dVUBW/sx0W8Uf8ETRwBio+/nkOTXkBGjOVusATz6U7Ww8eeRBr8Y+he8DkhAkYyz92oMXoq8mG4Oj2kL75pKRrveWQYt6W6Vkg2iPz+NBiU6YYBbo7dqHqmPBV0A6aQ6xN1gWK1i9D+NKqS9s/JMejLQCS8zpFtn2ChCbK7UgVb1enlcmGagcA5PVTYOB9Ph8jPidvDq3zqW eJQL+JmI O6xX+EcoT0aBbltFvsO3GRP3EnYtQ4nDpeIsR7dYMMGDn1IYGZyXNMBo523jo8wqtaiP7Zs9MotCPQ5jt5zEG8mpiWdyb1V1uYHR5g8Q1mdt+WBzmrOF7ZZxDpYkkPNcAdSJqqeEXwe8uv5GtmxpV/V+xpszJ7B1OuzOgVZ1gZo6YmGAymHq/K42UOplSfqg8ITcgYMG2Ir3aL1O4gPRFtvJFCA99L/9UUZVI4iN24IRVMy06d32lB7NQ9vdXU/ttnzrON2cBm1yhvga43+pzpGdLJPpwWMQfA2LBNpgQm0z6AjcMNPyzSYIhZAcmAKtma4ZSlgX+JvZGQOFz6KBhZpfUVvnwzzv9lfv/jgL+sQr00lO/V4AN0aCOcln+gIAXme1kBWeYMUbKXyaxlOL3FdkYwUGqN31e+OL/e8M2PtyONRST+Ulxs1+pnqRJN0Se7GTV3FQqGk8PIla0oLXB74/cGmmGDndaBQLXTcHbBI64IFGlsyuu1SJR4wq8g0EEMy9eVN1mfSdR6tllgvnRRHP8lZkiFtSaWZb2guwTkLCQF7aUOtSnTsMX1rxcBfG/NGMV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 12 Nov 2024 at 16:12, Al Viro wrote: > > Ugh... Actually, I would rather mask that on fcntl side (and possibly > moved FMODE_RANDOM/FMODE_NOREUSE over there as well). Yeah, that's probably cleaner. I was thinking the bitfield would be a simpler solution, but we already mask writes to specific bits on the fcntl side for other reasons *anyway*, so we might as well mask reads too, and just not expose any kernel-internal bits to user space. > Would make for simpler rules for locking - ->f_mode would be never > changed past open, ->f_flags would have all changes under ->f_lock. Yeah, sounds sane. That said, just looking at which bits are used in f_flags is a major PITA. About half the definitions use octal, with the other half using hex. Lovely. So I'd rather not touch that mess until we have to. Linus